From 06df067cd74ca55a80ef5ee12e66c139f6d1d31e Mon Sep 17 00:00:00 2001 From: rcourtman Date: Wed, 4 Feb 2026 11:30:37 +0000 Subject: [PATCH] Cover apply-restart auth guards --- internal/api/security_regression_test.go | 55 ++++++++++++++++++++++++ 1 file changed, 55 insertions(+) diff --git a/internal/api/security_regression_test.go b/internal/api/security_regression_test.go index 02ad0f9a8..c25c44951 100644 --- a/internal/api/security_regression_test.go +++ b/internal/api/security_regression_test.go @@ -2302,3 +2302,58 @@ func TestPermissionProtectedEndpointsDenyWhenAuthorizerBlocks(t *testing.T) { } } } + +func TestApplyRestartRequiresAuthInAPIMode(t *testing.T) { + record := newTokenRecord(t, "apply-restart-token-123.12345678", []string{config.ScopeSettingsWrite}, nil) + cfg := newTestConfigWithTokens(t, record) + router := NewRouter(cfg, nil, nil, nil, nil, "1.0.0") + + req := httptest.NewRequest(http.MethodPost, "/api/security/apply-restart", nil) + rec := httptest.NewRecorder() + router.Handler().ServeHTTP(rec, req) + if rec.Code != http.StatusUnauthorized { + t.Fatalf("expected 401 without auth, got %d", rec.Code) + } +} + +func TestApplyRestartRequiresSettingsWriteScope(t *testing.T) { + rawToken := "apply-restart-scope-token-123.12345678" + record := newTokenRecord(t, rawToken, []string{config.ScopeSettingsRead}, nil) + cfg := newTestConfigWithTokens(t, record) + router := NewRouter(cfg, nil, nil, nil, nil, "1.0.0") + + req := httptest.NewRequest(http.MethodPost, "/api/security/apply-restart", nil) + req.Header.Set("X-API-Token", rawToken) + rec := httptest.NewRecorder() + router.Handler().ServeHTTP(rec, req) + if rec.Code != http.StatusForbidden { + t.Fatalf("expected 403 for missing settings:write scope, got %d", rec.Code) + } + if !strings.Contains(rec.Body.String(), config.ScopeSettingsWrite) { + t.Fatalf("expected missing scope response to mention %q, got %q", config.ScopeSettingsWrite, rec.Body.String()) + } +} + +func TestApplyRestartRequiresProxyAdmin(t *testing.T) { + record := newTokenRecord(t, "apply-restart-proxy-token-123.12345678", []string{config.ScopeSettingsWrite}, nil) + cfg := newTestConfigWithTokens(t, record) + cfg.ProxyAuthSecret = "proxy-secret" + cfg.ProxyAuthUserHeader = "X-Remote-User" + cfg.ProxyAuthRoleHeader = "X-Remote-Roles" + cfg.ProxyAuthAdminRole = "admin" + + router := NewRouter(cfg, nil, nil, nil, nil, "1.0.0") + + req := httptest.NewRequest(http.MethodPost, "/api/security/apply-restart", nil) + req.Header.Set("X-Proxy-Secret", cfg.ProxyAuthSecret) + req.Header.Set("X-Remote-User", "viewer-user") + req.Header.Set("X-Remote-Roles", "viewer") + rec := httptest.NewRecorder() + router.Handler().ServeHTTP(rec, req) + if rec.Code != http.StatusForbidden { + t.Fatalf("expected 403 for non-admin proxy user, got %d", rec.Code) + } + if !strings.Contains(rec.Body.String(), "Admin privileges required") { + t.Fatalf("expected admin privilege error, got %q", rec.Body.String()) + } +}