From 02d63661ac527e8470e6ecfbd26f4bca755d7828 Mon Sep 17 00:00:00 2001 From: "courtmanr@gmail.com" Date: Fri, 30 May 2025 17:23:13 +0100 Subject: [PATCH] fix: resolve sticky column border visual artifacts at different resolutions MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Add bottom border to sticky columns in dashboard, PBS, and storage views - Ensure sticky cells inherit row background colors (failed/running tasks) - Fix issue where every other row appeared grouped due to missing borders Fixes #87 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude --- src/public/js/ui/dashboard.js | 2 +- src/public/js/ui/pbs.js | 9 ++++++++- src/public/js/ui/storage.js | 2 +- 3 files changed, 10 insertions(+), 3 deletions(-) diff --git a/src/public/js/ui/dashboard.js b/src/public/js/ui/dashboard.js index 71d8b5d6b..92061f36c 100644 --- a/src/public/js/ui/dashboard.js +++ b/src/public/js/ui/dashboard.js @@ -1003,7 +1003,7 @@ PulseApp.ui.dashboard = (() => { } row.innerHTML = ` - ${guest.name} + ${guest.name} ${typeIcon} ${guest.id} ${uptimeDisplay} diff --git a/src/public/js/ui/pbs.js b/src/public/js/ui/pbs.js index 86da70468..907f1ce57 100644 --- a/src/public/js/ui/pbs.js +++ b/src/public/js/ui/pbs.js @@ -438,7 +438,14 @@ PulseApp.ui.pbs = (() => { row.className = rowClasses; const targetCell = document.createElement('td'); - targetCell.className = `${CSS_CLASSES.P1_PX2} ${CSS_CLASSES.TEXT_SM} ${CSS_CLASSES.TEXT_GRAY_700_DARK_GRAY_300} sticky left-0 bg-white dark:bg-gray-800 z-10`; + // Determine sticky cell background based on task status + let stickyBg = 'bg-white dark:bg-gray-800'; + if (isFailed) { + stickyBg = 'bg-red-50 dark:bg-red-900/20'; + } else if (task.status && task.status.toLowerCase().includes('running')) { + stickyBg = 'bg-blue-50 dark:bg-blue-900/20'; + } + targetCell.className = `${CSS_CLASSES.P1_PX2} ${CSS_CLASSES.TEXT_SM} ${CSS_CLASSES.TEXT_GRAY_700_DARK_GRAY_300} sticky left-0 ${stickyBg} z-10 border-b border-gray-200 dark:border-gray-700`; // Add expand indicator for failed tasks if (isFailed) { diff --git a/src/public/js/ui/storage.js b/src/public/js/ui/storage.js index 8f953d132..b5fe1d770 100644 --- a/src/public/js/ui/storage.js +++ b/src/public/js/ui/storage.js @@ -595,7 +595,7 @@ PulseApp.ui.storage = (() => { (isWarning ? ' ' : ''); row.innerHTML = ` - ${store.storage || 'N/A'}${warningBadge} + ${store.storage || 'N/A'}${warningBadge} ${contentBadges} ${store.type || 'N/A'} ${sharedText}