mirror of
https://github.com/projectsend/projectsend.git
synced 2026-09-17 17:15:08 +00:00
ignacionelson
bab90c0ad8
Every upload now starts as "being checked" and is not served to anyone until a scanner has looked at it. Infected files are quarantined: kept on disk, unreachable, waiting for an administrator. The scanner is ClamAV, reached over a socket, streaming the file wherever it is stored — no temporary copy for an S3 or GCS disk. What the scanner answers is a fact; what it means for the file is this installation's setting, so ClamAvScanner knows nothing about settings and ScanPolicy knows nothing about sockets. Three of clamd's own alert options are what make a file it could not open come back as an answer rather than as "OK"; the client maps those to "too large" and "encrypted" instead of to a threat. Both policies default to letting files through, marked "not scanned", which is the product owner's decision: a scanner that cannot answer must not stop people working. Every such file is logged, and the screens that say so come with the rest of this work. Withholding is two rules. A file that is not available drops out of the scopes that answer "what may this person see" — recipients and the public listings, never the uploader's own copy. And every route that puts bytes on the wire asks FileAvailability first: download, thumbnail, preview, share link, the four public routes and both ends of a zip build. A share link minted before the scan finishes says the file is still being checked rather than 404ing. Not yet here, and coming next: the quarantine screen and its permission, the notifications, the settings screen, the hourly retry, the backfill for existing libraries, and the Docker service.
36 lines
1.1 KiB
PHP
36 lines
1.1 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
namespace App\Modules\Files\Scanning;
|
|
|
|
/**
|
|
* The seam between this application and whatever actually reads the
|
|
* bytes.
|
|
*
|
|
* One implementation ships (ClamAvScanner) and one more lives in the test
|
|
* suite. It exists as an interface because a commercial engine is a
|
|
* plausible later addition and because every test that is *about* policy
|
|
* — what happens to a file the scanner could not open — should be able to
|
|
* state the verdict rather than produce a file that provokes it.
|
|
*/
|
|
interface VirusScanner
|
|
{
|
|
/**
|
|
* Read a file and say what it is.
|
|
*
|
|
* Implementations never throw for a scanner that is down or slow:
|
|
* that is ScanVerdict::unavailable(), because the caller has a policy
|
|
* for it and an exception would look like a bug in the job.
|
|
*
|
|
* @param resource $stream the file's bytes, at position 0
|
|
* @param int $size the file's size in bytes
|
|
*/
|
|
public function scan(mixed $stream, int $size): ScanVerdict;
|
|
|
|
/**
|
|
* Whether the scanner answers, and what it is running.
|
|
*/
|
|
public function status(): ScannerStatus;
|
|
}
|