mirror of
https://github.com/projectsend/projectsend.git
synced 2026-09-19 10:05:11 +00:00
ignacionelson
f937b4398d
A row whose bytes are gone was recorded as "the scanner could not be
reached". Wrong on screen, and wrong underneath: that is the one reason
the hourly sweep re-queues, so every orphaned row would have been
rescanned hourly forever.
It is its own state now, `missing`, and withheld rather than offered:
a client who sees a file listed and gets an error on the download is
worse off than one who never saw it. Staff still see it, marked, which
is the point — somebody has to decide what to do about it. The refusal
says what it is ("no longer on the server") instead of sending somebody
looking for a permission that would let them through.
A daily `projectsend:check-missing-files` finds them, whether or not
this installation scans for viruses: it is not a virus question, and an
installation with no scanner has exactly the same problem. It compares
one disk listing against the rows rather than asking "does this exist?"
per file, which on object storage would be a request per file per day.
Files that come back — a remount, a restored backup — are picked up on
the next run and re-checked rather than left for dead.
They are listed beside the orphans, which is the same fault seen from
the other end: bytes with no row, rows with no bytes. The tab carries
the count, each row says where the file should be, and removing one
takes the record with it through the deletion that already exists.
The dashboard says how many there are, and so does
`projectsend:status`, because a fleet-wide jump in this is a storage
fault nothing else in that document would show.
39 lines
1.2 KiB
PHP
39 lines
1.2 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
namespace App\Modules\Files\Scanning;
|
|
|
|
/**
|
|
* Why a file carries ScanStatus::NotScanned — stored in `scan_note`.
|
|
*
|
|
* Four different things to say to a person, and two of them are the
|
|
* installation's own doing rather than the file's, so a single "not
|
|
* scanned" badge with no reason would be unactionable.
|
|
*/
|
|
enum NotScannedReason: string
|
|
{
|
|
/** Bigger than the largest file this installation scans. */
|
|
case TooLarge = 'too_large';
|
|
|
|
/** An encrypted archive or document the scanner cannot open. */
|
|
case Encrypted = 'encrypted';
|
|
|
|
/** The scanner could not be reached in time, and the policy lets files through. */
|
|
case ScannerUnavailable = 'scanner_unavailable';
|
|
|
|
/** Uploaded before scanning was switched on, or while it is off. */
|
|
case BeforeScanning = 'before_scanning';
|
|
|
|
|
|
public function label(): string
|
|
{
|
|
return match ($this) {
|
|
self::TooLarge => 'Too large to scan',
|
|
self::Encrypted => 'Encrypted, so it could not be scanned',
|
|
self::ScannerUnavailable => 'The scanner could not be reached',
|
|
self::BeforeScanning => 'Uploaded before virus scanning was switched on',
|
|
};
|
|
}
|
|
}
|