Files
pad/internal/acceptance/acceptance_test.go
T
xarmian 3631139de0 feat(acceptance): one Go reading of a body's acceptance criteria (PLAN-3598 slice (a)) (#2091)
* feat(acceptance): one Go reading of a body's acceptance criteria (PLAN-3598 slice (a))

`pad item context` (PLAN-3598) returns a governing spec's acceptance
criteria as data. Until now the only readings were prose: the verify and
decompose playbooks tell the agent to find the section and skip skeleton
lines. internal/acceptance.Parse implements that same rule: the first
"Acceptance criteria" heading at any level, up to the next heading of the
same or higher level; "- AC-N: text" bullets, with indented continuation
lines joined; angle-bracket or bare-ellipsis text reported as a placeholder,
not a criterion; headings and AC lines inside code fences ignored.

The spec template's own skeleton is pinned to read as two placeholders and
no criteria, so a fresh spec never claims real ones.

Claude-Session: https://claude.ai/code/session_01Q9WssCjFuHjSfLABoW4tmS

* fix(acceptance): CommonMark fences, setext headings, and nested AC bullets (PLAN-3598 slice (a))

Codex round 1 at b1091c645 found three P2s. A fence closed on any line
sharing its first three characters, so a four-backtick block ended at a
three-backtick line or an info-string line, and fenced headings could end
the section. A bullet indented under a criterion counted as a criterion of
its own. Setext headings were not recognized at all.

Fences now close only on a run of their own character at least as long as
the opener with nothing after it, and a backtick opener with a backtick in
its info string is not a fence. Setext underlines make headings only under
a paragraph line, never under a list item or an indented continuation,
where the underline is a thematic break. A criterion is a top-level bullet;
an indented AC-shaped bullet joins the text of the criterion above it.

Six of the new cases fail on the previous parser.

Claude-Session: https://claude.ai/code/session_01Q9WssCjFuHjSfLABoW4tmS

* fix(acceptance): nesting follows the parent item's content column (PLAN-3598 slice (a))

Codex round 2 at ad43c92d1: the round-1 fix allowed a criterion at most
one space of indent, so a top-level list indented two or three spaces lost
its criteria. Nesting is now decided the CommonMark way: a bullet indented
to at least the open item's content column is nested in it, and joins the
criterion's text when that item is one. A bullet short of that column,
indented up to three spaces, starts a new top-level item.

Claude-Session: https://claude.ai/code/session_01Q9WssCjFuHjSfLABoW4tmS
2026-10-11 21:19:39 -04:00

205 lines
6.3 KiB
Go

package acceptance
import (
"reflect"
"testing"
)
func TestParse(t *testing.T) {
cases := []struct {
name string
body string
found bool
criteria []Criterion
placeholders []string
raw string
}{
{
name: "no heading",
body: "## Goals\n\n- AC-1: not under the heading\n",
found: false,
},
{
name: "real criteria, section ends at the next same-level heading",
body: "## Context\n\nx\n\n## Acceptance criteria\n\n- AC-1: the copy is refused\n- AC-2: the key is released\n\n## Open questions\n\n- AC-3: not a criterion\n",
found: true,
criteria: []Criterion{
{ID: "AC-1", Text: "the copy is refused"},
{ID: "AC-2", Text: "the key is released"},
},
placeholders: []string{},
raw: "- AC-1: the copy is refused\n- AC-2: the key is released",
},
{
name: "a deeper heading stays inside the section",
body: "## Acceptance criteria\n\n### Server\n\n- AC-1: a\n\n# Next\n- AC-2: b\n",
found: true,
criteria: []Criterion{
{ID: "AC-1", Text: "a"},
},
placeholders: []string{},
raw: "### Server\n\n- AC-1: a",
},
{
name: "skeleton lines are placeholders: angle brackets, bare ellipsis, empty",
body: "## Acceptance criteria\n\n- AC-1: <a statement>\n- AC-2: ...\n- AC-3: …\n- AC-4:\n- AC-5: real <b>bold</b> text\n",
found: true,
criteria: []Criterion{
{ID: "AC-5", Text: "real <b>bold</b> text"},
},
placeholders: []string{"AC-1", "AC-2", "AC-3", "AC-4"},
},
{
name: "indented continuation joins; prose and other bullets end it",
body: "## Acceptance criteria\n- AC-1: first line\n second line\n- not a criterion\n stray indent\n* AC-2: star bullet\n",
found: true,
criteria: []Criterion{
{ID: "AC-1", Text: "first line second line"},
{ID: "AC-2", Text: "star bullet"},
},
placeholders: []string{},
},
{
name: "headings and AC lines inside a code fence are ignored",
body: "```\n## Acceptance criteria\n- AC-9: fenced\n```\n## Acceptance Criteria ##\n- AC-1: real\n~~~\n- AC-2: fenced too\n## Not a heading here\n~~~\n- AC-3: after the fence\n",
found: true,
criteria: []Criterion{
{ID: "AC-1", Text: "real"},
{ID: "AC-3", Text: "after the fence"},
},
placeholders: []string{},
},
{
name: "a fence closes only on its own marker, at least as long, with nothing after",
body: "## Acceptance criteria\n````\n```\n- AC-8: still fenced\n```info\n- AC-9: still fenced\n````\n- AC-1: after\n",
found: true,
criteria: []Criterion{
{ID: "AC-1", Text: "after"},
},
placeholders: []string{},
},
{
name: "a fenced heading cannot end the section once a short closer fails to close the fence",
body: "## Acceptance criteria\n- AC-1: a\n````\n```\n## Fenced\n````\n- AC-2: b\n",
found: true,
criteria: []Criterion{
{ID: "AC-1", Text: "a"},
{ID: "AC-2", Text: "b"},
},
placeholders: []string{},
},
{
name: "a backtick run with a backtick in its info string is not a fence",
body: "## Acceptance criteria\n``` a`b\n- AC-1: not fenced\n",
found: true,
criteria: []Criterion{
{ID: "AC-1", Text: "not fenced"},
},
placeholders: []string{},
},
{
name: "an indented AC-shaped bullet is nested, not a criterion",
body: "## Acceptance criteria\n- AC-1: outer\n - AC-2: example\n- AC-3: next\n",
found: true,
criteria: []Criterion{
{ID: "AC-1", Text: "outer - AC-2: example"},
{ID: "AC-3", Text: "next"},
},
placeholders: []string{},
},
{
name: "a top-level list indented up to three spaces still holds criteria",
body: "## Acceptance criteria\n - AC-1: two spaces\n - AC-2: also top level\n * AC-3: three spaces\n",
found: true,
criteria: []Criterion{
{ID: "AC-1", Text: "two spaces"},
{ID: "AC-2", Text: "also top level"},
{ID: "AC-3", Text: "three spaces"},
},
placeholders: []string{},
},
{
name: "an AC-shaped bullet nested under a non-criterion item is not a criterion",
body: "## Acceptance criteria\n- Notes\n - AC-7: an example\n- AC-1: real\n",
found: true,
criteria: []Criterion{
{ID: "AC-1", Text: "real"},
},
placeholders: []string{},
},
{
name: "setext headings open and close the section",
body: "Acceptance criteria\n===================\n- AC-1: a\n\nOpen questions\n==============\n- AC-2: b\n",
found: true,
criteria: []Criterion{
{ID: "AC-1", Text: "a"},
},
placeholders: []string{},
raw: "- AC-1: a",
},
{
name: "a dash underline under a list item or an indented line is a thematic break, not a heading",
body: "Acceptance criteria\n---\n- AC-1: a\n---\n- AC-2: b\n more\n---\n- AC-3: c\n# Next\n",
found: true,
criteria: []Criterion{
{ID: "AC-1", Text: "a"},
{ID: "AC-2", Text: "b more"},
{ID: "AC-3", Text: "c"},
},
placeholders: []string{},
},
{
name: "a hash with no space after it is not a heading",
body: "## Acceptance criteria\n- AC-1: a\n#hashtag\n- AC-2: b\n",
found: true,
criteria: []Criterion{
{ID: "AC-1", Text: "a"},
{ID: "AC-2", Text: "b"},
},
placeholders: []string{},
},
{
name: "heading with nothing under it",
body: "## Acceptance criteria\n\n## Next\n",
found: true,
criteria: []Criterion{},
placeholders: []string{},
raw: "",
},
{
name: "CRLF bodies",
body: "## Acceptance criteria\r\n- AC-1: windows\r\n",
found: true,
criteria: []Criterion{
{ID: "AC-1", Text: "windows"},
},
placeholders: []string{},
},
}
for _, tc := range cases {
t.Run(tc.name, func(t *testing.T) {
got := Parse(tc.body)
if got.Found != tc.found {
t.Fatalf("Found = %v, want %v", got.Found, tc.found)
}
if !tc.found {
if got.Criteria != nil || got.Placeholders != nil || got.Raw != "" {
t.Fatalf("not found, but got %+v", got)
}
return
}
if !reflect.DeepEqual(got.Criteria, tc.criteria) {
t.Errorf("Criteria = %#v, want %#v", got.Criteria, tc.criteria)
}
if !reflect.DeepEqual(got.Placeholders, tc.placeholders) {
t.Errorf("Placeholders = %#v, want %#v", got.Placeholders, tc.placeholders)
}
if tc.raw != "" || tc.name == "heading with nothing under it" {
if got.Raw != tc.raw {
t.Errorf("Raw = %q, want %q", got.Raw, tc.raw)
}
}
})
}
}