xarmian
cc26288794
fix(web): share pages render attachment refs as honest placeholders (BUG-2389) ( #1135 )
...
The public share route (/s/{token}) rendered item content with a bare
marked() call, so pad-attachment: references fell through as broken
<img src="pad-attachment:..."> tags and dead links. Two halves:
1. CommentThread.svelte is deleted outright — grep proved it was
unmounted dead code (its only reference was a prose mention in
ItemDetail.svelte), so its half of the bug resolves by deletion
rather than by fixing a component nothing renders.
2. The share route now renders through a new opt-in wrapper,
renderMarkedWithAttachments(), which threads an AttachmentRenderContext
into the existing marked renderer hooks. With a null resolver and the
new renderAttachmentUnavailable() placeholder, every ref becomes an
honest "Attachments aren't available on shared pages yet" chip —
deliberately NOT the "missing or has been deleted" wording, because
the attachment exists; the share surface just cannot serve its bytes.
Sanitization is unchanged: the wrapper returns unsanitized HTML and
the share page keeps its single DOMPurify pass.
The `missing` hook is a parameter (default: renderAttachmentMissing) so
authed surfaces keep their existing wording, and the wrapper clears the
module context in a finally block so bare marked() callers are
unaffected (pinned by test).
The token-scoped byte endpoint that would serve real images on share
pages (2b) is deliberately NOT built here — it adds a new
unauthenticated ACL surface and is tracked separately pending approval.
A real resolver through the same wrapper is the plug-in point (pinned
by test).
Tests: markdown.shareAttachments.test.ts (6 unit legs incl. bare-marked
opt-in control and context-clearing) and
bug-2389-share-attachment-placeholder.spec.ts (e2e: real upload → item
ref → item share link → anonymous visit; verified failing on the
pre-fix build).
Claude-Session: https://claude.ai/code/session_017jD6t1zjxGSq47SQpZfp1V
2026-08-17 05:19:25 -04:00
..
2026-04-29 15:41:12 -04:00
2026-08-15 08:22:09 -04:00
2026-06-22 11:43:52 -04:00
2026-08-02 05:22:30 +00:00
2026-07-30 20:15:00 +00:00
2026-07-31 02:35:53 +00:00
2026-05-06 08:40:11 -04:00
2026-05-06 13:27:12 -04:00
2026-06-15 14:44:58 -04:00
2026-05-18 00:43:46 -04:00
2026-05-18 00:43:46 -04:00
2026-08-15 19:18:55 -04:00
2026-07-14 20:37:03 -04:00
2026-04-25 11:35:19 -04:00
2026-04-25 11:35:19 -04:00
2026-07-10 23:56:59 -04:00
2026-07-10 23:56:59 -04:00
2026-07-05 20:47:30 -04:00
2026-07-04 14:38:01 -04:00
2026-07-05 20:47:30 -04:00
2026-07-05 19:58:07 -04:00
2026-07-08 16:26:41 -04:00
2026-07-15 01:30:12 -04:00
2026-04-28 12:26:39 -04:00
2026-04-28 12:26:39 -04:00
2026-04-28 16:21:43 -04:00
2026-07-01 17:44:43 -04:00
2026-07-04 04:15:09 -04:00
2026-07-04 04:15:09 -04:00
2026-07-01 17:44:43 -04:00
2026-04-28 12:26:39 -04:00
2026-06-27 21:42:52 -05:00
2026-08-17 05:19:25 -04:00
2026-06-22 13:31:45 -04:00
2026-08-02 00:55:20 +00:00
2026-08-08 20:37:39 +00:00
2026-04-29 15:41:12 -04:00
2026-08-01 19:53:12 +00:00
2026-08-01 23:27:34 +00:00
2026-08-17 04:21:32 -04:00
2026-08-17 04:21:32 -04:00
2026-08-01 23:05:26 +00:00
2026-04-29 15:02:07 -04:00
2026-08-02 00:55:20 +00:00
2026-08-02 00:55:20 +00:00
2026-08-08 20:37:39 +00:00
2026-07-14 20:37:03 -04:00
2026-05-06 13:27:12 -04:00
2026-05-06 08:40:11 -04:00
2026-06-22 20:58:50 -04:00
2026-04-21 19:33:47 -04:00
2026-04-21 20:52:03 -04:00
2026-04-22 12:21:34 -04:00
2026-07-05 18:44:26 -04:00
2026-07-05 18:44:26 -04:00
2026-05-27 10:37:30 -04:00
2026-06-27 21:42:52 -05:00
2026-07-08 13:09:26 -04:00
2026-07-08 13:09:26 -04:00
2026-04-29 14:35:49 -04:00
2026-04-25 11:53:31 -04:00
2026-05-18 15:25:27 -04:00
2026-07-05 12:05:24 -04:00
2026-04-22 09:27:45 -04:00
2026-06-20 23:51:43 -04:00
2026-07-04 11:33:18 -04:00
2026-07-04 11:33:18 -04:00
2026-07-15 01:30:12 -04:00
2026-07-21 20:51:19 -04:00
2026-07-03 18:12:35 -04:00
2026-07-21 09:43:05 -04:00
2026-07-03 03:27:04 -04:00
2026-07-21 09:43:05 -04:00
2026-07-03 18:24:36 -04:00
2026-05-30 12:38:57 -04:00
2026-08-12 15:50:41 -04:00
2026-05-18 08:33:39 -04:00
2026-05-18 03:32:42 -04:00
2026-05-18 08:33:39 -04:00
2026-05-21 13:08:02 -04:00
2026-07-11 09:38:14 -04:00
2026-07-08 12:02:12 -04:00
2026-05-14 22:10:12 -04:00
2026-05-20 16:39:23 -04:00
2026-07-21 09:43:05 -04:00
2026-07-14 23:43:19 -04:00
2026-04-28 12:26:39 -04:00
2026-05-18 18:29:28 -04:00
2026-07-21 09:43:05 -04:00
2026-04-29 18:30:43 -04:00
2026-07-04 13:54:08 -04:00
2026-07-04 13:54:08 -04:00
2026-07-21 09:43:05 -04:00
2026-07-03 20:18:29 -04:00
2026-07-03 14:40:54 -04:00
2026-06-08 18:13:10 -04:00
2026-04-29 22:03:27 -04:00
2026-04-29 20:24:25 -04:00
2026-05-15 00:36:41 -04:00
2026-05-15 00:36:41 -04:00
2026-07-03 23:47:06 -04:00
2026-04-28 12:26:39 -04:00
2026-08-13 16:21:10 -04:00
2026-07-21 18:00:49 -04:00
2026-08-13 16:21:10 -04:00
2026-08-13 16:21:10 -04:00
2026-07-03 15:31:17 -04:00
2026-08-12 15:50:41 -04:00
2026-07-21 15:21:57 -04:00
2026-08-02 04:54:31 +00:00
2026-07-31 14:43:40 +00:00
2026-07-31 04:26:55 +00:00
2026-08-02 04:54:31 +00:00
2026-08-02 04:54:31 +00:00
2026-07-31 17:28:05 +00:00
2026-08-02 04:54:31 +00:00
2026-07-08 16:47:34 -04:00
2026-05-16 10:15:59 -04:00
2026-07-30 20:15:00 +00:00
2026-05-30 19:57:45 -04:00
2026-05-27 13:21:57 -04:00
2026-07-21 09:43:05 -04:00
2026-08-17 03:42:08 -04:00
2026-07-13 22:46:55 -04:00
2026-08-17 03:42:08 -04:00
2026-05-21 16:59:57 -04:00
2026-05-21 16:59:57 -04:00
2026-05-02 22:56:10 -04:00
2026-05-02 22:56:10 -04:00
2026-08-16 12:33:12 -04:00
2026-06-24 22:45:32 -04:00
2026-08-16 12:33:12 -04:00
2026-05-05 08:52:05 -04:00
2026-05-05 08:52:05 -04:00
2026-07-04 14:39:33 -04:00
2026-07-04 14:39:33 -04:00
2026-05-18 00:43:46 -04:00
2026-05-18 00:43:46 -04:00
2026-05-02 13:33:53 -04:00
2026-07-04 11:33:18 -04:00
2026-08-16 18:25:23 -04:00
2026-08-16 18:25:23 -04:00
2026-05-21 13:08:02 -04:00
2026-07-08 15:28:21 -04:00
2026-07-08 15:28:21 -04:00
2026-07-03 22:29:40 -04:00
2026-07-03 22:29:40 -04:00
2026-08-17 01:59:02 -04:00
2026-08-17 01:59:02 -04:00
2026-04-28 12:26:39 -04:00
2026-07-03 15:31:17 -04:00
2026-07-30 12:20:38 +00:00
2026-05-29 08:24:05 -04:00
2026-05-29 17:47:25 -04:00
2026-04-28 12:26:39 -04:00
2026-07-14 20:37:03 -04:00
2026-08-17 01:59:02 -04:00
2026-08-14 17:16:07 -04:00
2026-07-10 23:48:59 -04:00
2026-07-13 22:46:55 -04:00
2026-07-30 12:20:38 +00:00
2026-05-02 21:31:48 -04:00
2026-06-27 21:42:52 -05:00
2026-08-02 01:50:34 +00:00
2026-04-29 17:44:12 -04:00
2026-08-02 01:50:34 +00:00
2026-05-29 23:43:02 -04:00
2026-06-01 21:25:42 -04:00
2026-06-27 21:42:52 -05:00
2026-07-14 23:24:55 -04:00
2026-07-13 22:46:55 -04:00
2026-04-21 22:53:27 -04:00
2026-04-28 12:26:39 -04:00
2026-07-04 03:32:48 -04:00
2026-04-28 12:26:39 -04:00
2026-05-16 10:15:59 -04:00
2026-07-13 22:46:55 -04:00
2026-07-13 22:46:55 -04:00
2026-08-12 15:50:41 -04:00
2026-08-14 17:16:10 -04:00
2026-08-17 01:59:02 -04:00
2026-08-17 01:59:02 -04:00
2026-08-14 17:16:10 -04:00
2026-08-17 01:59:02 -04:00
2026-08-12 15:50:41 -04:00
2026-08-12 15:50:41 -04:00
2026-07-14 23:24:55 -04:00
2026-07-26 23:56:34 +00:00
2026-07-14 23:24:55 -04:00
2026-06-24 22:28:34 -04:00
2026-05-02 18:36:55 -04:00
2026-05-25 11:46:41 -04:00
2026-07-06 10:07:34 -04:00
2026-07-14 20:37:03 -04:00
2026-07-07 16:51:48 -04:00
2026-07-30 12:20:38 +00:00
2026-07-30 12:20:38 +00:00
2026-07-03 10:15:49 -04:00
2026-07-03 12:17:03 -04:00
2026-05-27 10:09:30 -04:00
2026-05-07 20:01:34 -04:00
2026-08-15 19:18:55 -04:00
2026-07-04 11:33:18 -04:00
2026-07-04 11:33:18 -04:00
2026-05-06 08:40:11 -04:00
2026-05-06 08:40:11 -04:00
2026-05-14 15:45:51 -04:00
2026-05-03 17:40:18 -04:00
2026-05-18 00:03:20 -04:00
2026-05-18 00:03:20 -04:00
2026-05-03 17:40:18 -04:00
2026-05-03 17:40:18 -04:00
2026-05-03 17:40:18 -04:00
2026-04-28 12:26:39 -04:00
2026-04-28 12:26:39 -04:00
2026-07-11 14:30:32 -04:00
2026-07-10 23:48:59 -04:00
2026-04-25 11:35:19 -04:00
2026-04-21 19:33:47 -04:00
2026-04-25 11:35:19 -04:00
2026-04-21 23:59:54 -04:00
2026-04-28 12:26:39 -04:00
2026-07-10 23:32:22 -04:00
2026-07-04 02:06:58 -04:00
2026-07-04 02:06:58 -04:00
2026-05-09 18:19:33 -04:00
2026-07-08 11:58:41 -04:00
2026-08-17 01:33:18 -04:00
2026-08-17 04:21:32 -04:00
2026-04-22 12:21:34 -04:00
2026-04-22 12:21:34 -04:00
2026-08-15 08:22:09 -04:00
2026-07-08 11:49:01 -04:00
2026-08-15 09:33:29 -04:00
2026-08-17 01:59:02 -04:00
2026-08-17 01:59:02 -04:00
2026-08-17 01:59:02 -04:00
2026-08-17 01:59:02 -04:00
2026-08-17 05:19:25 -04:00
2026-04-29 14:35:49 -04:00
2026-04-29 14:35:49 -04:00
2026-07-08 11:58:41 -04:00
2026-07-08 11:58:41 -04:00
2026-05-02 13:33:53 -04:00
2026-07-14 20:37:03 -04:00
2026-07-14 20:37:03 -04:00
2026-04-08 20:30:39 +00:00
2026-04-10 23:12:59 +00:00
2026-07-05 22:23:12 -04:00
2026-07-08 11:58:41 -04:00