pad/internal/server/handlers_attachments_transform.go

package server

import (
	"bytes"
	"encoding/json"
	"errors"
	"fmt"
	"image"
	"net/http"

	"github.com/go-chi/chi/v5"

	"github.com/PerpetualSoftware/pad/internal/attachments"
	"github.com/PerpetualSoftware/pad/internal/models"
	"github.com/PerpetualSoftware/pad/internal/store"
)

// transformRequest is the body shape for POST /transform. Operation
// is the discriminator; the per-operation params live in their own
// fields so callers don't have to wrap them in a generic args map.
//
// Adding a new operation = adding a new case in the dispatch below
// + a new param field here. Keeps the wire format tight and the
// handler boring.
type transformRequest struct {
	Operation string `json:"operation"`

	// rotate
	Degrees int `json:"degrees,omitempty"`

	// crop (TASK-880 will populate this; defined here so the wire
	// format is stable across the two PRs).
	Rect *transformRect `json:"rect,omitempty"`
}

// transformRect is the crop rectangle in original-image pixel space.
// Origin top-left, x/y/w/h are integers — preview-pixel-to-original
// conversion is the editor's responsibility, so server-side math
// stays in canonical coordinates.
type transformRect struct {
	X int `json:"x"`
	Y int `json:"y"`
	W int `json:"w"`
	H int `json:"h"`
}

// transformResponse is the success payload — same shape as the
// upload response so the editor can swap the node's UUID and any
// width/height attrs in one go without a follow-up GET.
type transformResponse struct {
	ID       string `json:"id"`
	URL      string `json:"url"`
	Mime     string `json:"mime"`
	Size     int64  `json:"size"`
	Width    *int   `json:"width,omitempty"`
	Height   *int   `json:"height,omitempty"`
	Filename string `json:"filename"`
}

// handleTransformAttachment implements POST
// /api/v1/workspaces/{slug}/attachments/{attachmentID}/transform.
//
// Phase 1 supports two operations: "rotate" (TASK-879) and "crop"
// (TASK-880). Both follow the same flow:
//
//  1. Reject if attachment storage or the image processor isn't wired
//     (a libvips build that hasn't shipped Phase 2 yet, or a self-host
//     that opted out). These are build/config facts, so they answer
//     ahead of everything data-dependent — see the note at the checks.
//  2. Load the parent attachment row (cross-workspace = 404).
//  3. Auth: item visibility, then grant-aware edit permission on the
//     parent item — see the authorization note below.
//  4. Decode the original — defends against unsupported MIMEs and
//     oversized inputs via the processor's Decode rules.
//  5. Apply the operation. Each op validates its own params.
//  6. Encode in the policy format (PNG → PNG to preserve alpha,
//     everything else → JPEG q=85). Same policy as thumbnails so
//     transformed and thumbnail blobs deduplicate cleanly.
//  7. Hash + Put through the storage backend (content-addressed,
//     so identical transforms collapse onto the same blob).
//  8. Insert a NEW attachments row owned by the same workspace /
//     uploaded_by / item as the parent. The original is left in
//     place, and whether it is ever reclaimed depends on the branch.
//     The orphan GC selects rows that are soft-deleted OR have
//     item_id IS NULL past the grace period (store.OrphanedAttachments):
//     an ORPHAN original stays GC-eligible, but an ITEM-BOUND one does
//     not — the editor swapping its node's UUID does not touch that
//     row, which remains live and item-bound, so the pre-rotate blob
//     survives until someone deletes it explicitly. Pre-existing
//     (TASK-886 era) and unchanged here; recorded because the comment
//     used to claim GC reclaimed it unconditionally.
//  9. Return the new row's ID/URL/dimensions so the editor can
//     update its node attrs without a follow-up GET.
//
// Authorization (PLAN-2391 DR-10/DR-14). The handler used to open with a
// flat requireMinRole("editor") and never look at the attachment's parent
// item at all, so a member whose collection access excluded that item could
// transform its attachment given only the attachment id — reading the source
// blob and getting back output metadata for an item they cannot see. The
// order now mirrors the blob read path exactly:
//
//	load the attachment -> workspace identity -> load the parent item ->
//	parent workspace identity -> item visibility -> edit permission
//
// Every denial in that chain goes through writeAttachmentNotFound, so
// "no such attachment", "foreign parent", "archived parent" and "parent not
// visible to you" are byte-identical; a distinguishable code or message
// would be an existence oracle.
//
// Edit permission is requireEditPermission, not the flat editor role: an
// item- or collection-grant editor can already ATTACH to the item
// (BUG-1661, handleUploadAttachment), so refusing them a rotate on what
// they uploaded would be an inconsistency, not a boundary. Orphan rows carry
// no item context to authorize against, so they keep the flat editor gate
// AND — matching the DELETE path — require unrestricted workspace access:
// a restricted member cannot see orphans in the storage listing, so they
// must not be able to transform one either.
//
// The parent item is loaded with GetItem, not GetItemIncludeDeleted, so an
// archived parent 404s here the same way it does on the read path (DR-13).
// That check is point-in-time; the enforcement that actually holds is the
// item lock CreateAttachmentForLiveItem takes around the insert (DR-14).
func (s *Server) handleTransformAttachment(w http.ResponseWriter, r *http.Request) {
	if s.attachments == nil {
		writeError(w, http.StatusServiceUnavailable, "attachments_disabled",
			"Attachment storage is not configured on this server")
		return
	}
	// The two 503s stay ahead of the authorization chain even though the
	// role gate no longer precedes them. They describe the server BUILD, not
	// this workspace's data: the answer is the same for every caller and
	// every attachment id, so they distinguish nothing an authorized-vs-not
	// caller could learn. Everything below this point is data-dependent and
	// is ordered accordingly.
	if s.imageProcessor == nil {
		writeError(w, http.StatusServiceUnavailable, "image_processor_disabled",
			"Image transformation is not available on this build (the libvips backend has not shipped yet)")
		return
	}
	workspaceID, ok := s.getWorkspaceID(w, r)
	if !ok {
		return
	}

	id := chi.URLParam(r, "attachmentID")
	if id == "" {
		writeError(w, http.StatusBadRequest, "bad_request", "Missing attachment id")
		return
	}

	parent, err := s.store.GetAttachment(id)
	if err != nil {
		writeInternalError(w, err)
		return
	}
	// 404 — same cross-workspace defense as the GET handler. Leaking
	// 403 vs 404 here would let a member of workspace B enumerate
	// attachment IDs in workspace A.
	if parent == nil || parent.WorkspaceID != workspaceID || parent.DeletedAt != nil {
		writeAttachmentNotFound(w)
		return
	}

	// Item-level authorization, before the source blob is read and before
	// any work is done. See the ordering note on the handler.
	// includeArchived=false (DR-13): an archived parent reports Gone and the
	// transform is refused. Foreign and dangling item_ids are refused by the
	// same switch — the helper separates those outcomes, this handler
	// deliberately collapses them into one response.
	item, parentOutcome, err := s.resolveAttachmentParentItem(parent, false)
	if err != nil {
		writeInternalError(w, err)
		return
	}
	switch parentOutcome {
	case attachmentParentOK:
		// checkItemVisible (the predicate), not requireItemVisible — the
		// latter writes its own "Item not found" body, which would make a
		// visibility denial distinguishable from a lookup miss.
		visible, vErr := s.checkItemVisible(workspaceID, item, currentUser(r), workspaceRole(r), isBearerAuth(r))
		if vErr != nil {
			writeInternalError(w, vErr)
			return
		}
		if !visible {
			writeAttachmentNotFound(w)
			return
		}
		// Only now the permission check. A 403 past this point is safe:
		// the caller can already see the item and read its attachment's
		// bytes, so refusing the WRITE reveals nothing about existence.
		if !s.requireEditPermission(w, r, workspaceID, item.ID, item.CollectionID) {
			return
		}
	case attachmentParentOrphan:
		// Orphan rows keep the flat workspace editor gate — no item to
		// authorize against. The viewer predicate runs first, and denies
		// with the shared 404: the row has already been loaded here, so a
		// 403 to a caller who cannot even READ an orphan would confirm
		// that this id names a live orphan in this workspace while a bad
		// id answers 404. A viewer, who can read orphans, gets the honest
		// 403 from the editor gate below.
		if !requireRole(r, "viewer") {
			writeAttachmentNotFound(w)
			return
		}
		// ...and, like the read and DELETE paths (PLAN-2382 DR-4),
		// full-access only. See attachmentCallerIsRestricted for why.
		// Ahead of the editor gate so a restricted caller never gets the
		// 403 that would confirm the row exists.
		restricted, rErr := s.attachmentCallerIsRestricted(r, workspaceID)
		if rErr != nil {
			writeInternalError(w, rErr)
			return
		}
		if restricted {
			writeAttachmentNotFound(w)
			return
		}
		if !requireMinRole(w, r, "editor") {
			return
		}
	default: // Gone, Foreign
		writeAttachmentNotFound(w)
		return
	}

	var req transformRequest
	if err := json.NewDecoder(r.Body).Decode(&req); err != nil {
		writeError(w, http.StatusBadRequest, "bad_request", "Invalid JSON body")
		return
	}

	// Open the original blob through the registry. Defer Close so
	// every error path below releases the file handle / network
	// connection.
	srcStore, err := s.attachments.Resolve(parent.StorageKey)
	if err != nil {
		writeInternalError(w, fmt.Errorf("resolve source backend: %w", err))
		return
	}
	body, err := srcStore.Get(r.Context(), parent.StorageKey)
	if err != nil {
		writeInternalError(w, fmt.Errorf("read source blob: %w", err))
		return
	}
	defer body.Close()

	srcImg, srcFormat, err := s.imageProcessor.Decode(body)
	if err != nil {
		switch {
		case errors.Is(err, attachments.ErrUnsupportedFormat):
			// Per spec: editor surfaces this as an inline tooltip.
			// 415 is the canonical "media type not supported" code.
			writeError(w, http.StatusUnsupportedMediaType, "unsupported_format",
				"Image transformation isn't available for "+parent.MimeType+" on this build")
		case errors.Is(err, attachments.ErrImageTooLarge):
			writeError(w, http.StatusRequestEntityTooLarge, "image_too_large",
				"Image dimensions exceed the processor's safe-decode limit")
		default:
			writeInternalError(w, fmt.Errorf("decode source: %w", err))
		}
		return
	}

	transformed, opErr := applyImageTransform(s.imageProcessor, srcImg, &req)
	if opErr != nil {
		writeError(w, http.StatusBadRequest, "bad_transform", opErr.Error())
		return
	}

	outFormat := attachments.ThumbnailFormat(srcFormat)
	var buf bytes.Buffer
	if err := s.imageProcessor.Encode(transformed, outFormat, &buf); err != nil {
		writeInternalError(w, fmt.Errorf("encode transformed image: %w", err))
		return
	}
	hash := sha256Hex(buf.Bytes())

	dstStore, err := s.attachments.Resolve(attachments.FSPrefix + ":" + hash)
	if err != nil {
		writeInternalError(w, fmt.Errorf("resolve destination backend: %w", err))
		return
	}
	// Same orphan-GC fence as the upload handler — see the comment
	// at handlers_attachments.go's store.Put callsite. Released
	// after CreateAttachment below regardless of outcome.
	releaseInFlight := s.markUploadInFlight(hash)
	defer releaseInFlight()
	storageKey, err := dstStore.Put(r.Context(), hash, attachments.ThumbnailMime(outFormat), bytes.NewReader(buf.Bytes()))
	if err != nil {
		writeInternalError(w, fmt.Errorf("put transformed blob: %w", err))
		return
	}

	bounds := transformed.Bounds()
	tw := bounds.Dx()
	th := bounds.Dy()

	// Inherit attribution + item linkage from the parent. The new
	// row is a peer (NOT a derived/variant row — that's only for
	// thumbnails) so ParentID and Variant stay nil; the editor swaps
	// its reference and — if the parent was an ORPHAN — the original
	// ages into orphan GC. An item-bound original does not: see step 8
	// on the handler.
	//
	// UploadedBy inherits from the parent — same policy as the
	// thumbnail pipeline. A user who rotates someone else's upload
	// shouldn't inadvertently take ownership of the resulting blob;
	// audit attribution stays anchored to whoever first put the
	// bytes into the workspace. (The transform itself is auditable
	// at the request layer if/when we add a transform-events log.)
	row := &models.Attachment{
		WorkspaceID: parent.WorkspaceID,
		ItemID:      parent.ItemID,
		UploadedBy:  parent.UploadedBy,
		StorageKey:  storageKey,
		ContentHash: hash,
		MimeType:    attachments.ThumbnailMime(outFormat),
		SizeBytes:   int64(buf.Len()),
		Filename:    transformedFilename(parent.Filename, req.Operation, outFormat),
		Width:       &tw,
		Height:      &th,
	}
	// CreateAttachmentForLiveItem, not CreateAttachment (PLAN-2391 DR-14).
	// The parent-item check above is point-in-time: item deletion commits in
	// its own transaction, and everything between that check and here — the
	// blob read, decode, transform, encode, Put — is unbounded work, so the
	// item can be archived mid-flight. The store re-checks the parent under
	// a row lock inside the insert's transaction, so the row is either
	// written against a live item or not written at all. Transform is
	// user-initiated and low volume; the lock is affordable and the window
	// is not accepted here (thumbnail derivation, TASK-2404, makes the
	// opposite trade).
	//
	// The refusal is the shared 404: the blob it would have produced is
	// unreadable under DR-13 anyway, and the caller must not be able to
	// tell "your item was archived just now" from "no such attachment".
	//
	// The already-written blob is left on disk. It carries no row, so no
	// quota is charged for it (usage is derived from live rows) — but note
	// that the orphan GC walks attachment ROWS, so a rowless blob is not
	// reclaimed by it either. That is the pre-existing shape of every
	// Put-then-insert failure window in this codebase (upload and thumbnail
	// derivation have the same one); this refusal makes it reachable on one
	// more, rare path rather than introducing it. Deleting the blob here
	// would be wrong without the GC's dedupe guard: the same content hash
	// may already back another live row.
	if err := s.store.CreateAttachmentForLiveItem(row); err != nil {
		if errors.Is(err, store.ErrAttachmentParentItemGone) {
			writeAttachmentNotFound(w)
			return
		}
		writeInternalError(w, fmt.Errorf("create transformed row: %w", err))
		return
	}

	// Drop the storage-usage cache so the Settings → Storage UI sees
	// the new attachment bytes on the next read. Same rationale as
	// the upload path.
	s.storageInfoCache.invalidate(workspaceID)

	// Quota tracking — observational only in Phase 1, same as upload.
	s.goAsync(func() { s.maybeWarnStorageQuota(workspaceID) })

	writeJSON(w, http.StatusCreated, transformResponse{
		ID:       row.ID,
		URL:      attachmentURL(chi.URLParam(r, "slug"), row.ID),
		Mime:     row.MimeType,
		Size:     row.SizeBytes,
		Width:    row.Width,
		Height:   row.Height,
		Filename: row.Filename,
	})
}

// applyImageTransform dispatches on the operation discriminator.
// Each branch validates its own params and returns a clear error
// — the handler turns those into 400 Bad Request without leaking
// internal detail. New ops slot in here.
func applyImageTransform(p attachments.Processor, src image.Image, req *transformRequest) (image.Image, error) {
	switch req.Operation {
	case "rotate":
		// Validate degrees up-front so we can return a clean 400
		// instead of leaking the processor's "only multiples of 90"
		// internal-error message. The set is intentionally narrow:
		// 90 / 180 / 270 are pixel-exact reorders (no resampling),
		// and 0 is a no-op the editor shouldn't be sending.
		switch req.Degrees {
		case 90, 180, 270:
			return p.Rotate(src, req.Degrees)
		default:
			return nil, fmt.Errorf("rotate: degrees must be 90, 180, or 270 (got %d)", req.Degrees)
		}
	case "crop":
		if req.Rect == nil {
			return nil, fmt.Errorf("crop: rect is required")
		}
		if req.Rect.W <= 0 || req.Rect.H <= 0 {
			return nil, fmt.Errorf("crop: rect width/height must be positive")
		}
		if req.Rect.X < 0 || req.Rect.Y < 0 {
			return nil, fmt.Errorf("crop: rect x/y must be non-negative")
		}
		// Processor.Crop intersects with the image bounds itself, so
		// we don't need to clip here. The processor returns an error
		// only for empty intersections (rect entirely outside the
		// image) — bubble that up as a 400.
		return p.Crop(src, image.Rect(req.Rect.X, req.Rect.Y, req.Rect.X+req.Rect.W, req.Rect.Y+req.Rect.H))
	default:
		return nil, fmt.Errorf("operation must be one of: rotate, crop (got %q)", req.Operation)
	}
}

// transformedFilename builds the synthetic filename for the derived
// row. We append the operation tag (e.g. ".rotated", ".cropped")
// before the extension so a user downloading the file directly sees
// what happened to it. Matches the shape thumbnailFilename emits.
func transformedFilename(parent, op, format string) string {
	ext := attachments.ThumbnailExt(format)
	base := parent
	// Strip any existing extension so we don't end up with
	// "shot.png.rotated.png" round-trip cruft.
	for i := len(base) - 1; i >= 0; i-- {
		if base[i] == '.' {
			base = base[:i]
			break
		}
	}
	if base == "" {
		base = "attachment"
	}
	return base + "." + op + ext
}