xarmian
9b9e2eb26b
fix(admin): stop leaking 2FA secret via GET /admin/settings (BUG-1909) ( #779 )
...
platform_settings holds admin-managed UI keys alongside server secrets
(2fa_challenge_secret — the 2FA challenge HMAC signing key) and
plan_limits_* rows. handleGetPlatformSettings returned the whole table,
so any admin client received the 2FA signing secret (and limit rows) in
plaintext — a read-side secret exposure (not corruptible; the key isn't
in the write whitelist, but it was fully exposed).
Adopt deny-by-default: introduce adminManagedSettings, the canonical
allowlist of the 8 admin-editable keys, and share it across read and
write so they can't drift. GET now projects only those keys (masking
maileroo_api_key); anything else in platform_settings — the 2FA secret,
plan-limit rows, any future internal secret — is never exposed. PATCH
gates writes on the same set.
Tests: SecretsNotExposed (2fa_challenge_secret and plan_limits_* absent
from GET, raw-body substring check, only allowlisted keys returned) and
SecretNotWritable (PATCH can't overwrite the 2FA secret or write limit
rows). A codebase-wide secret-exposure audit found no other confirmed
leak surfaces.
Claude-Session: https://claude.ai/code/session_01HxBkAMiFBtCRJ2tKSCt3ST
2026-07-01 17:44:43 -04:00
..
2026-04-29 15:41:12 -04:00
2026-06-22 11:43:52 -04:00
2026-05-06 08:40:11 -04:00
2026-05-06 13:27:12 -04:00
2026-06-15 14:44:58 -04:00
2026-05-18 00:43:46 -04:00
2026-05-18 00:43:46 -04:00
2026-04-28 12:26:39 -04:00
2026-05-02 22:56:10 -04:00
2026-04-25 11:35:19 -04:00
2026-04-25 11:35:19 -04:00
2026-04-28 12:26:39 -04:00
2026-04-28 12:26:39 -04:00
2026-04-28 12:26:39 -04:00
2026-06-29 13:07:36 -05:00
2026-05-27 10:09:30 -04:00
2026-04-28 12:26:39 -04:00
2026-04-28 12:26:39 -04:00
2026-04-28 16:21:43 -04:00
2026-07-01 17:44:43 -04:00
2026-04-29 17:56:19 -04:00
2026-06-22 20:58:50 -04:00
2026-07-01 17:44:43 -04:00
2026-04-28 12:26:39 -04:00
2026-06-27 21:42:52 -05:00
2026-06-22 13:31:45 -04:00
2026-06-22 13:31:45 -04:00
2026-04-29 15:41:12 -04:00
2026-05-31 11:39:02 -04:00
2026-04-29 14:35:49 -04:00
2026-04-29 19:25:55 -04:00
2026-04-29 15:02:07 -04:00
2026-04-29 19:25:55 -04:00
2026-05-31 11:39:02 -04:00
2026-04-28 12:26:39 -04:00
2026-05-06 13:27:12 -04:00
2026-05-06 08:40:11 -04:00
2026-06-22 20:58:50 -04:00
2026-04-21 19:33:47 -04:00
2026-04-21 20:52:03 -04:00
2026-04-22 12:21:34 -04:00
2026-06-21 00:34:25 -04:00
2026-06-24 22:28:34 -04:00
2026-05-27 10:37:30 -04:00
2026-06-27 21:42:52 -05:00
2026-05-21 13:08:02 -04:00
2026-06-21 12:25:46 -04:00
2026-04-29 14:35:49 -04:00
2026-04-25 11:53:31 -04:00
2026-05-18 15:25:27 -04:00
2026-05-18 10:25:08 -04:00
2026-04-22 09:27:45 -04:00
2026-06-20 23:51:43 -04:00
2026-06-07 22:08:14 -04:00
2026-05-09 21:45:46 -04:00
2026-05-27 10:09:30 -04:00
2026-05-16 10:15:59 -04:00
2026-05-30 12:38:57 -04:00
2026-06-27 21:42:52 -05:00
2026-05-18 08:33:39 -04:00
2026-05-18 03:32:42 -04:00
2026-05-18 08:33:39 -04:00
2026-05-21 13:08:02 -04:00
2026-05-17 13:40:15 -04:00
2026-06-29 13:07:36 -05:00
2026-05-14 22:10:12 -04:00
2026-05-20 16:39:23 -04:00
2026-05-30 18:41:55 -04:00
2026-04-28 12:26:39 -04:00
2026-05-18 18:29:28 -04:00
2026-05-30 18:41:55 -04:00
2026-04-29 18:30:43 -04:00
2026-04-29 18:30:43 -04:00
2026-06-27 21:42:52 -05:00
2026-06-08 18:13:10 -04:00
2026-06-08 18:13:10 -04:00
2026-04-29 22:03:27 -04:00
2026-04-29 20:24:25 -04:00
2026-05-15 00:36:41 -04:00
2026-05-15 00:36:41 -04:00
2026-04-28 12:26:39 -04:00
2026-06-27 21:42:52 -05:00
2026-06-27 21:42:52 -05:00
2026-05-30 22:28:34 -04:00
2026-05-30 22:28:34 -04:00
2026-05-09 21:45:46 -04:00
2026-05-16 10:15:59 -04:00
2026-05-30 19:57:45 -04:00
2026-05-27 13:21:57 -04:00
2026-05-17 00:15:52 -04:00
2026-06-06 11:14:23 -04:00
2026-06-27 21:42:52 -05:00
2026-05-21 16:59:57 -04:00
2026-05-21 16:59:57 -04:00
2026-05-02 22:56:10 -04:00
2026-05-02 22:56:10 -04:00
2026-05-14 15:45:51 -04:00
2026-06-24 22:45:32 -04:00
2026-06-24 22:45:32 -04:00
2026-05-05 08:52:05 -04:00
2026-05-05 08:52:05 -04:00
2026-04-28 16:21:43 -04:00
2026-05-18 00:43:46 -04:00
2026-05-18 00:43:46 -04:00
2026-05-02 13:33:53 -04:00
2026-06-07 22:08:14 -04:00
2026-05-18 17:17:42 -04:00
2026-05-18 07:51:12 -04:00
2026-05-21 13:08:02 -04:00
2026-05-12 18:29:11 -04:00
2026-05-12 18:29:11 -04:00
2026-04-28 12:26:39 -04:00
2026-05-31 12:26:57 -04:00
2026-05-31 12:26:57 -04:00
2026-05-29 08:24:05 -04:00
2026-05-29 17:47:25 -04:00
2026-04-28 12:26:39 -04:00
2026-04-28 12:26:39 -04:00
2026-06-02 09:39:22 -04:00
2026-06-27 21:42:52 -05:00
2026-05-02 21:31:48 -04:00
2026-06-27 21:42:52 -05:00
2026-04-29 17:44:12 -04:00
2026-04-30 16:06:08 -04:00
2026-05-29 23:43:02 -04:00
2026-06-01 21:25:42 -04:00
2026-06-27 21:42:52 -05:00
2026-04-28 12:26:39 -04:00
2026-04-21 22:53:27 -04:00
2026-04-28 12:26:39 -04:00
2026-04-28 12:26:39 -04:00
2026-05-16 10:15:59 -04:00
2026-05-16 10:15:59 -04:00
2026-04-28 12:26:39 -04:00
2026-06-24 22:28:34 -04:00
2026-05-02 18:36:55 -04:00
2026-05-25 11:46:41 -04:00
2026-05-03 00:35:31 -04:00
2026-05-31 12:26:57 -04:00
2026-04-28 12:26:39 -04:00
2026-05-12 10:01:14 -04:00
2026-04-28 16:21:43 -04:00
2026-05-27 10:09:30 -04:00
2026-05-07 20:01:34 -04:00
2026-06-14 21:15:35 -04:00
2026-04-22 12:21:34 -04:00
2026-05-01 11:51:28 -04:00
2026-05-06 08:40:11 -04:00
2026-05-06 08:40:11 -04:00
2026-05-14 15:45:51 -04:00
2026-05-03 17:40:18 -04:00
2026-05-18 00:03:20 -04:00
2026-05-18 00:03:20 -04:00
2026-05-03 17:40:18 -04:00
2026-05-03 17:40:18 -04:00
2026-05-03 17:40:18 -04:00
2026-04-28 12:26:39 -04:00
2026-04-28 12:26:39 -04:00
2026-04-05 10:26:00 -04:00
2026-06-22 20:58:50 -04:00
2026-04-25 11:35:19 -04:00
2026-04-21 19:33:47 -04:00
2026-04-25 11:35:19 -04:00
2026-04-21 23:59:54 -04:00
2026-04-28 12:26:39 -04:00
2026-05-09 18:19:33 -04:00
2026-05-09 18:19:33 -04:00
2026-05-30 10:57:31 -04:00
2026-05-30 10:57:31 -04:00
2026-04-22 12:21:34 -04:00
2026-04-22 12:21:34 -04:00
2026-04-28 17:20:03 -04:00
2026-07-01 17:27:00 -04:00
2026-05-09 07:13:10 -04:00
2026-04-29 14:35:49 -04:00
2026-04-29 14:35:49 -04:00
2026-05-02 13:33:53 -04:00
2026-05-02 14:29:17 -04:00
2026-04-08 20:30:39 +00:00
2026-04-10 23:12:59 +00:00