PLAN-1496's final consolidation pair, shipping together because both
are small cleanup passes that close the plan out.
TASK-1507 (tests):
Most of the test coverage required by this task was already
added incrementally in the prior PRs that built each surface:
- Blank template (4 focused tests, PR #575):
TestSeedFromBlankTemplate, TestBlankTemplateShape,
TestBlankTemplateExcludesSoftwareCollections,
TestBlankTemplateUsesMinimalVocabularies,
TestBlankTemplateAppearsInPicker
- Onboard auto-seed (PR #576):
TestSeedFromTemplateAlwaysIncludesOnboardPlaybook (walks all six
templates), TestSeedWithEmptyTemplateNameSkipsOnboard (locks the
empty-templateName escape-hatch invariant), TestOnboardPlaybook_Contract
(invocation_slug, trigger, mode-enum, ADAPT-DON'T-CURATE rule in
the body)
- needs_onboarding (PR #578):
TestBootstrapNeedsOnboardingFlag (lifecycle: fresh → user item →
flag flips), TestBootstrapNeedsOnboardingIgnoresTemplateSeeds
(template seeds don't count)
- Retired-pattern updates (PR #577): TestSoftwareTemplatesShipNoSeedItems
inverse invariant; TestDashboardOnboardingSeed_NilForAllTemplates
collapsed from three IDEA-1/BACK-1/FEAT-1 tests.
This commit adds ONE integration smoke test that ties the three
subsystems together at the bootstrap layer:
- TestBootstrapBlankWorkspaceOnboardReady creates a blank-template
workspace, fetches bootstrap, and asserts: needs_onboarding=true
(nudge fires) AND the onboard playbook is in bootstrap.playbooks
AND its status is "active" AND its trigger is "manual" (in the
blank template's seeded vocabulary). If any one of the three
pieces regresses silently, the integration breaks and this test
catches it before /pad onboard stops dispatching on day one.
TASK-1508 (docs):
- CLAUDE.md "Data Model / Templates" section: added Blank under a
new "Custom" category bullet pointing at the new Onboarding
section; called out the PLAN-1496 retirement of the IDEA-1 /
BACK-1 / FEAT-1 first-person seed pattern; updated design
history reference to include PLAN-1496.
- CLAUDE.md "API" section: added the
/api/v1/workspaces/{ws}/agent/bootstrap endpoint with a note
about the needs_onboarding flag (was previously documented only
inline in the Playbooks section).
- CLAUDE.md: new top-level "Onboarding" section between Playbooks
and Testing. Covers: auto-seeded everywhere, surface-agnostic
body, adaptation posture (library entries are starting points),
the three TASK-1510/1511/1512 mutation primitives, the
needs_onboarding bootstrap flag + skill nudge, the four retired
surfaces (pad onboard cobra, OnboardingPrimaryRef,
*OnboardingItems generators, standalone skill workflow section),
and a code map.
Verification:
- go test ./...: clean (full suite passes including the new
integration test)
- make lint: 0 issues
Parent: PLAN-1496.
xarmian
2a1a00e385