mirror of
https://github.com/n0-computer/noq.git
synced 2026-09-16 16:25:08 +00:00
a0f988a91d
## Description Remove Chunk usage in ordered read API Make read_chunk return just a Bytes. Also rename read_chunks to read_chunks_many (it already returns Bytes). Add a bytes_read fn for the rare case where you do need the offset despite being in ordered read mode. Not sure if people agree, but there was an inconsistency before between read_chunk (returns a Chunk, including offset) and read_chunks (fills a bunch of Bytes, no offset). Also it doesn't seem useful to have Chunk at all for ordered streams. You usually don't care about the offset unless you are reading unordered streams. So I would like to confine Chunk usage to only the (now separate) unordered read API. ## Breaking Changes noq::RecvStream::read_chunk returns a Bytes. noq::RecvStream::read_chunks renamed to read_many_chunks. ## Notes & open questions Note: while the [other related PR](https://github.com/n0-computer/noq/pull/536) is just renaming, this one is I think actually removing some weirdness. Why does read_chunk give you an offset but read_chunks does not. And there is no way to get the offset if you need it if you use read_chunks. --------- Co-authored-by: Floris Bruynooghe <flub@n0.computer>