From f6904d6140cf20e5b830820e0f7e4dfd9ed565ff Mon Sep 17 00:00:00 2001 From: Dirkjan Ochtman Date: Thu, 23 Apr 2020 22:21:33 +0200 Subject: [PATCH] Apply suggestions from clippy --- quinn-h3/src/qpack/parse_error.rs | 8 ++------ quinn-proto/src/crypto/ring.rs | 1 - quinn/src/udp.rs | 1 - quinn/tests/many_connections.rs | 6 +----- 4 files changed, 3 insertions(+), 13 deletions(-) diff --git a/quinn-h3/src/qpack/parse_error.rs b/quinn-h3/src/qpack/parse_error.rs index bb57c0caa..57a629b8a 100644 --- a/quinn-h3/src/qpack/parse_error.rs +++ b/quinn-h3/src/qpack/parse_error.rs @@ -10,16 +10,12 @@ pub enum ParseError { impl From for ParseError { fn from(e: prefix_int::Error) -> Self { - match e { - e => ParseError::InvalidInteger(e), - } + ParseError::InvalidInteger(e) } } impl From for ParseError { fn from(e: prefix_string::Error) -> Self { - match e { - e => ParseError::InvalidString(e), - } + ParseError::InvalidString(e) } } diff --git a/quinn-proto/src/crypto/ring.rs b/quinn-proto/src/crypto/ring.rs index dee2e2a69..210ba9f7a 100644 --- a/quinn-proto/src/crypto/ring.rs +++ b/quinn-proto/src/crypto/ring.rs @@ -283,7 +283,6 @@ mod test { MAX_CID_SIZE, }; use hex_literal::hex; - use rand; #[test] fn handshake_crypto_roundtrip() { diff --git a/quinn/src/udp.rs b/quinn/src/udp.rs index d77e29bfd..6c970ad63 100644 --- a/quinn/src/udp.rs +++ b/quinn/src/udp.rs @@ -5,7 +5,6 @@ use std::{ }; use futures::ready; -use mio; use tokio::io::PollEvented; diff --git a/quinn/tests/many_connections.rs b/quinn/tests/many_connections.rs index fb0964ed2..da681f38f 100644 --- a/quinn/tests/many_connections.rs +++ b/quinn/tests/many_connections.rs @@ -76,11 +76,7 @@ fn connect_n_nodes_to_1_and_send_1mb_data() { match e { WriteError::ConnectionClosed(ApplicationClosed { .. }) | WriteError::ConnectionClosed(Reset) => {} - WriteError::ConnectionClosed(e) => match e { - _ => { - shared.lock().unwrap().errors.push(e); - } - }, + WriteError::ConnectionClosed(e) => shared.lock().unwrap().errors.push(e), _ => panic!("unexpected write error"), } });