gsadmin/noq
1
0
Fork 0
mirror of https://github.com/n0-computer/noq.git synced 2026-09-16 16:25:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: remove gro module

Browse Source
This commit is contained in:
Thomas Eizinger
2026-03-16 18:26:47 +11:00
committed by Benjamin Saunders
parent ee8f9469b8
commit 56bba7c0fa
1 changed files with 18 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files
quinn-udp/src/unix.rs
+18 -29
View File
@@ -127,6 +127,12 @@ impl UdpSocketState {
}
let mut may_fragment = false;
#[cfg_attr(
not(any(target_os = "linux", target_os = "android")),
expect(unused_mut)
)]
let mut gro_segments = 1;
#[cfg(any(target_os = "linux", target_os = "android"))]
{
// opportunistically try to enable GRO. See gro::gro_segments().
@@ -152,6 +158,17 @@ impl UdpSocketState {
libc::IPV6_PMTUDISC_PROBE,
)?;
}
if set_socket_option(&*io, libc::SOL_UDP, libc::UDP_GRO, OPTION_ON).is_ok() {
// As defined in net/ipv4/udp_offload.c
// #define UDP_GRO_CNT_MAX 64
//
// NOTE: this MUST be set to UDP_GRO_CNT_MAX to ensure that the receive buffer size
// (get_max_udp_payload_size() * gro_segments()) is large enough to hold the largest GRO
// list the kernel might potentially produce. See
// https://github.com/quinn-rs/quinn/pull/1354.
gro_segments = 64
}
}
#[cfg(any(target_os = "freebsd", apple))]
{
@@ -195,7 +212,7 @@ impl UdpSocketState {
Ok(Self {
last_send_error: Mutex::new(now.checked_sub(2 * IO_ERROR_LOG_INTERVAL).unwrap_or(now)),
max_gso_segments: AtomicUsize::new(gso::max_gso_segments(&*io)),
gro_segments: gro::gro_segments(&*io),
gro_segments,
may_fragment,
sendmsg_einval: AtomicBool::new(false),
#[cfg(apple_fast)]
@@ -1171,25 +1188,6 @@ mod gso {
}
}
#[cfg(any(target_os = "linux", target_os = "android"))]
mod gro {
use super::*;
pub(crate) fn gro_segments(socket: &impl AsRawFd) -> usize {
// As defined in net/ipv4/udp_offload.c
// #define UDP_GRO_CNT_MAX 64
//
// NOTE: this MUST be set to UDP_GRO_CNT_MAX to ensure that the receive buffer size
// (get_max_udp_payload_size() * gro_segments()) is large enough to hold the largest GRO
// list the kernel might potentially produce. See
// https://github.com/quinn-rs/quinn/pull/1354.
match set_socket_option(socket, libc::SOL_UDP, libc::UDP_GRO, OPTION_ON) {
Ok(()) => 64,
Err(_) => 1,
}
}
}
/// Returns whether the given socket option is supported on the current platform
///
/// Yields `Ok(true)` if the option was set successfully, `Ok(false)` if setting
@@ -1231,12 +1229,3 @@ fn set_socket_option(
}
const OPTION_ON: libc::c_int = 1;
#[cfg(not(any(target_os = "linux", target_os = "android")))]
mod gro {
use super::*;
pub(super) fn gro_segments(_socket: &impl AsRawFd) -> usize {
1
}
}