mirror of
https://github.com/suitenumerique/meet.git
synced 2026-10-13 00:11:36 +00:00
leo
d89b01b681
`EGRESS_ABORTED` and `EGRESS_FAILED` events were previously ignored, leaving recordings indefinitely in `ACTIVE` state and potentially blocking subsequent recordings with 409 errors. Add handling and logging for failed and aborted egresses, discarding failed recordings while preserving the existing behavior for savable recordings. Rename `handle_complete` to `handle_savable` to reflect that it handles both `EGRESS_COMPLETE` and `EGRESS_LIMIT_REACHED`. Slight refactor to separate LiveKit event handling from recording concerns as part of a general separation concern to allow for future SFU swapping. NB: - FAILED recordings are currently discarded although exploitable media files may exist - There is a theoretical hole: if stop observes EGRESS_FAILED before the egress_ended webhook is processed, the recording is immediately marked as FAILED. Since only ACTIVE and STOPPED recordings are savable, the webhook then skips the failure notification and LiveKit error log. In that rare race condition, participants may therefore not see the failure toast. We accept this trade-off for now, as this should be very infrequent. - Another theoretical hole: There is a short race window where the user clicks stop while the limit-reached status is being processed. Since the user explicitly requested the stop, we consider skipping the limit notification acceptable and do not handle this case. fix(recording): log aborted worker events at info level