mirror of
https://github.com/suitenumerique/meet.git
synced 2026-09-06 07:29:04 +00:00
kaelvar
63a7751072
The sending resolution selector stopped at 720p while `VideoPresets` already exposes `h1080` (1920x1080), so publishers on a good uplink could not make use of the capacity they had. Add "Very high definition (1080p)" above the existing entries, translated in the five supported locales. The default stays `h720`, so nothing changes unless a user goes and picks the new entry. Being explicit about what that costs, since 1080p roughly doubles a publisher's uplink: this is a per-user choice, and an instance operator has no way today to decline it. Whether that warrants a server-side setting alongside the existing `ApiConfig` flags is a call for maintainers — happy to add one if you want it, rather than change the API contract unasked in a frontend PR. While here, make the option list harder to get wrong. Resolutions now come from a single `VIDEO_RESOLUTIONS` tuple that `VideoResolution` derives from, the selector items are built by mapping over it against a `Record<VideoResolution, string>` of labels — so a resolution cannot be added to one and forgotten in the other — and a persisted value that is not in the tuple falls back to `h720` instead of reaching `VideoPresets[...]` as `undefined`, since `loadUserChoices` spreads localStorage without validating it. Known limitation, unchanged by this patch: `restartTrack` passes the resolution as an `ideal` constraint, so a camera that cannot reach the selected height degrades silently. That is already true of 720p on a 480p webcam; 1080p is the first step where the gap is the common case rather than the edge one.
React + TypeScript + Vite
This template provides a minimal setup to get React working in Vite with HMR and some ESLint rules.
Currently, two official plugins are available:
- @vitejs/plugin-react uses Babel for Fast Refresh
- @vitejs/plugin-react-swc uses SWC for Fast Refresh
Expanding the ESLint configuration
If you are developing a production application, we recommend updating the configuration to enable type aware lint rules:
- Configure the top-level
parserOptionsproperty like this:
export default {
// other rules...
parserOptions: {
ecmaVersion: 'latest',
sourceType: 'module',
project: ['./tsconfig.json', './tsconfig.node.json'],
tsconfigRootDir: __dirname,
},
}
- Replace
plugin:@typescript-eslint/recommendedtoplugin:@typescript-eslint/recommended-type-checkedorplugin:@typescript-eslint/strict-type-checked - Optionally add
plugin:@typescript-eslint/stylistic-type-checked - Install eslint-plugin-react and add
plugin:react/recommended&plugin:react/jsx-runtimeto theextendslist