From eaa3a2a284ddaf685f06c4b9e1f6d90081424333 Mon Sep 17 00:00:00 2001 From: Cyril Date: Tue, 12 May 2026 09:40:13 +0200 Subject: [PATCH] =?UTF-8?q?fixup!=20=E2=99=BB=EF=B8=8F=20decouple=20PiP=20?= =?UTF-8?q?behavior=20from=20shared=20primitives?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../src/features/pip/components/DocumentPiPPortal.tsx | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/src/frontend/src/features/pip/components/DocumentPiPPortal.tsx b/src/frontend/src/features/pip/components/DocumentPiPPortal.tsx index 246ba2a2..9e1fdf68 100644 --- a/src/frontend/src/features/pip/components/DocumentPiPPortal.tsx +++ b/src/frontend/src/features/pip/components/DocumentPiPPortal.tsx @@ -4,7 +4,7 @@ import { useTranslation } from 'react-i18next' import { useDocumentPiP } from '../hooks/useDocumentPiP' import { useScreenReaderAnnounce } from '@/hooks/useScreenReaderAnnounce' import { useRestoreFocus } from '@/hooks/useRestoreFocus' -import { UNSAFE_PortalProvider } from '@react-aria/overlays' +import { UNSAFE_PortalProvider as PortalProvider } from '@react-aria/overlays' import { VisualOnlyTooltipsContext } from '@/primitives/VisualOnlyTooltipsContext' // Minimal base styles so the PiP window renders correctly on first paint. @@ -65,8 +65,7 @@ const syncCssVariables = (source: Document, target: Document) => { const collectVarsFrom = (element: HTMLElement | null) => { if (!element) return const styles = sourceView.getComputedStyle(element) - for (let i = 0; i < styles.length; i += 1) { - const property = styles[i] + for (const property of Array.from(styles)) { if (property.startsWith('--')) { varNames.add(property) } @@ -224,11 +223,11 @@ export const DocumentPiPPortal = ({ const portal = useMemo(() => { if (!container) return null return createPortal( - container}> + container}> {children} - , + , container ) }, [children, container])