From cdc5add2f34fb8f60b97f9b56a747ad0f366ed90 Mon Sep 17 00:00:00 2001 From: Cyril Date: Mon, 11 May 2026 14:02:04 +0200 Subject: [PATCH] =?UTF-8?q?=E2=99=BB=EF=B8=8F(refactor)=20Share=20reaction?= =?UTF-8?q?s=20toggle=20and=20paginated=20toolbar?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Unify main and PiP emoji UI via context; remove PiP-only duplicates. --- CHANGELOG.md | 3 +- .../features/pip/components/PipControlBar.tsx | 10 +- .../pip/components/PipPlaceholder.tsx | 9 +- .../pip/components/PipReactionsToggle.tsx | 34 --- .../pip/components/PipReactionsToolbar.tsx | 69 ------ .../src/features/pip/components/PipView.tsx | 12 +- .../controls/PipOptionsMenuItems.tsx | 3 +- .../components/controls/PipOverflowItems.tsx | 26 +-- .../pip/components/layouts/PipFocusLayout.tsx | 5 +- .../notifications/PipNotificationOverlay.tsx | 9 +- .../reactions/components/ReactionsToggle.tsx | 41 ++-- .../toolbar/ReactionsKeyboardNavigation.tsx} | 40 ++-- .../components/toolbar/ReactionsPill.tsx} | 13 +- .../components/toolbar/ReactionsToolbar.tsx | 198 +++++------------- .../reactions/hooks/useReactionsToolbar.ts | 21 +- .../utils/reactionsPagination.ts} | 0 src/frontend/src/locales/de/rooms.json | 4 +- src/frontend/src/locales/en/rooms.json | 4 +- src/frontend/src/locales/fr/rooms.json | 4 +- src/frontend/src/locales/nl/rooms.json | 4 +- src/frontend/src/primitives/Menu.tsx | 5 +- .../primitives/VisualOnlyTooltipsContext.tsx | 3 +- 22 files changed, 173 insertions(+), 344 deletions(-) delete mode 100644 src/frontend/src/features/pip/components/PipReactionsToggle.tsx delete mode 100644 src/frontend/src/features/pip/components/PipReactionsToolbar.tsx rename src/frontend/src/features/{pip/components/reactions/PipReactionsKeyboardNavigation.tsx => reactions/components/toolbar/ReactionsKeyboardNavigation.tsx} (63%) rename src/frontend/src/features/{pip/components/reactions/PipReactionsPill.tsx => reactions/components/toolbar/ReactionsPill.tsx} (87%) rename src/frontend/src/features/{pip/utils/pipReactionsPagination.ts => reactions/utils/reactionsPagination.ts} (100%) diff --git a/CHANGELOG.md b/CHANGELOG.md index 259b465a..c4fed836 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -14,6 +14,7 @@ and this project adheres to - ✨(helm) add support multiple transcribe worker / endpoint #1247 - ✨(backend) make LiveKit Egress recording encoding configurable #1288 - ✨(summary) add speaker-to-participant assignment +- ✨(feat) Introduce Picture-in-Picture (PiP) #890 ### Changed @@ -235,8 +236,6 @@ and this project adheres to - ✨(backend) monitor throttling rate failure through sentry #964 - 🚀(paas) add PaaS deployment scripts, tested on Scalingo #957 -- ✨(feat) Introduce Picture-in-Picture (PiP) #890 - ### Changed diff --git a/src/frontend/src/features/pip/components/PipControlBar.tsx b/src/frontend/src/features/pip/components/PipControlBar.tsx index 61519b77..018c7e86 100644 --- a/src/frontend/src/features/pip/components/PipControlBar.tsx +++ b/src/frontend/src/features/pip/components/PipControlBar.tsx @@ -11,7 +11,7 @@ import { HandToggle } from '@/features/rooms/livekit/components/controls/HandTog import { StartMediaButton } from '@/features/rooms/livekit/components/controls/StartMediaButton' import { usePipElementSize } from '../hooks/usePipElementSize' import { PipOptionsMenu } from './controls/PipOptionsMenu' -import { PipReactionsToggle } from './PipReactionsToggle' +import { ReactionsToggle } from '@/features/reactions/components/ReactionsToggle' export const CollapsibleControls = { HAND: 'hand', @@ -85,8 +85,12 @@ export const PipControlBar = ({ - {!hidden.has(CollapsibleControls.REACTIONS) && } - {showScreenShare && !hidden.has(CollapsibleControls.SCREEN_SHARE) && } + {!hidden.has(CollapsibleControls.REACTIONS) && ( + + )} + {showScreenShare && !hidden.has(CollapsibleControls.SCREEN_SHARE) && ( + + )} {!hidden.has(CollapsibleControls.HAND) && } diff --git a/src/frontend/src/features/pip/components/PipPlaceholder.tsx b/src/frontend/src/features/pip/components/PipPlaceholder.tsx index 15fe42b6..89688b9c 100644 --- a/src/frontend/src/features/pip/components/PipPlaceholder.tsx +++ b/src/frontend/src/features/pip/components/PipPlaceholder.tsx @@ -1,7 +1,6 @@ import { useTranslation } from 'react-i18next' import { styled } from '@/styled-system/jsx' import { useRoomPiP } from '../hooks/useRoomPiP' -import pipIllustration from '/assets/pip.svg' export const PipPlaceholder = () => { const { t } = useTranslation('rooms', { @@ -11,7 +10,13 @@ export const PipPlaceholder = () => { return ( -