From b8f3c0aa59a8116d367a089531fff9f1a23a6ca4 Mon Sep 17 00:00:00 2001 From: Cyril Date: Thu, 7 May 2026 13:49:11 +0200 Subject: [PATCH] =?UTF-8?q?=E2=99=BB=EF=B8=8F(refactor)=20remove=20PiP=20s?= =?UTF-8?q?ubtitles=20controls=20and=20align=20PiP=20toast=20container?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Drop subtitles actions from PiP controls and reuse main toast container style. --- .../src/features/pip/components/PipControlBar.tsx | 4 ---- .../pip/components/controls/PipOverflowItems.tsx | 13 ------------- 2 files changed, 17 deletions(-) diff --git a/src/frontend/src/features/pip/components/PipControlBar.tsx b/src/frontend/src/features/pip/components/PipControlBar.tsx index 40cdbfc2..61519b77 100644 --- a/src/frontend/src/features/pip/components/PipControlBar.tsx +++ b/src/frontend/src/features/pip/components/PipControlBar.tsx @@ -7,7 +7,6 @@ import { AudioDevicesControl } from '@/features/rooms/livekit/components/control import { VideoDeviceControl } from '@/features/rooms/livekit/components/controls/Device/VideoDeviceControl' import { ScreenShareToggle } from '@/features/rooms/livekit/components/controls/ScreenShareToggle' import { LeaveButton } from '@/features/rooms/livekit/components/controls/LeaveButton' -import { SubtitlesToggle } from '@/features/rooms/livekit/components/controls/SubtitlesToggle' import { HandToggle } from '@/features/rooms/livekit/components/controls/HandToggle' import { StartMediaButton } from '@/features/rooms/livekit/components/controls/StartMediaButton' import { usePipElementSize } from '../hooks/usePipElementSize' @@ -16,7 +15,6 @@ import { PipReactionsToggle } from './PipReactionsToggle' export const CollapsibleControls = { HAND: 'hand', - SUBTITLES: 'subtitles', SCREEN_SHARE: 'screenShare', REACTIONS: 'reactions', } as const @@ -26,7 +24,6 @@ export type CollapsibleControl = const COLLAPSE_ORDER: CollapsibleControl[] = [ CollapsibleControls.HAND, - CollapsibleControls.SUBTITLES, CollapsibleControls.SCREEN_SHARE, CollapsibleControls.REACTIONS, ] @@ -90,7 +87,6 @@ export const PipControlBar = ({ {!hidden.has(CollapsibleControls.REACTIONS) && } {showScreenShare && !hidden.has(CollapsibleControls.SCREEN_SHARE) && } - {!hidden.has(CollapsibleControls.SUBTITLES) && } {!hidden.has(CollapsibleControls.HAND) && } diff --git a/src/frontend/src/features/pip/components/controls/PipOverflowItems.tsx b/src/frontend/src/features/pip/components/controls/PipOverflowItems.tsx index f7875fb6..807a9579 100644 --- a/src/frontend/src/features/pip/components/controls/PipOverflowItems.tsx +++ b/src/frontend/src/features/pip/components/controls/PipOverflowItems.tsx @@ -2,7 +2,6 @@ import React from 'react' import { MenuItem } from 'react-aria-components' import { RiHand, - RiClosedCaptioningLine, RiArrowUpLine, RiEmotionLine, } from '@remixicon/react' @@ -12,8 +11,6 @@ import { pipLayoutStore } from '@/features/pip/stores/pipLayoutStore' import { menuRecipe } from '@/primitives/menuRecipe' import { useRoomContext, useTrackToggle } from '@livekit/components-react' import { useRaisedHand } from '@/features/rooms/livekit/hooks/useRaisedHand' -import { useSubtitles } from '@/features/subtitle/hooks/useSubtitles' -import { useAreSubtitlesAvailable } from '@/features/subtitle/hooks/useAreSubtitlesAvailable' import { useSnapshot } from 'valtio' import { CollapsibleControls, type CollapsibleControl } from '../PipControlBar' @@ -29,8 +26,6 @@ export const PipOverflowItems = ({ const { isHandRaised, toggleRaisedHand } = useRaisedHand({ participant: room.localParticipant, }) - const { areSubtitlesOpen, toggleSubtitles } = useSubtitles() - const areSubtitlesAvailable = useAreSubtitlesAvailable() const { buttonProps: screenShareProps, enabled: isScreenSharing } = useTrackToggle({ source: Track.Source.ScreenShare, @@ -59,14 +54,6 @@ export const PipOverflowItems = ({ {t(isScreenSharing ? 'controls.screenShare.stop' : 'controls.screenShare.start')} )} - {overflowControls.has(CollapsibleControls.SUBTITLES) && areSubtitlesAvailable && ( - - - {areSubtitlesOpen - ? t('controls.subtitles.open') - : t('controls.subtitles.closed')} - - )} {overflowControls.has(CollapsibleControls.HAND) && (