diff --git a/src/backend/core/recording/services/recording_events.py b/src/backend/core/recording/services/recording_events.py index a6ad1ae0..20fab691 100644 --- a/src/backend/core/recording/services/recording_events.py +++ b/src/backend/core/recording/services/recording_events.py @@ -94,7 +94,8 @@ class RecordingEventsService: def handle_update(recording: Recording, egress_status): """Handle egress status updates and sync recording state to room metadata. - Egress updates are sent exclusively for statuses EGRESS_ACTIVE and EGRESS_ENDING. + Egress updates only updates statuses to EGRESS_ACTIVE and EGRESS_ENDING. + Other statuses are sent through egress ending. """ room_name = str(recording.room.id) diff --git a/src/backend/core/tests/services/test_livekit_events.py b/src/backend/core/tests/services/test_livekit_events.py index 4cbb4227..710975a3 100644 --- a/src/backend/core/tests/services/test_livekit_events.py +++ b/src/backend/core/tests/services/test_livekit_events.py @@ -126,30 +126,6 @@ def test_handle_egress_updated_success( ) -@pytest.mark.parametrize( - "egress_status", - ( - EgressStatus.EGRESS_FAILED, - EgressStatus.EGRESS_ABORTED, - EgressStatus.EGRESS_LIMIT_REACHED, - ), -) -@mock.patch("core.services.room_management.RoomManagement.update_metadata") -def test_handle_egress_updated_non_handled( - mock_update_metadata, egress_status, service -): - """Should ignore certain egress status and don't trigger metadata updates.""" - - recording = RecordingFactory(worker_id="worker-1", status="initiated") - mock_data = mock.MagicMock() - mock_data.egress_info.egress_id = recording.worker_id - mock_data.egress_info.status = egress_status - - service._handle_egress_updated(mock_data) - - mock_update_metadata.assert_not_called() - - @pytest.mark.parametrize( ("mode", "notification_type"), (