From a70376c5ec2ae241ff32400971ec3cd0108fdaf7 Mon Sep 17 00:00:00 2001 From: lebaudantoine Date: Tue, 28 Jul 2026 14:24:35 +0200 Subject: [PATCH] =?UTF-8?q?=F0=9F=90=9B(frontend)=20fall=20back=20to=20use?= =?UTF-8?q?r.full=5Fname=20on=20request-entry?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Since the username refactoring, the username in the store could be undefined when the join input was pre-filled from user.full_name, because no keystroke was needed to populate the store. This led to a 400 error on the request-entry endpoint whenever the user joined without editing the pre-filled name. Fall back to user.full_name when the store username is missing, so the endpoint always receives a value. Acknowledged as a somewhat wobbly fix, but ships as-is until the underlying flow is reworked. --- CHANGELOG.md | 1 + src/frontend/src/features/rooms/components/Join.tsx | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index f84dd31f..544b5616 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -32,6 +32,7 @@ and this project adheres to - 🐛(summary) properly detect when failure webhook should be sent - 🐛(backend) preserve recording metadata when updating room access - 🐛(backend) allow any string as sub in the API serializer +- 🐛(frontend) fall back to user.full_name on request-entry ## [1.24.0] - 2026-07-21 diff --git a/src/frontend/src/features/rooms/components/Join.tsx b/src/frontend/src/features/rooms/components/Join.tsx index 895f4b1a..b3107b13 100644 --- a/src/frontend/src/features/rooms/components/Join.tsx +++ b/src/frontend/src/features/rooms/components/Join.tsx @@ -316,7 +316,7 @@ export const Join = ({ refetch: refetchRoom, } = useQuery({ queryKey: [keys.room, roomId], - queryFn: () => fetchRoom({ roomId, username }), + queryFn: () => fetchRoom({ roomId, username: username || user?.full_name }), staleTime: 6 * 60 * 60 * 1000, // By default, LiveKit access tokens expire 6 hours after generation retry: false, enabled: false, @@ -339,7 +339,7 @@ export const Join = ({ const { status, startWaiting } = useLobby({ roomId, - username, + username: username || user?.full_name || 'anonymous', onAccepted: handleAccepted, })