From 385bc29a60c44a92feece8ab2c09237347146e21 Mon Sep 17 00:00:00 2001 From: lebaudantoine Date: Wed, 14 Oct 2026 00:01:55 +0200 Subject: [PATCH] =?UTF-8?q?fixup!=20=E2=9C=A8(all)=20allow=20any=20authent?= =?UTF-8?q?icated=20user=20to=20start=20a=20recording?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../core/tests/rooms/test_api_rooms_lobby.py | 16 ++++++++++++++++ .../test_api_rooms_recording_participants.py | 16 ---------------- 2 files changed, 16 insertions(+), 16 deletions(-) diff --git a/src/backend/core/tests/rooms/test_api_rooms_lobby.py b/src/backend/core/tests/rooms/test_api_rooms_lobby.py index aebef284d..5027fb7ea 100644 --- a/src/backend/core/tests/rooms/test_api_rooms_lobby.py +++ b/src/backend/core/tests/rooms/test_api_rooms_lobby.py @@ -974,3 +974,19 @@ def test_request_entry_accepts_signed_credential(generate_config, _notify): assert response.json()["livekit"] == {"token": "test-token"} generate_config.assert_called_once() assert generate_config.call_args.kwargs["participant_id"] == public_id + + +@mock.patch( + "core.services.participants_management.ParticipantsManagement.check_if_in_meeting", + return_value=True, +) +def test_lobby_not_affected_by_recording_setting(mock_check, settings): + """The recording opt-out must not leak into the lobby capability.""" + settings.RECORDING_AUTHENTICATED_PARTICIPANTS_ENABLED = False + room = RoomFactory(access_level=RoomAccessLevel.TRUSTED) + user = UserFactory() + client = APIClient() + client.force_login(user) + response = client.get(f"/api/v1.0/rooms/{room.id}/waiting-participants/") + + assert response.status_code == 200 diff --git a/src/backend/core/tests/rooms/test_api_rooms_recording_participants.py b/src/backend/core/tests/rooms/test_api_rooms_recording_participants.py index 56565252a..8cdaaa53e 100644 --- a/src/backend/core/tests/rooms/test_api_rooms_recording_participants.py +++ b/src/backend/core/tests/rooms/test_api_rooms_recording_participants.py @@ -241,22 +241,6 @@ def test_participant_path_disabled_admin_still_records( mock_check.assert_not_called() -@mock.patch( - "core.services.participants_management.ParticipantsManagement.check_if_in_meeting", - return_value=True, -) -def test_lobby_not_affected_by_recording_setting(mock_check, settings): - """The recording opt-out must not leak into the lobby capability.""" - settings.RECORDING_AUTHENTICATED_PARTICIPANTS_ENABLED = False - room = RoomFactory(access_level=RoomAccessLevel.TRUSTED) - user = UserFactory() - client = APIClient() - client.force_login(user) - response = client.get(f"/api/v1.0/rooms/{room.id}/waiting-participants/") - - assert response.status_code == 200 - - @mock.patch( "core.services.participants_management.ParticipantsManagement.check_if_in_meeting", return_value=True,