mirror of
https://github.com/storytold/lightcraft.git
synced 2026-10-25 10:51:07 +00:00
Nathaniel Ledford
5895918791
.github/PULL_REQUEST_TEMPLATE.md asks for what the people merging ask for most in their comments on past pull requests: the issue it fixes, overlap with other open pull requests, whether existing edits render differently, the shared version numbers it takes, where decoder and camera data came from, and new dependencies or CI changes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
3.9 KiB
3.9 KiB
Fixes #
Problem
Change
Not in this PR:
How it was checked
cargo xtask cipasses on this branch, rebased on currentmain- A test that fails without this change (for a crash fix: a regression test that panicked before it)
- User-visible change: ran the app and looked at the result
Screenshots
Merging
- Overlap:
- Existing edits and libraries:
- Shared numbers taken:
- Where it came from:
- New dependencies,
unsafe, build scripts, network access, spawned processes, deleted files, CI orxtaskgate changes:
Checklist
- No new panic path in non-test code: no
unwrap/expect/panic!, no indexing or unchecked arithmetic on a number from a file, a person or an agent (get,checked_mul, NaN and char boundaries handled) - New text on screen goes through
tr()and has its key incrates/ui-egui/locales/*.json; a new shortcut is free indocs/library-shortcuts.md - The feature's rows in
docs/parity-checklist.mdand its entry indocs/gaps.mdare updated, honestly (🟡 when it is partial), in the same commit - New code has a caller: no command, module or setting that nothing reaches yet
- Every new image, icon or other asset has its entry in
assets/ATTRIBUTION.md; no font or media files added - Ready to merge (otherwise open it as a draft)