From a1efe36ff19cc10de467ed9bd135ff040c8ad1c2 Mon Sep 17 00:00:00 2001
From: Aarnav Tale <aarnavtale@icloud.com>
Date: Sun, 8 Mar 2026 01:55:38 -0500
Subject: [PATCH] fix: rename pending approval to no access
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Member role simply has no UI permissions — not a pending state.

Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019cce57-c9e1-7732-9709-8288127573a9
---
 app/layouts/shell.tsx                    | 13 +++++--------
 app/routes/users/components/user-row.tsx |  7 +------
 2 files changed, 6 insertions(+), 14 deletions(-)

diff --git a/app/layouts/shell.tsx b/app/layouts/shell.tsx
index 5ec00be..1eb7d85 100644
--- a/app/layouts/shell.tsx
+++ b/app/layouts/shell.tsx
@@ -53,7 +53,7 @@ export async function loader({ request, context }: Route.LoaderArgs) {
         settings: context.auth.can(principal, Capabilities.read_feature),
       },
       onboarding: request.url.endsWith("/onboarding"),
-      pendingApproval: !check && principal.kind === "oidc",
+      noAccess: !check && principal.kind === "oidc",
       healthy: await api.isHealthy(),
     };
   } catch {
@@ -66,20 +66,17 @@ export async function loader({ request, context }: Route.LoaderArgs) {
 }
 
 export default function Shell({ loaderData }: Route.ComponentProps) {
-  if (loaderData.pendingApproval && !loaderData.onboarding) {
+  if (loaderData.noAccess && !loaderData.onboarding) {
     return (
       <>
         <Header {...loaderData} />
         <main className="container mx-auto mt-4 mb-24 overscroll-contain">
           <div className="mx-auto mt-24 max-w-lg">
             <Card variant="flat">
-              <Card.Title className="mb-4">Pending Approval</Card.Title>
+              <Card.Title className="mb-4">No Access</Card.Title>
               <Card.Text>
-                Your account has been created but you don't have access to the UI yet. An
-                administrator needs to assign you a role before you can continue.
-              </Card.Text>
-              <Card.Text className="mt-2">
-                If you believe this is a mistake, please contact your administrator.
+                Your account doesn't have permission to access the dashboard. Contact an
+                administrator if you need access.
               </Card.Text>
               <Form action="/logout" className="mt-6" method="POST">
                 <Button className="w-full" type="submit" variant="light">
diff --git a/app/routes/users/components/user-row.tsx b/app/routes/users/components/user-row.tsx
index 2be65f6..29fb29a 100644
--- a/app/routes/users/components/user-row.tsx
+++ b/app/routes/users/components/user-row.tsx
@@ -90,12 +90,7 @@ function mapRoleToName(role: string) {
     case "auditor":
       return "Auditor";
     case "member":
-      return (
-        <span className="inline-flex items-center gap-1.5">
-          <span className="h-2 w-2 animate-pulse rounded-full bg-amber-500" />
-          <span className="text-amber-600 dark:text-amber-400">Pending Approval</span>
-        </span>
-      );
+      return <p className="opacity-50">No Access</p>;
     default:
       return "Unknown";
   }