From 662c38ea4474f306918d10087445d3e39526f095 Mon Sep 17 00:00:00 2001 From: Aarnav Tale Date: Fri, 16 May 2025 11:16:36 -0400 Subject: [PATCH] fix: handle newlines in provided secret paths --- CHANGELOG.md | 1 + app/server/web/oidc.ts | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index ba7dc25..bbddfd1 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -23,6 +23,7 @@ - AAAA records are now supported on the DNS page (closes [#189](https://github.com/tale/headplane/issues/189)). - Add support for `dns.extra_records_path` in the Headscale config (closes [#144](https://github.com/tale/headplane/issues/144)). - Tighten `proc` integration logic by checking for the `headscale serve` command (via #[195](https://github.com/tale/headplane/pull/195)). +- Strip newlines in the OIDC `client_secret_path` file if provided (closes [#199](https://github.com/tale/headplane/issues/199)). ### 0.5.10 (April 4, 2025) - Fix an issue where other preferences to skip onboarding affected every user. diff --git a/app/server/web/oidc.ts b/app/server/web/oidc.ts index c8cbcb6..7d566bd 100644 --- a/app/server/web/oidc.ts +++ b/app/server/web/oidc.ts @@ -31,7 +31,7 @@ async function loadClientSecret(path: string) { return; } - return secret; + return secret.trim(); } catch (error) { log.error('config', 'Failed to read client secret from %s', path); log.error('config', 'Error: %s', error);