gsadmin/headplane
1
0
Fork 0
mirror of https://github.com/tale/headplane.git synced 2026-08-06 20:33:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: condense/cleanup bad tests

Browse Source
This commit is contained in:
Aarnav Tale
2026-03-07 15:11:15 -05:00
parent da3132323c
commit 5f2cbebbcd
9 changed files with 200 additions and 855 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/unit/utils/user.test.ts
+1 -44
View File
@@ -1,8 +1,7 @@
import { describe, expect, test } from "vitest";
import type { User } from "~/types/User";
import { filterUsersWithValidIds, getUserDisplayName } from "~/utils/user";
import { getUserDisplayName } from "~/utils/user";
const makeUser = (overrides: Partial<User>): User => ({
id: "default-id",
@@ -11,48 +10,6 @@ const makeUser = (overrides: Partial<User>): User => ({
...overrides,
});
describe("filterUsersWithValidIds", () => {
test("keeps users with valid ID and name", () => {
const users = [makeUser({ id: "123", name: "John" })];
const result = filterUsersWithValidIds(users);
expect(result).toHaveLength(1);
expect(result[0].id).toBe("123");
});
test("keeps users with valid ID but no name", () => {
const users = [makeUser({ id: "123", name: "" })];
const result = filterUsersWithValidIds(users);
expect(result).toHaveLength(1);
});
test("keeps users with valid ID and no optional fields", () => {
const users = [makeUser({ id: "123", name: "", displayName: undefined, email: undefined })];
const result = filterUsersWithValidIds(users);
expect(result).toHaveLength(1);
});
test("removes users with empty ID", () => {
const users = [makeUser({ id: "", name: "John" })];
const result = filterUsersWithValidIds(users);
expect(result).toHaveLength(0);
});
test("handles mix of valid and invalid", () => {
const users = [
makeUser({ id: "123", name: "John" }),
makeUser({ id: "", name: "Jane" }),
makeUser({ id: "456", name: "" }),
];
const result = filterUsersWithValidIds(users);
expect(result).toHaveLength(2);
expect(result.map((u) => u.id)).toEqual(["123", "456"]);
});
test("returns empty for empty input", () => {
expect(filterUsersWithValidIds([])).toHaveLength(0);
});
});
describe("getUserDisplayName", () => {
test("uses name when set", () => {
const user = makeUser({ id: "123", name: "John" });