gsadmin/headplane
1
0
Fork 0
mirror of https://github.com/tale/headplane.git synced 2026-08-27 15:37:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat: do partial client method validation

Browse Source
This commit is contained in:
Aarnav Tale
2025-01-06 08:19:15 +05:30
parent fc5028994a
commit 55c832c536
1 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/utils/oidc.ts
+8 -3
View File
@@ -2,7 +2,8 @@ import { redirect } from 'react-router';
import { import {
authorizationCodeGrantRequest, authorizationCodeGrantRequest,
calculatePKCECodeChallenge, calculatePKCECodeChallenge,
type Client, Client,
ClientAuthenticationMethod,
discoveryRequest, discoveryRequest,
generateRandomCodeVerifier, generateRandomCodeVerifier,
generateRandomNonce, generateRandomNonce,
@@ -34,10 +35,12 @@ export async function startOidc(oidc: OidcConfig, req: Request) {
}); });
} }
// TODO: Properly validate the method is a valid type
const method = oidc.method as ClientAuthenticationMethod;
const issuerUrl = new URL(oidc.issuer); const issuerUrl = new URL(oidc.issuer);
const oidcClient = { const oidcClient = {
client_id: oidc.client, client_id: oidc.client,
token_endpoint_auth_method: oidc.method, token_endpoint_auth_method: method
} satisfies Client; } satisfies Client;
const response = await discoveryRequest(issuerUrl); const response = await discoveryRequest(issuerUrl);
@@ -88,11 +91,13 @@ export async function finishOidc(oidc: OidcConfig, req: Request) {
}); });
} }
// TODO: Properly validate the method is a valid type
const method = oidc.method as ClientAuthenticationMethod;
const issuerUrl = new URL(oidc.issuer); const issuerUrl = new URL(oidc.issuer);
const oidcClient = { const oidcClient = {
client_id: oidc.client, client_id: oidc.client,
client_secret: oidc.secret, client_secret: oidc.secret,
token_endpoint_auth_method: oidc.method, token_endpoint_auth_method: method,
} satisfies Client; } satisfies Client;
const response = await discoveryRequest(issuerUrl); const response = await discoveryRequest(issuerUrl);