From 44f45c396cbca0354a6f10ce239de456cd4be52c Mon Sep 17 00:00:00 2001 From: Siemen Van den Neste Date: Sun, 29 Mar 2026 20:37:18 +0200 Subject: [PATCH] fix: update user filtering to use user name instead of user ID --- app/routes/machines/components/machine-filters.tsx | 2 +- app/routes/machines/overview.tsx | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/app/routes/machines/components/machine-filters.tsx b/app/routes/machines/components/machine-filters.tsx index f88b84a..ace228e 100644 --- a/app/routes/machines/components/machine-filters.tsx +++ b/app/routes/machines/components/machine-filters.tsx @@ -94,7 +94,7 @@ export function MachineFilters({ users, populatedNodes }: MachineFiltersProps): const tagOwnedExists = populatedNodes.some((n) => !n.user); const userOptions = [ ...(tagOwnedExists ? [{ value: "tag-owned", label: "Tag-owned" }] : []), - ...users.map((u) => ({ value: u.id, label: getUserDisplayName(u) })), + ...users.map((u) => ({ value: u.name, label: getUserDisplayName(u) })), ]; const tagOptions = Array.from(new Set(populatedNodes.flatMap((n) => n.tags))) diff --git a/app/routes/machines/overview.tsx b/app/routes/machines/overview.tsx index adb92bb..9718553 100644 --- a/app/routes/machines/overview.tsx +++ b/app/routes/machines/overview.tsx @@ -119,7 +119,7 @@ export default function Page({ loaderData }: Route.ComponentProps) { node.givenName.toLowerCase().includes(query) || node.ipAddresses.some((ip) => ip.toLowerCase().includes(query))) && (filterUser === null || - (filterUser === "tag-owned" ? !node.user : node.user?.id === filterUser)) && + (filterUser === "tag-owned" ? !node.user : node.user?.name === filterUser)) && (filterTag === null || (node.tags?.includes(filterTag) ?? false)) && (filterStatus === null || STATUS_MATCH[filterStatus](node)) && (filterRoute === null || ROUTE_MATCH[filterRoute](node)),