From c8e7a7e7e65fbdcdbf02658ef831418de92c44a3 Mon Sep 17 00:00:00 2001 From: Chris F Ravenscroft Date: Sat, 18 Jul 2026 14:44:15 -0700 Subject: [PATCH] fix: use configHandler.Bind rather than helper.Bind in test harness --- v2/pkg/handler/disabled_bind_test.go | 19 ++++++++++++++++--- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/v2/pkg/handler/disabled_bind_test.go b/v2/pkg/handler/disabled_bind_test.go index c4da8a5..f8597a2 100644 --- a/v2/pkg/handler/disabled_bind_test.go +++ b/v2/pkg/handler/disabled_bind_test.go @@ -1,7 +1,6 @@ package handler import ( - "context" "encoding/hex" "net" "testing" @@ -14,9 +13,22 @@ import ( "github.com/glauth/ldap" ) +type disabledBindTestMonitor struct{} + +func (disabledBindTestMonitor) SetResponseTimeMetric(map[string]string, float64) error { + return nil +} + +func (disabledBindTestMonitor) SetLDAPMetric(map[string]string, float64) error { + return nil +} + func TestConfigBackendDisabledUserCannotBind(t *testing.T) { pw := "correct horse" - raw, _ := bcrypt.GenerateFromPassword([]byte(pw), bcrypt.MinCost) + raw, err := bcrypt.GenerateFromPassword([]byte(pw), bcrypt.MinCost) + if err != nil { + t.Fatal(err) + } hexHash := hex.EncodeToString(raw) cfg := &config.Config{} @@ -37,13 +49,14 @@ func TestConfigBackendDisabledUserCannotBind(t *testing.T) { log: &logger, cfg: cfg, ldohelper: helper, + monitor: disabledBindTestMonitor{}, tracer: tracer, } _, server := net.Pipe() defer server.Close() bind := func(dn, pass string) ldap.LDAPResultCode { - code, _ := helper.Bind(context.Background(), h, dn, pass, server) + code, _ := h.Bind(dn, pass, server) return code }