From e85d357abd511dc0d0032abc37b70d9956507d53 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Greg=20Berg=C3=A9?= Date: Tue, 10 Dec 2024 17:39:22 +0100 Subject: [PATCH] Fix React DOM warning (#2615) --- packages/gitbook/src/components/Header/HeaderLink.tsx | 2 +- packages/gitbook/src/lib/emojis.test.ts | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/gitbook/src/components/Header/HeaderLink.tsx b/packages/gitbook/src/components/Header/HeaderLink.tsx index 8662353a4..1e60663fe 100644 --- a/packages/gitbook/src/components/Header/HeaderLink.tsx +++ b/packages/gitbook/src/components/Header/HeaderLink.tsx @@ -104,7 +104,7 @@ function HeaderItemButton( linkStyle: 'button-secondary' | 'button-primary'; }, ) { - const { linkStyle, headerPreset, title, href, ...rest } = props; + const { linkStyle, headerPreset, title, href, isDropdown, ...rest } = props; const variant = (() => { switch (linkStyle) { case 'button-secondary': diff --git a/packages/gitbook/src/lib/emojis.test.ts b/packages/gitbook/src/lib/emojis.test.ts index f56586c02..cd288ccb7 100644 --- a/packages/gitbook/src/lib/emojis.test.ts +++ b/packages/gitbook/src/lib/emojis.test.ts @@ -9,6 +9,8 @@ describe('getEmojiForCode', () => { it('should handle complex codes', () => { expect(getEmojiForCode('1f935-2642')).toEqual('🤵‍♂️'); + expect(getEmojiForCode('1f3c3-2642')).toEqual('🏃‍♂️'); + expect(getEmojiForCode('1f468-2696')).toEqual('👨‍⚖️'); }); it('should return an empty string if invalid', () => {