diff --git a/lib/output/modifiers/__tests__/resolveLinks.js b/lib/output/modifiers/__tests__/resolveLinks.js index c57346a81..8904c118d 100644 --- a/lib/output/modifiers/__tests__/resolveLinks.js +++ b/lib/output/modifiers/__tests__/resolveLinks.js @@ -87,6 +87,18 @@ describe('resolveLinks', function() { }); }); + describe('External link', function() { + var TEST = '

This is a external link

'; + + it('should have target="_blank" attribute', function() { + var $ = cheerio.load(TEST); + + return resolveLinks('hello.md', resolveFileBasic, $) + .then(function() { + var link = $('a'); + expect(link.attr('target')).toBe('_blank'); + }); + }); + }); + }); - - diff --git a/lib/output/modifiers/resolveLinks.js b/lib/output/modifiers/resolveLinks.js index 0dd46bb40..9d15e5ed4 100644 --- a/lib/output/modifiers/resolveLinks.js +++ b/lib/output/modifiers/resolveLinks.js @@ -24,7 +24,7 @@ function resolveLinks(currentFile, resolveFile, $) { } if (LocationUtils.isExternal(href)) { - $a.attr('_target', 'blank'); + $a.attr('target', '_blank'); return; }