From 177afa5828704d3500ddeec4d0378d472dc2f5e6 Mon Sep 17 00:00:00 2001 From: Viktor Renkema <49148610+viktorrenkema@users.noreply.github.com> Date: Fri, 5 Sep 2025 10:42:57 +0200 Subject: [PATCH] Handle non-defined objectFit on card cover images (#3625) --- .../src/components/DocumentView/Table/RecordCard.tsx | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/packages/gitbook/src/components/DocumentView/Table/RecordCard.tsx b/packages/gitbook/src/components/DocumentView/Table/RecordCard.tsx index cbf309301..1793542ed 100644 --- a/packages/gitbook/src/components/DocumentView/Table/RecordCard.tsx +++ b/packages/gitbook/src/components/DocumentView/Table/RecordCard.tsx @@ -40,8 +40,8 @@ export async function RecordCard( const darkCoverIsSquareOrPortrait = isSquareOrPortrait(darkCover); const lightCoverIsSquareOrPortrait = isSquareOrPortrait(lightCover); - const darkObjectFit = dark.objectFit ? `dark:${getObjectFitClass(dark.objectFit)}` : ''; - const lightObjectFit = light.objectFit ? getObjectFitClass(light.objectFit) : ''; + const darkObjectFit = `dark:${getObjectFitClass(dark.objectFit)}`; + const lightObjectFit = getObjectFitClass(light.objectFit); const objectFits = `${lightObjectFit} ${darkObjectFit}`; const body = ( @@ -204,7 +204,11 @@ function isSquareOrPortrait(contentRef: ResolvedContentRef | null) { /** * Get the CSS class for object-fit based on the objectFit value. */ -function getObjectFitClass(objectFit: CardsImageObjectFit): string { +function getObjectFitClass(objectFit: CardsImageObjectFit | undefined): string { + if (!objectFit) { + return 'object-cover'; + } + switch (objectFit) { case CardsImageObjectFit.Contain: return 'object-contain';