From 0a8dd67541bc613ef58058cfd0c58582ea0365d6 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Greg=20Berg=C3=A9?= <berge.greg@gmail.com>
Date: Fri, 11 Jul 2025 09:45:14 +0200
Subject: [PATCH] Better aria for breadcrumbs (#3461)

---
 .../src/components/PageBody/PageHeader.tsx    | 56 +++++++++----------
 1 file changed, 27 insertions(+), 29 deletions(-)

diff --git a/packages/gitbook/src/components/PageBody/PageHeader.tsx b/packages/gitbook/src/components/PageBody/PageHeader.tsx
index 6a37ab33f..f0be51ccd 100644
--- a/packages/gitbook/src/components/PageBody/PageHeader.tsx
+++ b/packages/gitbook/src/components/PageBody/PageHeader.tsx
@@ -5,7 +5,6 @@ import type { AncestorRevisionPage } from '@/lib/pages';
 import { tcls } from '@/lib/tailwind';
 import type { RevisionPageDocument } from '@gitbook/api';
 import { Icon } from '@gitbook/icons';
-import { Fragment } from 'react';
 import { PageIcon } from '../PageIcon';
 import { StyledLink } from '../primitives';
 
@@ -56,7 +55,7 @@ export async function PageHeader(props: {
                 </div>
             ) : null}
             {ancestors.length > 0 && (
-                <nav>
+                <nav aria-label="Breadcrumb">
                     <ol className={tcls('flex', 'flex-wrap', 'items-center', 'gap-2', 'text-tint')}>
                         {ancestors.map((breadcrumb, index) => {
                             const href = linker.toPathForPage({
@@ -64,38 +63,37 @@ export async function PageHeader(props: {
                                 page: breadcrumb,
                             });
                             return (
-                                <Fragment key={breadcrumb.id}>
-                                    <li key={breadcrumb.id}>
-                                        <StyledLink
-                                            href={href}
-                                            className={tcls(
-                                                'no-underline',
-                                                'hover:underline',
-                                                'text-xs',
-                                                'tracking-wide',
-                                                'font-semibold',
-                                                'uppercase',
-                                                'flex',
-                                                'items-center',
-                                                'gap-1.5',
-                                                'contrast-more:underline',
-                                                'contrast-more:decoration-current'
-                                            )}
-                                        >
-                                            <PageIcon
-                                                page={breadcrumb}
-                                                style="flex size-4 items-center justify-center text-base leading-none"
-                                            />
-                                            {breadcrumb.title}
-                                        </StyledLink>
-                                    </li>
+                                <li key={breadcrumb.id} className="flex items-center gap-2">
+                                    <StyledLink
+                                        href={href}
+                                        className={tcls(
+                                            'no-underline',
+                                            'hover:underline',
+                                            'text-xs',
+                                            'tracking-wide',
+                                            'font-semibold',
+                                            'uppercase',
+                                            'flex',
+                                            'items-center',
+                                            'gap-1.5',
+                                            'contrast-more:underline',
+                                            'contrast-more:decoration-current'
+                                        )}
+                                    >
+                                        <PageIcon
+                                            page={breadcrumb}
+                                            style="flex size-4 items-center justify-center text-base leading-none"
+                                        />
+                                        {breadcrumb.title}
+                                    </StyledLink>
                                     {index !== ancestors.length - 1 && (
                                         <Icon
+                                            aria-hidden
                                             icon="chevron-right"
-                                            className={tcls('size-3', 'text-tint-subtle')}
+                                            className="size-3 text-tint-subtle"
                                         />
                                     )}
-                                </Fragment>
+                                </li>
                             );
                         })}
                     </ol>