From 04c025774d9e974bf2f4d4ec2422867c7c239b40 Mon Sep 17 00:00:00 2001 From: Aaron O'Mullan Date: Tue, 17 Jun 2014 10:56:13 -0700 Subject: [PATCH] Improve robustness of link utility functions Fixes #321, fixes #323 --- lib/utils/links.js | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/lib/utils/links.js b/lib/utils/links.js index 6606bbf9b..b4d2fb722 100644 --- a/lib/utils/links.js +++ b/lib/utils/links.js @@ -3,14 +3,22 @@ var path = require('path'); // Is the link an external link var isExternal = function(href) { - return Boolean(url.parse(href).protocol); + try { + return Boolean(url.parse(href).protocol); + } catch(err) { } + + return false; }; // Return true if the link is relative var isRelative = function(href) { - var parsed = url.parse(href); + try { + var parsed = url.parse(href); - return !parsed.protocol && parsed.path && parsed.path[0] != '/'; + return !parsed.protocol && parsed.path && parsed.path[0] != '/'; + } catch(err) {} + + return true; }; // Relative to absolute path