admin api: avoid overwriting redirect rules in UpdateBucket

.woodpecker/debug.yaml

@@ -28,11 +28,6 @@ steps:
     commands:
       - nix-build -j4 --attr flakePackages.tests-sqlite
 
-  - name: unit + func tests (fjall)
-    image: nixpkgs/nix:nixos-22.05
-    commands:
-      - nix-build -j4 --attr flakePackages.tests-fjall
-
   - name: integration tests
     image: nixpkgs/nix:nixos-22.05
     commands:

Cargo.toml

@@ -24,18 +24,18 @@ default-members = ["src/garage"]
 
 # Internal Garage crates
 format_table = { version = "0.1.1", path = "src/format-table" }
-garage_api_common = { version = "1.2.0", path = "src/api/common" }
+garage_api_common = { version = "1.1.0", path = "src/api/common" }
-garage_api_admin = { version = "1.2.0", path = "src/api/admin" }
+garage_api_admin = { version = "1.1.0", path = "src/api/admin" }
-garage_api_s3 = { version = "1.2.0", path = "src/api/s3" }
+garage_api_s3 = { version = "1.1.0", path = "src/api/s3" }
-garage_api_k2v = { version = "1.2.0", path = "src/api/k2v" }
+garage_api_k2v = { version = "1.1.0", path = "src/api/k2v" }
-garage_block = { version = "1.2.0", path = "src/block" }
+garage_block = { version = "1.1.0", path = "src/block" }
-garage_db = { version = "1.2.0", path = "src/db", default-features = false }
+garage_db = { version = "1.1.0", path = "src/db", default-features = false }
-garage_model = { version = "1.2.0", path = "src/model", default-features = false }
+garage_model = { version = "1.1.0", path = "src/model", default-features = false }
-garage_net = { version = "1.2.0", path = "src/net" }
+garage_net = { version = "1.1.0", path = "src/net" }
-garage_rpc = { version = "1.2.0", path = "src/rpc" }
+garage_rpc = { version = "1.1.0", path = "src/rpc" }
-garage_table = { version = "1.2.0", path = "src/table" }
+garage_table = { version = "1.1.0", path = "src/table" }
-garage_util = { version = "1.2.0", path = "src/util" }
+garage_util = { version = "1.1.0", path = "src/util" }
-garage_web = { version = "1.2.0", path = "src/web" }
+garage_web = { version = "1.1.0", path = "src/web" }
 k2v-client = { version = "0.0.4", path = "src/k2v-client" }
 
 # External crates from crates.io
@@ -58,6 +58,7 @@ git-version = "0.3.4"
 hex = "0.4"
 hexdump = "0.1"
 hmac = "0.12"
+idna = "0.5"
 itertools = "0.12"
 ipnet = "2.9.0"
 lazy_static = "1.4"
@@ -65,7 +66,6 @@ md-5 = "0.10"
 mktemp = "0.5"
 nix = { version = "0.29", default-features = false, features = ["fs"] }
 nom = "7.1"
-parking_lot = "0.12"
 parse_duration = "2.1"
 pin-project = "1.0.12"
 pnet_datalink = "0.34"
@@ -84,14 +84,12 @@ pretty_env_logger = "0.5"
 structopt = { version = "0.3", default-features = false }
 syslog-tracing = "0.3"
 tracing = "0.1"
-tracing-journald = "0.3.1"
 tracing-subscriber = { version = "0.3", features = ["env-filter"] }
 
 heed = { version = "0.11", default-features = false, features = ["lmdb"] }
 rusqlite = "0.31.0"
 r2d2 = "0.8"
 r2d2_sqlite = "0.24"
-fjall = "2.4"
 
 async-compression = { version = "0.4", features = ["tokio", "zstd"] }
 zstd = { version = "0.13", default-features = false }
@@ -134,8 +132,8 @@ opentelemetry-contrib = "0.9"
 prometheus = "0.13"
 
 # used by the k2v-client crate only
-aws-sigv4 = { version = "1.1", default-features = false }
+aws-sigv4 = { version = "1.1" }
-hyper-rustls = { version = "0.26", default-features = false, features = ["http1", "http2", "ring", "rustls-native-certs"] }
+hyper-rustls = { version = "0.26", features = ["http2"] }
 log = "0.4"
 thiserror = "1.0"
 
@@ -143,9 +141,8 @@ thiserror = "1.0"
 assert-json-diff = "2.0"
 rustc_version = "0.4.0"
 static_init = "1.0"
-aws-smithy-runtime = { version = "1.8", default-features = false, features = ["tls-rustls"] }
+aws-sdk-config = "1.62"
-aws-sdk-config = { version = "1.62", default-features = false }
+aws-sdk-s3 = "=1.68"
-aws-sdk-s3 = { version = "1.79", default-features = false, features = ["rt-tokio"] }
 
 [profile.dev]
 #lto = "thin"	# disabled for now, adds 2-4 min to each CI build

doc/book/connect/apps/index.md

@@ -12,7 +12,7 @@ In this section, we cover the following web applications:
 | [Mastodon](#mastodon)     | ✅       | Natively supported    |
 | [Matrix](#matrix)     | ✅       |  Tested with `synapse-s3-storage-provider`    |
 | [ejabberd](#ejabberd)     | ✅       |  `mod_s3_upload`    |
-| [Pixelfed](#pixelfed)     | ✅       |  Natively supported    |
+| [Pixelfed](#pixelfed)     | ❓       |  Not yet tested    |
 | [Pleroma](#pleroma)     | ❓       |  Not yet tested    |
 | [Lemmy](#lemmy)     | ✅        |  Supported with pict-rs    |
 | [Funkwhale](#funkwhale)     | ❓       | Not yet tested     |
@@ -69,7 +69,7 @@ $CONFIG = array(
         'hostname' => '127.0.0.1', // Can also be a domain name, eg. garage.example.com
         'port' => 3900,            // Put your reverse proxy port or your S3 API port
         'use_ssl' => false,        // Set it to true if you have a TLS enabled reverse proxy
-        'region' => 'garage',      // Garage default region is named "garage", edit according to your cluster config
+        'region' => 'garage',      // Garage has only one region named "garage"
         'use_path_style' => true   // Garage supports only path style, must be set to true
     ],
 ],
@@ -135,7 +135,7 @@ bucket but doesn't also know the secret encryption key.
 *Click on the picture to zoom*
 
 Add a new external storage. Put what you want in "folder name" (eg. "shared"). Select "Amazon S3". Keep "Access Key" for the Authentication field.
-In Configuration, put your bucket name (eg. nextcloud), the host (eg. 127.0.0.1), the port (eg. 3900 or 443), the region ("garage" if you use the default, or the one your configured in your `garage.toml`). Tick the SSL box if you have put an HTTPS proxy in front of garage. You must tick the "Path access" box and you must leave the "Legacy authentication (v2)" box empty. Put your Key ID (eg. GK...) and your Secret Key in the last two input boxes. Finally click on the tick symbol on the right of your screen.
+In Configuration, put your bucket name (eg. nextcloud), the host (eg. 127.0.0.1), the port (eg. 3900 or 443), the region (garage). Tick the SSL box if you have put an HTTPS proxy in front of garage. You must tick the "Path access" box and you must leave the "Legacy authentication (v2)" box empty. Put your Key ID (eg. GK...) and your Secret Key in the last two input boxes. Finally click on the tick symbol on the right of your screen.
 
 Now go to your "Files" app and a new "linked folder" has appeared with the name you chose earlier (eg. "shared").
 
@@ -191,10 +191,10 @@ garage key create peertube-key
 
 Keep the Key ID and the Secret key in a pad, they will be needed later.  
 
-We need two buckets, one for normal videos (named peertube-videos) and one for webtorrent videos (named peertube-playlists).
+We need two buckets, one for normal videos (named peertube-video) and one for webtorrent videos (named peertube-playlist).
 ```bash
 garage bucket create peertube-videos
-garage bucket create peertube-playlists
+garage bucket create peertube-playlist
 ```
 
 Now we allow our key to read and write on these buckets:
@@ -238,7 +238,7 @@ object_storage:
   # Put localhost only if you have a garage instance running on that node
   endpoint: 'http://localhost:3900' # or "garage.example.com" if you have TLS on port 443
 
-  # Garage default region is named "garage", edit according to your config
+  # Garage supports only one region for now, named garage
   region: 'garage'
 
   credentials:
@@ -253,7 +253,7 @@ object_storage:
     proxify_private_files: false
 
   streaming_playlists:
-    bucket_name: 'peertube-playlists'
+    bucket_name: 'peertube-playlist'
 
     # Keep it empty for our example
     prefix: ''
@@ -441,7 +441,7 @@ media_storage_providers:
   store_synchronous: True  # do we want to wait that the file has been written before returning?
   config:
     bucket: matrix       # the name of our bucket, we chose matrix earlier
-    region_name: garage  # "garage" by default, edit according to your cluster config
+    region_name: garage  # only "garage" is supported for the region field
     endpoint_url: http://localhost:3900 # the path to the S3 endpoint
     access_key_id: "GKxxx" # your Key ID
     secret_access_key: "xxxx" # your Secret Key

doc/book/cookbook/ansible.md

@@ -8,18 +8,18 @@ have published Ansible roles.  We list them and compare them below.
 
 ## Comparison of Ansible roles
 
-| Feature                            | [ansible-role-garage](#zorun-ansible-role-garage) | [garage-docker-ansible-deploy](#moan0s-garage-docker-ansible-deploy) | [eddster ansible-role-garage](#eddster-ansible-role-garage) |
+| Feature                            | [ansible-role-garage](#zorun-ansible-role-garage) | [garage-docker-ansible-deploy](#moan0s-garage-docker-ansible-deploy) |
-|------------------------------------|---------------------------------------------|---------------------------------------------------------------|---------------------------------|
+|------------------------------------|---------------------------------------------|---------------------------------------------------------------|
-| **Runtime**                        | Systemd                                     | Docker                                                        | Systemd                         |
+| **Runtime**                        | Systemd                                     | Docker                                                        |
-| **Target OS**                      | Any Linux                                   | Any Linux                                                     | Any Linux                       |
+| **Target OS**                      | Any Linux                                   | Any Linux                                                     |
-| **Architecture**                   | amd64, arm64, i686                          | amd64, arm64                                                  | arm64, arm, 386, amd64                            |
+| **Architecture**                   | amd64, arm64, i686                          | amd64, arm64                                                  |
-| **Additional software**            | None                                        | Traefik                                                       | Ngnix and Keepalived (optional) |
+| **Additional software**            | None                                        | Traefik                                                       |
-| **Automatic node connection**      | ❌                                          | ✅                                                            | ✅                              |
+| **Automatic node connection**      | ❌                                          | ✅                                                            |
-| **Layout management**              | ❌                                          | ✅                                                            | ✅                              |
+| **Layout management**              | ❌                                          | ✅                                                            |
-| **Manage buckets & keys**          | ❌                                          | ✅ (basic)                                                    | ✅                              |
+| **Manage buckets & keys**          | ❌                                          | ✅ (basic)                                                    |
-| **Allow custom Garage config**     | ✅                                          | ❌                                                            | ❌                              |
+| **Allow custom Garage config**     | ✅                                          | ❌                                                            |
-| **Facilitate Garage upgrades**     | ✅                                          | ❌                                                            | ✅                              |
+| **Facilitate Garage upgrades**     | ✅                                          | ❌                                                            |
-| **Multiple instances on one host** | ✅                                          | ✅                                                            | ❌                              |
+| **Multiple instances on one host** | ✅                                          | ✅                                                            |
 
 
 ## zorun/ansible-role-garage
@@ -49,15 +49,3 @@ structured DNS names, etc).
 
 As a result, this role makes it easier to start with Garage on Ansible,
 but is less flexible.
-
-## eddster2309/ansible-role-garage
-
-[Source code](https://github.com/eddster2309/ansible-role-garage), [Ansible galaxy](https://galaxy.ansible.com/ui/standalone/roles/eddster2309/garage/)
-
-This role is a opinionated but customisable role using the official Garage
-static binaries and only requires Systemd. As such it should work on any
-Linux based host. It includes all the nesscary configuration to
-automatically setup a clustered Garage deployment. Most Garage
-configuration options are exposed through Ansible variables so while you
-can't provide a custom config you can get very close. It can optionally
-installed a HA nginx deployment with Keepalived.

doc/book/cookbook/kubernetes.md

@@ -26,13 +26,6 @@ Or deploy with custom values:
 helm install --create-namespace --namespace garage garage ./garage -f values.override.yaml
 ```
 
-If you want to manage the CustomRessourceDefinition used by garage for its `kubernetes_discovery` outside of the helm chart, add `garage.kubernetesSkipCrd: true` to your custom values and use the kustomization before deploying the helm chart:
-
-```bash
-kubectl apply -k ../k8s/crd
-helm install --create-namespace --namespace garage garage ./garage -f values.override.yaml
-```
-
 After deploying, cluster layout must be configured manually as described in [Creating a cluster layout](@/documentation/quick-start/_index.md#creating-a-cluster-layout). Use the following command to access garage CLI:
 
 ```bash
@@ -93,62 +86,3 @@ helm delete --namespace garage garage
 ```
 
 Note that this will leave behind custom CRD `garagenodes.deuxfleurs.fr`, which must be removed manually if desired.
-
-## Increase PVC size on running Garage instances
-
-Since the Garage Helm chart creates the data and meta PVC based on `StatefulSet` templates, increasing the PVC size can be a bit tricky.
-
-### Confirm the `StorageClass` used for Garage supports volume expansion
-
-Confirm the storage class used for garage.
-
-```bash
-kubectl -n garage get pvc 
-NAME            STATUS   VOLUME                                     CAPACITY   ACCESS MODES   STORAGECLASS     VOLUMEATTRIBUTESCLASS   AGE
-data-garage-0   Bound    pvc-080360c9-8ce3-4acf-8579-1701e57b7f3f   30Gi       RWO            longhorn-local   <unset>                 77d
-data-garage-1   Bound    pvc-ab8ba697-6030-4fc7-ab3c-0d6df9e3dbc0   30Gi       RWO            longhorn-local   <unset>                 5d8h
-data-garage-2   Bound    pvc-3ab37551-0231-4604-986d-136d0fd950ec   30Gi       RWO            longhorn-local   <unset>                 5d5h
-meta-garage-0   Bound    pvc-3b457302-3023-4169-846e-c928c5f2ea65   3Gi        RWO            longhorn-local   <unset>                 77d
-meta-garage-1   Bound    pvc-49ace2b9-5c85-42df-9247-51c4cf64b460   3Gi        RWO            longhorn-local   <unset>                 5d8h
-meta-garage-2   Bound    pvc-99e2e50f-42b4-4128-ae2f-b52629259723   3Gi        RWO            longhorn-local   <unset>                 5d5h
-```
-
-In this case, the storage class is `longhorn-local`. Now, check if `ALLOWVOLUMEEXPANSION` is true for the used `StorageClass`.
-
-```bash
-kubectl get storageclasses.storage.k8s.io longhorn-local
-NAME             PROVISIONER          RECLAIMPOLICY   VOLUMEBINDINGMODE   ALLOWVOLUMEEXPANSION   AGE
-longhorn-local   driver.longhorn.io   Delete          Immediate           true                   103d
-```
-
-If your `StorageClass` does not support volume expansion, double check if you can enable it. Otherwise, your only real option is to spin up a new Garage cluster with increased size and migrate all data over.
-
-If your `StorageClass` supports expansion, you are free to continue.
-
-### Increase the size of the PVCs
-
-Increase the size of all PVCs to your desired size.
-
-```bash
-kubectl -n garage edit pvc data-garage-0
-kubectl -n garage edit pvc data-garage-1
-kubectl -n garage edit pvc data-garage-2
-kubectl -n garage edit pvc meta-garage-0
-kubectl -n garage edit pvc meta-garage-1
-kubectl -n garage edit pvc meta-garage-2
-```
-
-### Increase the size of the `StatefulSet` PVC template
-
-This is an optional step, but if not done, future instances of Garage will be created with the original size from the template.
-
-```bash
-kubectl -n garage delete sts --cascade=orphan garage 
-statefulset.apps "garage" deleted
-```
-
-This will remove the Garage `StatefulSet` but leave the pods running. It may seem destructive but needs to be done this way since edits to the size of PVC templates are prohibited.
-
-### Redeploy the `StatefulSet`
-
-Now the size of future PVCs can be increased, and the Garage Helm chart can be upgraded. The new `StatefulSet` should take ownership of the orphaned pods again.

doc/book/cookbook/real-world.md

@@ -96,14 +96,14 @@ to store 2 TB of data in total.
 ## Get a Docker image
 
 Our docker image is currently named `dxflrs/garage` and is stored on the [Docker Hub](https://hub.docker.com/r/dxflrs/garage/tags?page=1&ordering=last_updated).
-We encourage you to use a fixed tag (eg. `v1.2.0`) and not the `latest` tag.
+We encourage you to use a fixed tag (eg. `v1.1.0`) and not the `latest` tag.
-For this example, we will use the latest published version at the time of the writing which is `v1.2.0` but it's up to you
+For this example, we will use the latest published version at the time of the writing which is `v1.1.0` but it's up to you
 to check [the most recent versions on the Docker Hub](https://hub.docker.com/r/dxflrs/garage/tags?page=1&ordering=last_updated).
 
 For example:
 
 ```
-sudo docker pull dxflrs/garage:v1.2.0
+sudo docker pull dxflrs/garage:v1.1.0
 ```
 
 ## Deploying and configuring Garage
@@ -171,7 +171,7 @@ docker run \
   -v /etc/garage.toml:/etc/garage.toml \
   -v /var/lib/garage/meta:/var/lib/garage/meta \
   -v /var/lib/garage/data:/var/lib/garage/data \
-  dxflrs/garage:v1.2.0
+  dxflrs/garage:v1.1.0
 ```
 
 With this command line, Garage should be started automatically at each boot.
@@ -185,7 +185,7 @@ If you want to use `docker-compose`, you may use the following `docker-compose.y
 version: "3"
 services:
   garage:
-    image: dxflrs/garage:v1.2.0
+    image: dxflrs/garage:v1.1.0
     network_mode: "host"
     restart: unless-stopped
     volumes:

doc/book/cookbook/systemd.md

@@ -28,7 +28,6 @@ StateDirectory=garage
 DynamicUser=true
 ProtectHome=true
 NoNewPrivileges=true
-LimitNOFILE=42000
 
 [Install]
 WantedBy=multi-user.target

doc/book/quick-start/_index.md

@@ -129,10 +129,10 @@ docker run \
   -d \
   --name garaged \
   -p 3900:3900 -p 3901:3901 -p 3902:3902 -p 3903:3903 \
-  -v /path/to/garage.toml:/etc/garage.toml \
+  -v /etc/garage.toml:/path/to/garage.toml \
-  -v /path/to/garage/meta:/var/lib/garage/meta \
+  -v /var/lib/garage/meta:/path/to/garage/meta \
-  -v /path/to/garage/data:/var/lib/garage/data \
+  -v /var/lib/garage/data:/path/to/garage/data \
-  dxflrs/garage:v1.2.0
+  dxflrs/garage:v1.1.0
 ```
 
 Under Linux, you can substitute `--network host` for `-p 3900:3900 -p 3901:3901 -p 3902:3902 -p 3903:3903`
@@ -182,12 +182,11 @@ ID                 Hostname  Address         Tag                   Zone  Capacit
 ## Creating a cluster layout
 
 Creating a cluster layout for a Garage deployment means informing Garage
-of the disk space available on each node of the cluster, `-c`,
+of the disk space available on each node of the cluster
-as well as the name of the zone (e.g. datacenter), `-z`, each machine is located in.
+as well as the zone (e.g. datacenter) each machine is located in.
 
-For our test deployment, we are have only one node with zone named `dc1` and a
+For our test deployment, we are using only one node. The way in which we configure
-capacity of `1G`, though the capacity is ignored for a single node deployment
+it does not matter, you can simply write:
-and can be changed later when adding new nodes.
 
 ```bash
 garage layout assign -z dc1 -c 1G <node_id>

doc/book/reference-manual/configuration.md

@@ -46,7 +46,6 @@ bootstrap_peers = [
     "212fd62eeaca72c122b45a7f4fa0f55e012aa5e24ac384a72a3016413fa724ff@[fc00:F::1]:3901",
 ]
 
-allow_punycode = false
 
 [consul_discovery]
 api = "catalog"
@@ -93,30 +92,29 @@ The following gives details about each available configuration option.
 
 [Environment variables](#env_variables).
 
-Top-level configuration options, in alphabetical order:
+Top-level configuration options:
-[`allow_punycode`](#allow_punycode),
 [`allow_world_readable_secrets`](#allow_world_readable_secrets),
 [`block_ram_buffer_max`](#block_ram_buffer_max),
 [`block_size`](#block_size),
 [`bootstrap_peers`](#bootstrap_peers),
 [`compression_level`](#compression_level),
-[`consistency_mode`](#consistency_mode),
 [`data_dir`](#data_dir),
 [`data_fsync`](#data_fsync),
 [`db_engine`](#db_engine),
 [`disable_scrub`](#disable_scrub),
+[`use_local_tz`](#use_local_tz),
 [`lmdb_map_size`](#lmdb_map_size),
 [`metadata_auto_snapshot_interval`](#metadata_auto_snapshot_interval),
 [`metadata_dir`](#metadata_dir),
 [`metadata_fsync`](#metadata_fsync),
 [`metadata_snapshots_dir`](#metadata_snapshots_dir),
 [`replication_factor`](#replication_factor),
+[`consistency_mode`](#consistency_mode),
 [`rpc_bind_addr`](#rpc_bind_addr),
 [`rpc_bind_outgoing`](#rpc_bind_outgoing),
 [`rpc_public_addr`](#rpc_public_addr),
 [`rpc_public_addr_subnet`](#rpc_public_addr_subnet)
-[`rpc_secret`/`rpc_secret_file`](#rpc_secret),
+[`rpc_secret`/`rpc_secret_file`](#rpc_secret).
-[`use_local_tz`](#use_local_tz).
 
 The `[consul_discovery]` section:
 [`api`](#consul_api),
@@ -153,17 +151,13 @@ The `[admin]` section:
 
 ### Environment variables {#env_variables}
 
-The following configuration parameters must be specified as environment variables,
+The following configuration parameter must be specified as an environment
-they do not exist in the configuration file:
+variable, it does not exist in the configuration file:
 
 - `GARAGE_LOG_TO_SYSLOG` (since `v0.9.4`): set this to `1` or `true` to make the
   Garage daemon send its logs to `syslog` (using the libc `syslog` function)
   instead of printing to stderr.
 
-- `GARAGE_LOG_TO_JOURNALD` (since `v1.2.0`): set this to `1` or `true` to make the
-  Garage daemon send its logs to `journald` (using the native protocol of `systemd-journald`)
-  instead of printing to stderr.
-
 The following environment variables can be used to override the corresponding
 values in the configuration file:
 
@@ -175,7 +169,7 @@ values in the configuration file:
 
 ### Top-level configuration options
 
-#### `replication_factor` (since `v1.0.0`) {#replication_factor}
+#### `replication_factor` {#replication_factor}
 
 The replication factor can be any positive integer smaller or equal the node count in your cluster.
 The chosen replication factor has a big impact on the cluster's failure tolerancy and performance characteristics.
@@ -223,7 +217,7 @@ is in progress.  In theory, no data should be lost as rebalancing is a
 routine operation for Garage, although we cannot guarantee you that everything
  will go right in such an extreme scenario.
 
-#### `consistency_mode` (since `v1.0.0`) {#consistency_mode}
+#### `consistency_mode` {#consistency_mode}
 
 The consistency mode setting determines the read and write behaviour of your cluster.
 
@@ -333,7 +327,6 @@ Since `v0.8.0`, Garage can use alternative storage backends as follows:
 | --------- | ----------------- | ------------- |
 | [LMDB](https://www.symas.com/lmdb) (since `v0.8.0`, default since `v0.9.0`) | `"lmdb"` | `<metadata_dir>/db.lmdb/` |
 | [Sqlite](https://sqlite.org) (since `v0.8.0`) | `"sqlite"` | `<metadata_dir>/db.sqlite` |
-| [Fjall](https://github.com/fjall-rs/fjall) (**experimental support** since `v1.3.0`) | `"fjall"` | `<metadata_dir>/db.fjall/` |
 | [Sled](https://sled.rs) (old default, removed since `v1.0`) | `"sled"` | `<metadata_dir>/db/` |
 
 Sled was supported until Garage v0.9.x, and was removed in Garage v1.0.
@@ -370,14 +363,6 @@ LMDB works very well, but is known to have the following limitations:
   so it is not the best choice for high-performance storage clusters,
   but it should work fine in many cases.
 
-- Fjall: a storage engine based on LSM trees, which theoretically allow for
-  higher write throughput than other storage engines that are based on B-trees.
-  Using Fjall could potentially improve Garage's performance significantly in
-  write-heavy workloads. **Support for Fjall is experimental at this point**,
-  we have added it to Garage for evaluation purposes only. **Do not use it for
-  production-critical workloads.**
-
-
 It is possible to convert Garage's metadata directory from one format to another
 using the `garage convert-db` command, which should be used as follows:
 
@@ -415,7 +400,6 @@ Here is how this option impacts the different database engines:
 |----------|------------------------------------|-------------------------------|
 | Sqlite   | `PRAGMA synchronous = OFF`         | `PRAGMA synchronous = NORMAL` |
 | LMDB     | `MDB_NOMETASYNC` + `MDB_NOSYNC`    | `MDB_NOMETASYNC`              |
-| Fjall    | default options                    | not supported                 |
 
 Note that the Sqlite database is always ran in `WAL` mode (`PRAGMA journal_mode = WAL`).
 
@@ -620,7 +604,7 @@ be obtained by running `garage node id` and then included directly in the
 key will be returned by `garage node id` and you will have to add the IP
 yourself.
 
-#### `allow_world_readable_secrets` or `GARAGE_ALLOW_WORLD_READABLE_SECRETS` (env) {#allow_world_readable_secrets}
+### `allow_world_readable_secrets` or `GARAGE_ALLOW_WORLD_READABLE_SECRETS` (env) {#allow_world_readable_secrets}
 
 Garage checks the permissions of your secret files to make sure they're not
 world-readable. In some cases, the check might fail and consider your files as
@@ -632,13 +616,6 @@ permission verification.
 Alternatively, you can set the `GARAGE_ALLOW_WORLD_READABLE_SECRETS`
 environment variable to `true` to bypass the permissions check.
 
-#### `allow_punycode` {#allow_punycode}
-
-Allow creating buckets with names containing punycode. When used for buckets served
-as websites, this allows using almost any unicode character in the domain name.
-
-Default to `false`.
-
 ### The `[consul_discovery]` section
 
 Garage supports discovering other nodes of the cluster using Consul.  For this

doc/book/reference-manual/s3-compatibility.md

@@ -23,6 +23,7 @@ Feel free to open a PR to suggest fixes this table. Minio is missing because the
 - 2022-05-25 - Many Ceph S3 endpoints are not documented but implemented. Following a notification from the Ceph community, we added them.
 
 
+
 ## High-level features
 
 | Feature                      | Garage                           | [Openstack Swift](https://docs.openstack.org/swift/latest/s3_compat.html) | [Ceph Object Gateway](https://docs.ceph.com/en/latest/radosgw/s3/) | [Riak CS](https://docs.riak.com/riak/cs/2.1.1/references/apis/storage/s3/index.html) | [OpenIO](https://docs.openio.io/latest/source/arch-design/s3_compliancy.html) |
@@ -33,7 +34,6 @@ Feel free to open a PR to suggest fixes this table. Minio is missing because the
 | [URL vhost-style](https://docs.aws.amazon.com/AmazonS3/latest/userguide/VirtualHosting.html#virtual-hosted-style-access) URL (eg. `bucket.host.tld/key`) |  ✅ Implemented | ❌| ✅| ✅ | ✅ |
 | [Presigned URLs](https://docs.aws.amazon.com/AmazonS3/latest/userguide/ShareObjectPreSignedURL.html) |  ✅ Implemented | ❌|  ✅ | ✅ |  ✅(❓) |
 | [SSE-C encryption](https://docs.aws.amazon.com/AmazonS3/latest/userguide/ServerSideEncryptionCustomerKeys.html) |  ✅ Implemented | ❓ |  ✅ | ❌ |  ✅ |
-| [Bucket versioning](https://docs.aws.amazon.com/AmazonS3/latest/userguide/Versioning.html) | ❌ Missing | ✅ |  ✅ | ❌ | ✅ |
 
 *Note:* OpenIO does not says if it supports presigned URLs. Because it is part
 of signature v4 and they claim they support it without additional precisions,

doc/drafts/admin-api.md

@@ -70,7 +70,7 @@ Example response body:
 ```json
 {
   "node": "b10c110e4e854e5aa3f4637681befac755154b20059ec163254ddbfae86b09df",
-  "garageVersion": "v1.2.0",
+  "garageVersion": "v1.1.0",
   "garageFeatures": [
     "k2v",
     "lmdb",

flake.nix

@@ -53,9 +53,6 @@
           tests-sqlite = testWith {
             GARAGE_TEST_INTEGRATION_DB_ENGINE = "sqlite";
           };
-          tests-fjall = testWith {
-            GARAGE_TEST_INTEGRATION_DB_ENGINE = "fjall";
-          };
         };
 
         # ---- developpment shell, for making native builds only ----

nix/compile.nix

@@ -68,13 +68,12 @@ let
   rootFeatures = if features != null then
     features
   else
-    ([ "bundled-libs" "lmdb" "sqlite" "fjall" "k2v" ] ++ (lib.optionals release [
+    ([ "bundled-libs" "lmdb" "sqlite" "k2v" ] ++ (lib.optionals release [
       "consul-discovery"
       "kubernetes-discovery"
       "metrics"
       "telemetry-otlp"
       "syslog"
-      "journald"
     ]));
 
   featuresStr = lib.concatStringsSep "," rootFeatures;

script/helm/garage/Chart.yaml

@@ -1,18 +1,24 @@
 apiVersion: v2
 name: garage
 description: S3-compatible object store for small self-hosted geo-distributed deployments
+
+# A chart can be either an 'application' or a 'library' chart.
+#
+# Application charts are a collection of templates that can be packaged into versioned archives
+# to be deployed.
+#
+# Library charts provide useful utilities or functions for the chart developer. They're included as
+# a dependency of application charts to inject those utilities and functions into the rendering
+# pipeline. Library charts do not define any templates and therefore cannot be deployed.
 type: application
-version: 0.7.1
-appVersion: "v1.2.0"
-home: https://garagehq.deuxfleurs.fr/
-icon: https://garagehq.deuxfleurs.fr/images/garage-logo.svg
 
-keywords:
+# This is the chart version. This version number should be incremented each time you make changes
-- geo-distributed
+# to the chart and its templates, including the app version.
-- read-after-write-consistency
+# Versions are expected to follow Semantic Versioning (https://semver.org/)
-- s3-compatible
+version: 0.7.0
 
-sources:
+# This is the version number of the application being deployed. This version number should be
-- https://git.deuxfleurs.fr/Deuxfleurs/garage.git
+# incremented each time you make changes to the application. Versions are not expected to
-
+# follow Semantic Versioning. They should reflect the version the application is using.
-maintainers: []
+# It is recommended to use it with quotes.
+appVersion: "v1.1.0"

script/helm/garage/README.md

@@ -1,15 +1,9 @@
 # garage
 
-![Version: 0.7.1](https://img.shields.io/badge/Version-0.7.1-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: v1.2.0](https://img.shields.io/badge/AppVersion-v1.2.0-informational?style=flat-square)
+![Version: 0.6.0](https://img.shields.io/badge/Version-0.6.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: v1.0.1](https://img.shields.io/badge/AppVersion-v1.0.1-informational?style=flat-square)
 
 S3-compatible object store for small self-hosted geo-distributed deployments
 
-**Homepage:** <https://garagehq.deuxfleurs.fr/>
-
-## Source Code
-
-* <https://git.deuxfleurs.fr/Deuxfleurs/garage.git>
-
 ## Values
 
 | Key | Type | Default | Description |
@@ -29,7 +23,6 @@ S3-compatible object store for small self-hosted geo-distributed deployments
 | garage.existingConfigMap | string | `""` | if not empty string, allow using an existing ConfigMap for the garage.toml, if set, ignores garage.toml |
 | garage.garageTomlString | string | `""` | String Template for the garage configuration if set, ignores above values. Values can be templated, see https://garagehq.deuxfleurs.fr/documentation/reference-manual/configuration/ |
 | garage.kubernetesSkipCrd | bool | `false` | Set to true if you want to use k8s discovery but install the CRDs manually outside of the helm chart, for example if you operate at namespace level without cluster ressources |
-| garage.metadataAutoSnapshotInterval | string | `""` | If this value is set, Garage will automatically take a snapshot of the metadata DB file at a regular interval and save it in the metadata directory. https://garagehq.deuxfleurs.fr/documentation/reference-manual/configuration/#metadata_auto_snapshot_interval |
 | garage.replicationMode | string | `"3"` | Default to 3 replicas, see the replication_mode section at https://garagehq.deuxfleurs.fr/documentation/reference-manual/configuration/#replication-mode |
 | garage.rpcBindAddr | string | `"[::]:3901"` |  |
 | garage.rpcSecret | string | `""` | If not given, a random secret will be generated and stored in a Secret object |
@@ -56,7 +49,6 @@ S3-compatible object store for small self-hosted geo-distributed deployments
 | initImage.pullPolicy | string | `"IfNotPresent"` |  |
 | initImage.repository | string | `"busybox"` |  |
 | initImage.tag | string | `"stable"` |  |
-| livenessProbe | object | `{}` | Specifies a livenessProbe |
 | monitoring.metrics.enabled | bool | `false` | If true, a service for monitoring is created with a prometheus.io/scrape annotation |
 | monitoring.metrics.serviceMonitor.enabled | bool | `false` | If true, a ServiceMonitor CRD is created for a prometheus operator https://github.com/coreos/prometheus-operator |
 | monitoring.metrics.serviceMonitor.interval | string | `"15s"` |  |
@@ -79,7 +71,6 @@ S3-compatible object store for small self-hosted geo-distributed deployments
 | podSecurityContext.runAsGroup | int | `1000` |  |
 | podSecurityContext.runAsNonRoot | bool | `true` |  |
 | podSecurityContext.runAsUser | int | `1000` |  |
-| readinessProbe | object | `{}` | Specifies a readinessProbe |
 | resources | object | `{}` |  |
 | securityContext.capabilities | object | `{"drop":["ALL"]}` | The default security context is heavily restricted, feel free to tune it to your requirements |
 | securityContext.readOnlyRootFilesystem | bool | `true` |  |

script/helm/garage/templates/configmap.yaml

@@ -19,10 +19,6 @@ data:
 
     compression_level = {{ .Values.garage.compressionLevel }}
 
-    {{- if .Values.garage.metadataAutoSnapshotInterval }}
-    metadata_auto_snapshot_interval = {{ .Values.garage.metadataAutoSnapshotInterval | quote }}
-    {{- end }}
-
     rpc_bind_addr = "{{ .Values.garage.rpcBindAddr }}"
     # rpc_secret will be populated by the init container from a k8s secret object
     rpc_secret = "__RPC_SECRET_REPLACE__"

script/helm/garage/templates/workload.yaml

@@ -78,14 +78,15 @@ spec:
           {{- with .Values.extraVolumeMounts }}
             {{- toYaml . | nindent 12 }}
           {{- end }}
-          {{- with .Values.livenessProbe }}
+          # TODO
-          livenessProbe:
+          # livenessProbe:
-            {{- toYaml . | nindent 12 }}
+          #   httpGet:
-          {{- end }}
+          #     path: /
-          {{- with .Values.readinessProbe }}
+          #     port: 3900
-          readinessProbe:
+          # readinessProbe:
-            {{- toYaml . | nindent 12 }}
+          #   httpGet:
-          {{- end }}
+          #     path: /
+          #     port: 3900
           resources:
             {{- toYaml .Values.resources | nindent 12 }}
       volumes:

script/helm/garage/values.yaml

@@ -21,10 +21,6 @@ garage:
   # https://garagehq.deuxfleurs.fr/documentation/reference-manual/configuration/#compression-level
   compressionLevel: "1"
 
-  # -- If this value is set, Garage will automatically take a snapshot of the metadata DB file at a regular interval and save it in the metadata directory.
-  # https://garagehq.deuxfleurs.fr/documentation/reference-manual/configuration/#metadata_auto_snapshot_interval
-  metadataAutoSnapshotInterval: ""
-
   rpcBindAddr: "[::]:3901"
   # -- If not given, a random secret will be generated and stored in a Secret object
   rpcSecret: ""
@@ -195,21 +191,6 @@ resources: {}
   #   cpu: 100m
   #   memory: 512Mi
 
-# -- Specifies a livenessProbe
-livenessProbe: {}
-  #httpGet:
-  #  path: /health
-  #  port: 3903
-  #initialDelaySeconds: 5
-  #periodSeconds: 30
-# -- Specifies a readinessProbe
-readinessProbe: {}
-  #httpGet:
-  #  path: /health
-  #  port: 3903
-  #initialDelaySeconds: 5
-  #periodSeconds: 30
-
 nodeSelector: {}
 
 tolerations: []

script/k8s/crd/garagenodes.deuxfleurs.fr.yaml

@@ -1,43 +0,0 @@
-apiVersion: apiextensions.k8s.io/v1
-kind: CustomResourceDefinition
-metadata:
-  name: garagenodes.deuxfleurs.fr
-spec:
-  conversion:
-    strategy: None
-  group: deuxfleurs.fr
-  names:
-    kind: GarageNode
-    listKind: GarageNodeList
-    plural: garagenodes
-    singular: garagenode
-  scope: Namespaced
-  versions:
-  - name: v1
-    schema:
-      openAPIV3Schema:
-        description: Auto-generated derived type for Node via `CustomResource`
-        properties:
-          spec:
-            properties:
-              address:
-                format: ip
-                type: string
-              hostname:
-                type: string
-              port:
-                format: uint16
-                minimum: 0
-                type: integer
-            required:
-            - address
-            - hostname
-            - port
-            type: object
-        required:
-        - spec
-        title: GarageNode
-        type: object
-    served: true
-    storage: true
-    subresources: {}

script/k8s/crd/kustomization.yaml

@@ -1,5 +0,0 @@
-apiVersion: kustomize.config.k8s.io/v1beta1
-kind: Kustomization
-
-resources:
-- garagenodes.deuxfleurs.fr.yaml

src/api/admin/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "garage_api_admin"
-version = "1.2.0"
+version = "1.1.0"
 authors = ["Alex Auvolat <alex@adnab.me>"]
 edition = "2018"
 license = "AGPL-3.0"

src/api/admin/bucket.rs

@@ -277,7 +277,7 @@ pub async fn handle_create_bucket(
 	let helper = garage.locked_helper().await;
 
 	if let Some(ga) = &req.global_alias {
-		if !is_valid_bucket_name(ga, garage.config.allow_punycode) {
+		if !is_valid_bucket_name(ga) {
 			return Err(Error::bad_request(format!(
 				"{}: {}",
 				ga, INVALID_BUCKET_NAME_MESSAGE
@@ -292,7 +292,7 @@ pub async fn handle_create_bucket(
 	}
 
 	if let Some(la) = &req.local_alias {
-		if !is_valid_bucket_name(&la.alias, garage.config.allow_punycode) {
+		if !is_valid_bucket_name(&la.alias) {
 			return Err(Error::bad_request(format!(
 				"{}: {}",
 				la.alias, INVALID_BUCKET_NAME_MESSAGE
@@ -382,7 +382,7 @@ pub async fn handle_delete_bucket(
 	for ((key_id, alias), _, active) in state.local_aliases.items().iter() {
 		if *active {
 			helper
-				.purge_local_bucket_alias(bucket.id, key_id, alias)
+				.unset_local_bucket_alias(bucket.id, key_id, alias)
 				.await?;
 		}
 	}
@@ -419,11 +419,17 @@ pub async fn handle_update_bucket(
 
 	if let Some(wa) = req.website_access {
 		if wa.enabled {
+			let (redirect_all, routing_rules) = match state.website_config.get() {
+				Some(wc) => (wc.redirect_all.clone(), wc.routing_rules.clone()),
+				None => (None, Vec::new()),
+			};
 			state.website_config.update(Some(WebsiteConfig {
 				index_document: wa.index_document.ok_or_bad_request(
 					"Please specify indexDocument when enabling website access.",
 				)?,
 				error_document: wa.error_document,
+				redirect_all,
+				routing_rules,
 			}));
 		} else {
 			if wa.index_document.is_some() || wa.error_document.is_some() {

src/api/common/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "garage_api_common"
-version = "1.2.0"
+version = "1.1.0"
 authors = ["Alex Auvolat <alex@adnab.me>"]
 edition = "2018"
 license = "AGPL-3.0"
@@ -28,6 +28,7 @@ err-derive.workspace = true
 hex.workspace = true
 hmac.workspace = true
 md-5.workspace = true
+idna.workspace = true
 tracing.workspace = true
 nom.workspace = true
 pin-project.workspace = true

src/api/common/generic_server.rs

@@ -33,7 +33,6 @@ use garage_util::metrics::{gen_trace_id, RecordDuration};
 use garage_util::socket_address::UnixOrTCPSocketAddress;
 
 use crate::helpers::{BoxBody, ErrorBody};
-use crate::signature::payload::Authorization;
 
 pub trait ApiEndpoint: Send + Sync + 'static {
 	fn name(&self) -> &'static str;
@@ -59,12 +58,6 @@ pub trait ApiHandler: Send + Sync + 'static {
 		req: Request<IncomingBody>,
 		endpoint: Self::Endpoint,
 	) -> impl Future<Output = Result<Response<BoxBody<Self::Error>>, Self::Error>> + Send;
-
-	/// Returns the key id used to authenticate this request. The ID returned must be safe to
-	/// log.
-	fn key_id_from_request(&self, req: &Request<IncomingBody>) -> Option<String> {
-		None
-	}
 }
 
 pub struct ApiServer<A: ApiHandler> {
@@ -149,20 +142,19 @@ impl<A: ApiHandler> ApiServer<A> {
 	) -> Result<Response<BoxBody<A::Error>>, http::Error> {
 		let uri = req.uri().clone();
 
-		let source = if let Ok(forwarded_for_ip_addr) =
+		if let Ok(forwarded_for_ip_addr) =
 			forwarded_headers::handle_forwarded_for_headers(req.headers())
 		{
-			format!("{forwarded_for_ip_addr} (via {addr})")
+			info!(
+				"{} (via {}) {} {}",
+				forwarded_for_ip_addr,
+				addr,
+				req.method(),
+				uri
+			);
 		} else {
-			format!("{addr}")
+			info!("{} {} {}", addr, req.method(), uri);
-		};
+		}
-		// we only do this to log the access key, so we can discard any error
-		let key = self
-			.api_handler
-			.key_id_from_request(&req)
-			.map(|k| format!("(key {k}) "))
-			.unwrap_or_default();
-		info!("{source} {key}{} {uri}", req.method());
 		debug!("{:?}", req);
 
 		let tracer = opentelemetry::global::tracer("garage");
@@ -351,11 +343,7 @@ where
 
 	while !*must_exit.borrow() {
 		let (stream, client_addr) = tokio::select! {
-			acc = listener.accept() => match acc {
+			acc = listener.accept() => acc?,
-							Ok(r) => r,
-							Err(e) if e.kind() == std::io::ErrorKind::ConnectionAborted => continue,
-							Err(e) => return Err(e.into()),
-						},
 			_ = must_exit.changed() => continue,
 		};
 

src/api/common/helpers.rs

@@ -8,6 +8,7 @@ use hyper::{
 	body::{Body, Bytes},
 	Request, Response,
 };
+use idna::domain_to_unicode;
 use serde::{Deserialize, Serialize};
 
 use garage_model::bucket_table::BucketParams;
@@ -96,7 +97,7 @@ pub fn authority_to_host(authority: &str) -> Result<String, Error> {
 			authority
 		))),
 	};
-	authority.map(|h| h.to_ascii_lowercase())
+	authority.map(|h| domain_to_unicode(h).0)
 }
 
 /// Extract the bucket name and the key name from an HTTP path and possibly a bucket provided in

src/api/common/signature/payload.rs

@@ -417,7 +417,7 @@ pub async fn verify_v4(
 // ============ Authorization header, or X-Amz-* query params =========
 
 pub struct Authorization {
-	pub key_id: String,
+	key_id: String,
 	scope: String,
 	signed_headers: String,
 	signature: String,
@@ -426,7 +426,7 @@ pub struct Authorization {
 }
 
 impl Authorization {
-	pub fn parse_header(headers: &HeaderMap) -> Result<Self, Error> {
+	fn parse_header(headers: &HeaderMap) -> Result<Self, Error> {
 		let authorization = headers
 			.get(AUTHORIZATION)
 			.ok_or_bad_request("Missing authorization header")?

src/api/k2v/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "garage_api_k2v"
-version = "1.2.0"
+version = "1.1.0"
 authors = ["Alex Auvolat <alex@adnab.me>"]
 edition = "2018"
 license = "AGPL-3.0"

src/api/k2v/api_server.rs

@@ -176,12 +176,6 @@ impl ApiHandler for K2VApiServer {
 
 		Ok(resp_ok)
 	}
-
-	fn key_id_from_request(&self, req: &Request<IncomingBody>) -> Option<String> {
-		garage_api_common::signature::payload::Authorization::parse_header(req.headers())
-			.map(|auth| auth.key_id)
-			.ok()
-	}
 }
 
 impl ApiEndpoint for K2VApiEndpoint {

src/api/s3/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "garage_api_s3"
-version = "1.2.0"
+version = "1.1.0"
 authors = ["Alex Auvolat <alex@adnab.me>"]
 edition = "2018"
 license = "AGPL-3.0"

src/api/s3/api_server.rs

@@ -226,7 +226,6 @@ impl ApiHandler for S3ApiServer {
 			Endpoint::DeleteBucket {} => handle_delete_bucket(ctx).await,
 			Endpoint::GetBucketLocation {} => handle_get_bucket_location(ctx),
 			Endpoint::GetBucketVersioning {} => handle_get_bucket_versioning(),
-			Endpoint::GetBucketAcl {} => handle_get_bucket_acl(ctx),
 			Endpoint::ListObjects {
 				delimiter,
 				encoding_type,
@@ -343,12 +342,6 @@ impl ApiHandler for S3ApiServer {
 
 		Ok(resp_ok)
 	}
-
-	fn key_id_from_request(&self, req: &Request<IncomingBody>) -> Option<String> {
-		garage_api_common::signature::payload::Authorization::parse_header(req.headers())
-			.map(|auth| auth.key_id)
-			.ok()
-	}
 }
 
 impl ApiEndpoint for S3ApiEndpoint {

src/api/s3/bucket.rs

@@ -5,7 +5,7 @@ use hyper::{Request, Response, StatusCode};
 use garage_model::bucket_alias_table::*;
 use garage_model::bucket_table::Bucket;
 use garage_model::garage::Garage;
-use garage_model::key_table::{Key, KeyParams};
+use garage_model::key_table::Key;
 use garage_model::permission::BucketKeyPerm;
 use garage_table::util::*;
 use garage_util::crdt::*;
@@ -44,55 +44,6 @@ pub fn handle_get_bucket_versioning() -> Result<Response<ResBody>, Error> {
 		.body(string_body(xml))?)
 }
 
-pub fn handle_get_bucket_acl(ctx: ReqCtx) -> Result<Response<ResBody>, Error> {
-	let ReqCtx {
-		bucket_id, api_key, ..
-	} = ctx;
-	let key_p = api_key.params().ok_or_internal_error(
-		"Key should not be in deleted state at this point (in handle_get_bucket_acl)",
-	)?;
-
-	let mut grants: Vec<s3_xml::Grant> = vec![];
-	let kp = api_key.bucket_permissions(&bucket_id);
-
-	if kp.allow_owner {
-		grants.push(s3_xml::Grant {
-			grantee: create_grantee(&key_p, &api_key),
-			permission: s3_xml::Value("FULL_CONTROL".to_string()),
-		});
-	} else {
-		if kp.allow_read {
-			grants.push(s3_xml::Grant {
-				grantee: create_grantee(&key_p, &api_key),
-				permission: s3_xml::Value("READ".to_string()),
-			});
-			grants.push(s3_xml::Grant {
-				grantee: create_grantee(&key_p, &api_key),
-				permission: s3_xml::Value("READ_ACP".to_string()),
-			});
-		}
-		if kp.allow_write {
-			grants.push(s3_xml::Grant {
-				grantee: create_grantee(&key_p, &api_key),
-				permission: s3_xml::Value("WRITE".to_string()),
-			});
-		}
-	}
-
-	let access_control_policy = s3_xml::AccessControlPolicy {
-		xmlns: (),
-		owner: None,
-		acl: s3_xml::AccessControlList { entries: grants },
-	};
-
-	let xml = s3_xml::to_xml_with_header(&access_control_policy)?;
-	trace!("xml: {}", xml);
-
-	Ok(Response::builder()
-		.header("Content-Type", "application/xml")
-		.body(string_body(xml))?)
-}
-
 pub async fn handle_list_buckets(
 	garage: &Garage,
 	api_key: &Key,
@@ -221,7 +172,7 @@ pub async fn handle_create_bucket(
 		}
 
 		// Create the bucket!
-		if !is_valid_bucket_name(&bucket_name, garage.config.allow_punycode) {
+		if !is_valid_bucket_name(&bucket_name) {
 			return Err(Error::bad_request(format!(
 				"{}: {}",
 				bucket_name, INVALID_BUCKET_NAME_MESSAGE
@@ -290,11 +241,11 @@ pub async fn handle_delete_bucket(ctx: ReqCtx) -> Result<Response<ResBody>, Erro
 		// 1. delete bucket alias
 		if is_local_alias {
 			helper
-				.purge_local_bucket_alias(*bucket_id, &api_key.key_id, bucket_name)
+				.unset_local_bucket_alias(*bucket_id, &api_key.key_id, bucket_name)
 				.await?;
 		} else {
 			helper
-				.purge_global_bucket_alias(*bucket_id, bucket_name)
+				.unset_global_bucket_alias(*bucket_id, bucket_name)
 				.await?;
 		}
 
@@ -360,15 +311,6 @@ fn parse_create_bucket_xml(xml_bytes: &[u8]) -> Option<Option<String>> {
 	Some(ret)
 }
 
-fn create_grantee(key_params: &KeyParams, api_key: &Key) -> s3_xml::Grantee {
-	s3_xml::Grantee {
-		xmlns_xsi: (),
-		typ: "CanonicalUser".to_string(),
-		display_name: Some(s3_xml::Value(key_params.name.get().to_string())),
-		id: Some(s3_xml::Value(api_key.key_id.to_string())),
-	}
-}
-
 #[cfg(test)]
 mod tests {
 	use super::*;

src/api/s3/copy.rs

@@ -26,10 +26,9 @@ use garage_api_common::signature::checksum::*;
 use crate::api_server::{ReqBody, ResBody};
 use crate::encryption::EncryptionParams;
 use crate::error::*;
-use crate::get::{check_version_not_deleted, full_object_byte_stream, PreconditionHeaders};
+use crate::get::{full_object_byte_stream, PreconditionHeaders};
 use crate::multipart;
 use crate::put::{extract_metadata_headers, save_stream, ChecksumMode, SaveStreamResult};
-use crate::website::X_AMZ_WEBSITE_REDIRECT_LOCATION;
 use crate::xml::{self as s3_xml, xmlns_tag};
 
 pub const X_AMZ_COPY_SOURCE_IF_MATCH: HeaderName =
@@ -85,18 +84,7 @@ pub async fn handle_copy(
 			Some(v) if v == hyper::header::HeaderValue::from_static("REPLACE") => {
 				extract_metadata_headers(req.headers())?
 			}
-			_ => {
+			_ => source_object_meta_inner.into_owned().headers,
-				// The x-amz-website-redirect-location header is not copied, instead
-				// it is replaced by the value from the request (or removed if no
-				// value was specified)
-				let is_redirect =
-					|(key, _): &(String, String)| key == X_AMZ_WEBSITE_REDIRECT_LOCATION.as_str();
-				let mut headers: Vec<_> = source_object_meta_inner.headers.clone();
-				headers.retain(|h| !is_redirect(h));
-				let new_headers = extract_metadata_headers(req.headers())?;
-				headers.extend(new_headers.into_iter().filter(is_redirect));
-				headers
-			}
 		},
 		checksum: source_checksum,
 	};
@@ -237,7 +225,6 @@ async fn handle_copy_metaonly(
 				.get(&source_version.uuid, &EmptyKey)
 				.await?;
 			let source_version = source_version.ok_or(Error::NoSuchKey)?;
-			check_version_not_deleted(&source_version)?;
 
 			// Write an "uploading" marker in Object table
 			// This holds a reference to the object in the Version table
@@ -429,7 +416,6 @@ pub async fn handle_upload_part_copy(
 		.get(&source_object_version.uuid, &EmptyKey)
 		.await?
 		.ok_or(Error::NoSuchKey)?;
-	check_version_not_deleted(&source_version)?;
 
 	// We want to reuse blocks from the source version as much as possible.
 	// However, we still need to get the data from these blocks
@@ -561,7 +547,6 @@ pub async fn handle_upload_part_copy(
 
 	let mut current_offset = 0;
 	let mut next_block = defragmenter.next().await?;
-	let mut blocks_to_dup = dest_version.clone();
 
 	// TODO this could be optimized similarly to read_and_put_blocks
 	// low priority because uploadpartcopy is rarely used
@@ -591,7 +576,8 @@ pub async fn handle_upload_part_copy(
 			.unwrap()?;
 		checksummer = checksummer_updated;
 
-		let (version_block_key, version_block) = (
+		dest_version.blocks.clear();
+		dest_version.blocks.put(
 			VersionBlockKey {
 				part_number,
 				offset: current_offset,
@@ -603,56 +589,37 @@ pub async fn handle_upload_part_copy(
 		);
 		current_offset += data_len;
 
-		let next = if let Some(final_data) = data_to_upload {
+		let block_ref = BlockRef {
-			dest_version.blocks.clear();
+			block: final_hash,
-			dest_version.blocks.put(version_block_key, version_block);
+			version: dest_version_id,
-			let block_ref = BlockRef {
+			deleted: false.into(),
-				block: final_hash,
-				version: dest_version_id,
-				deleted: false.into(),
-			};
-			let (_, _, _, next) = futures::try_join!(
-				// Thing 1: if the block is not exactly a block that existed before,
-				// we need to insert that data as a new block.
-				garage.block_manager.rpc_put_block(
-					final_hash,
-					final_data,
-					dest_encryption.is_encrypted(),
-					None
-				),
-				// Thing 2: we need to insert the block in the version
-				garage.version_table.insert(&dest_version),
-				// Thing 3: we need to add a block reference
-				garage.block_ref_table.insert(&block_ref),
-				// Thing 4: we need to read the next block
-				defragmenter.next(),
-			)?;
-			next
-		} else {
-			blocks_to_dup.blocks.put(version_block_key, version_block);
-			defragmenter.next().await?
 		};
+
+		let (_, _, _, next) = futures::try_join!(
+			// Thing 1: if the block is not exactly a block that existed before,
+			// we need to insert that data as a new block.
+			async {
+				if let Some(final_data) = data_to_upload {
+					garage
+						.block_manager
+						.rpc_put_block(final_hash, final_data, dest_encryption.is_encrypted(), None)
+						.await
+				} else {
+					Ok(())
+				}
+			},
+			// Thing 2: we need to insert the block in the version
+			garage.version_table.insert(&dest_version),
+			// Thing 3: we need to add a block reference
+			garage.block_ref_table.insert(&block_ref),
+			// Thing 4: we need to read the next block
+			defragmenter.next(),
+		)?;
 		next_block = next;
 	}
 
 	assert_eq!(current_offset, source_range.length);
 
-	// Put the duplicated blocks into the version & block_refs tables
-	let block_refs_to_put = blocks_to_dup
-		.blocks
-		.items()
-		.iter()
-		.map(|b| BlockRef {
-			block: b.1.hash,
-			version: dest_version_id,
-			deleted: false.into(),
-		})
-		.collect::<Vec<_>>();
-	futures::try_join!(
-		garage.version_table.insert(&blocks_to_dup),
-		garage.block_ref_table.insert_many(&block_refs_to_put[..]),
-	)?;
-
 	let checksums = checksummer.finalize();
 	let etag = dest_encryption.etag_from_md5(&checksums.md5);
 	let checksum = checksums.extract(dest_object_checksum_algorithm);

src/api/s3/get.rs

@@ -19,13 +19,12 @@ use garage_net::stream::ByteStream;
 use garage_rpc::rpc_helper::OrderTag;
 use garage_table::EmptyKey;
 use garage_util::data::*;
-use garage_util::error::{Error as UtilError, OkOrMessage};
+use garage_util::error::OkOrMessage;
 
 use garage_model::garage::Garage;
 use garage_model::s3::object_table::*;
 use garage_model::s3::version_table::*;
 
-use garage_api_common::common_error::CommonError;
 use garage_api_common::helpers::*;
 use garage_api_common::signature::checksum::{add_checksum_response_headers, X_AMZ_CHECKSUM_MODE};
 
@@ -216,7 +215,6 @@ pub async fn handle_head_without_ctx(
 					.get(&object_version.uuid, &EmptyKey)
 					.await?
 					.ok_or(Error::NoSuchKey)?;
-				check_version_not_deleted(&version)?;
 
 				let (part_offset, part_end) =
 					calculate_part_bounds(&version, pn).ok_or(Error::InvalidPart)?;
@@ -367,21 +365,6 @@ pub async fn handle_get_without_ctx(
 	}
 }
 
-pub(crate) fn check_version_not_deleted(version: &Version) -> Result<(), Error> {
-	if version.deleted.get() {
-		// the version was deleted between when the object_table was consulted
-		// and now, this could mean the object was deleted, or overriden.
-		// Rather than say the key doesn't exist, return a transient error
-		// to signal the client to try again.
-		return Err(CommonError::InternalError(UtilError::Message(
-			"conflict/inconsistency between object and version state, version is deleted"
-				.to_string(),
-		))
-		.into());
-	}
-	Ok(())
-}
-
 async fn handle_get_full(
 	garage: Arc<Garage>,
 	version: &ObjectVersion,
@@ -448,7 +431,6 @@ pub fn full_object_byte_stream(
 						.ok_or_message("channel closed")?;
 
 					let version = version_fut.await.unwrap()?.ok_or(Error::NoSuchKey)?;
-					check_version_not_deleted(&version)?;
 					for (i, (_, vb)) in version.blocks.items().iter().enumerate().skip(1) {
 						let stream_block_i = encryption
 							.get_block(&garage, &vb.hash, Some(order_stream.order(i as u64)))
@@ -464,14 +446,6 @@ pub fn full_object_byte_stream(
 				{
 					Ok(()) => (),
 					Err(e) => {
-						// TODO i think this is a bad idea, we should log
-						// an error and stop there. If the error happens to
-						// be exactly the size of what hasn't been streamed
-						// yet, the client will see the request as a
-						// success
-						// instead truncating the output notify the client
-						// something happened with their download, so that
-						// they can retry it
 						let _ = tx.send(error_stream_item(e)).await;
 					}
 				}
@@ -523,7 +497,7 @@ async fn handle_get_range(
 				.get(&version.uuid, &EmptyKey)
 				.await?
 				.ok_or(Error::NoSuchKey)?;
-			check_version_not_deleted(&version)?;
+
 			let body =
 				body_from_blocks_range(garage, encryption, version.blocks.items(), begin, end);
 			Ok(resp_builder.body(body)?)
@@ -574,8 +548,6 @@ async fn handle_get_part(
 				.await?
 				.ok_or(Error::NoSuchKey)?;
 
-			check_version_not_deleted(&version)?;
-
 			let (begin, end) =
 				calculate_part_bounds(&version, part_number).ok_or(Error::InvalidPart)?;
 

src/api/s3/lifecycle.rs

@@ -27,7 +27,7 @@ pub async fn handle_get_lifecycle(ctx: ReqCtx) -> Result<Response<ResBody>, Erro
 			.body(string_body(xml))?)
 	} else {
 		Ok(Response::builder()
-			.status(StatusCode::NOT_FOUND)
+			.status(StatusCode::NO_CONTENT)
 			.body(empty_body())?)
 	}
 }

src/api/s3/website.rs

@@ -3,7 +3,7 @@ use quick_xml::de::from_reader;
 use hyper::{header::HeaderName, Request, Response, StatusCode};
 use serde::{Deserialize, Serialize};
 
-use garage_model::bucket_table::*;
+use garage_model::bucket_table::{self, *};
 
 use garage_api_common::helpers::*;
 
@@ -26,7 +26,28 @@ pub async fn handle_get_website(ctx: ReqCtx) -> Result<Response<ResBody>, Error>
 				suffix: Value(website.index_document.to_string()),
 			}),
 			redirect_all_requests_to: None,
-			routing_rules: None,
+			routing_rules: RoutingRules {
+				rules: website
+					.routing_rules
+					.clone()
+					.into_iter()
+					.map(|rule| RoutingRule {
+						condition: rule.condition.map(|cond| Condition {
+							http_error_code: cond.http_error_code.map(|c| IntValue(c as i64)),
+							prefix: cond.prefix.map(Value),
+						}),
+						redirect: Redirect {
+							hostname: rule.redirect.hostname.map(Value),
+							http_redirect_code: Some(IntValue(
+								rule.redirect.http_redirect_code as i64,
+							)),
+							protocol: rule.redirect.protocol.map(Value),
+							replace_full: rule.redirect.replace_key.map(Value),
+							replace_prefix: rule.redirect.replace_key_prefix.map(Value),
+						},
+					})
+					.collect(),
+			},
 		};
 		let xml = to_xml_with_header(&wc)?;
 		Ok(Response::builder()
@@ -97,18 +118,28 @@ pub struct WebsiteConfiguration {
 	pub index_document: Option<Suffix>,
 	#[serde(rename = "RedirectAllRequestsTo")]
 	pub redirect_all_requests_to: Option<Target>,
-	#[serde(rename = "RoutingRules")]
+	#[serde(
-	pub routing_rules: Option<Vec<RoutingRule>>,
+		rename = "RoutingRules",
+		default,
+		skip_serializing_if = "RoutingRules::is_empty"
+	)]
+	pub routing_rules: RoutingRules,
+}
+
+#[derive(Debug, Serialize, Deserialize, PartialEq, Eq, PartialOrd, Ord, Default)]
+pub struct RoutingRules {
+	#[serde(rename = "RoutingRule")]
+	pub rules: Vec<RoutingRule>,
+}
+
+impl RoutingRules {
+	fn is_empty(&self) -> bool {
+		self.rules.is_empty()
+	}
 }
 
 #[derive(Debug, Serialize, Deserialize, PartialEq, Eq, PartialOrd, Ord)]
 pub struct RoutingRule {
-	#[serde(rename = "RoutingRule")]
-	pub inner: RoutingRuleInner,
-}
-
-#[derive(Debug, Serialize, Deserialize, PartialEq, Eq, PartialOrd, Ord)]
-pub struct RoutingRuleInner {
 	#[serde(rename = "Condition")]
 	pub condition: Option<Condition>,
 	#[serde(rename = "Redirect")]
@@ -162,7 +193,7 @@ impl WebsiteConfiguration {
 		if self.redirect_all_requests_to.is_some()
 			&& (self.error_document.is_some()
 				|| self.index_document.is_some()
-				|| self.routing_rules.is_some())
+				|| !self.routing_rules.is_empty())
 		{
 			return Err(Error::bad_request(
 				"Bad XML: can't have RedirectAllRequestsTo and other fields",
@@ -177,10 +208,15 @@ impl WebsiteConfiguration {
 		if let Some(ref rart) = self.redirect_all_requests_to {
 			rart.validate()?;
 		}
-		if let Some(ref rrs) = self.routing_rules {
+		for rr in &self.routing_rules.rules {
-			for rr in rrs {
+			rr.validate()?;
-				rr.inner.validate()?;
+		}
-			}
+		if self.routing_rules.rules.len() > 1000 {
+			// we will do linear scans, best to avoid overly long configuration. The
+			// limit was choosen arbitrarily
+			return Err(Error::bad_request(
+				"Bad XML: RoutingRules can't have more than 1000 child elements",
+			));
 		}
 
 		Ok(())
@@ -189,11 +225,7 @@ impl WebsiteConfiguration {
 	pub fn into_garage_website_config(self) -> Result<WebsiteConfig, Error> {
 		if self.redirect_all_requests_to.is_some() {
 			Err(Error::NotImplemented(
-				"S3 website redirects are not currently implemented in Garage.".into(),
+				"RedirectAllRequestsTo is not currently implemented in Garage, however its effect can be emulated using a single inconditional RoutingRule.".into(),
-			))
-		} else if self.routing_rules.map(|x| !x.is_empty()).unwrap_or(false) {
-			Err(Error::NotImplemented(
-				"S3 routing rules are not currently implemented in Garage.".into(),
 			))
 		} else {
 			Ok(WebsiteConfig {
@@ -202,6 +234,36 @@ impl WebsiteConfiguration {
 					.map(|x| x.suffix.0)
 					.unwrap_or_else(|| "index.html".to_string()),
 				error_document: self.error_document.map(|x| x.key.0),
+				redirect_all: None,
+				routing_rules: self
+					.routing_rules
+					.rules
+					.into_iter()
+					.map(|rule| {
+						bucket_table::RoutingRule {
+							condition: rule.condition.map(|condition| {
+								bucket_table::RedirectCondition {
+									http_error_code: condition.http_error_code.map(|c| c.0 as u16),
+									prefix: condition.prefix.map(|p| p.0),
+								}
+							}),
+							redirect: bucket_table::Redirect {
+								hostname: rule.redirect.hostname.map(|h| h.0),
+								protocol: rule.redirect.protocol.map(|p| p.0),
+								// aws default to 301, which i find punitive in case of
+								// missconfiguration (can be permanently cached on the
+								// user agent)
+								http_redirect_code: rule
+									.redirect
+									.http_redirect_code
+									.map(|c| c.0 as u16)
+									.unwrap_or(302),
+								replace_key_prefix: rule.redirect.replace_prefix.map(|k| k.0),
+								replace_key: rule.redirect.replace_full.map(|k| k.0),
+							},
+						}
+					})
+					.collect(),
 			})
 		}
 	}
@@ -242,37 +304,69 @@ impl Target {
 	}
 }
 
-impl RoutingRuleInner {
+impl RoutingRule {
 	pub fn validate(&self) -> Result<(), Error> {
-		let has_prefix = self
+		if let Some(condition) = &self.condition {
-			.condition
+			condition.validate()?;
-			.as_ref()
+		}
-			.and_then(|c| c.prefix.as_ref())
+		self.redirect.validate()
-			.is_some();
+	}
-		self.redirect.validate(has_prefix)
+}
+
+impl Condition {
+	pub fn validate(&self) -> Result<bool, Error> {
+		if let Some(ref error_code) = self.http_error_code {
+			// TODO do other error codes make sense? Aws only allows 4xx and 5xx
+			if error_code.0 != 404 {
+				return Err(Error::bad_request(
+					"Bad XML: HttpErrorCodeReturnedEquals must be 404 or absent",
+				));
+			}
+		}
+		Ok(self.prefix.is_some())
 	}
 }
 
 impl Redirect {
-	pub fn validate(&self, has_prefix: bool) -> Result<(), Error> {
+	pub fn validate(&self) -> Result<(), Error> {
-		if self.replace_prefix.is_some() {
+		if self.replace_prefix.is_some() && self.replace_full.is_some() {
-			if self.replace_full.is_some() {
+			return Err(Error::bad_request(
-				return Err(Error::bad_request(
+				"Bad XML: both ReplaceKeyPrefixWith and ReplaceKeyWith are set",
-					"Bad XML: both ReplaceKeyPrefixWith and ReplaceKeyWith are set",
+			));
-				));
-			}
-			if !has_prefix {
-				return Err(Error::bad_request(
-					"Bad XML: ReplaceKeyPrefixWith is set, but  KeyPrefixEquals isn't",
-				));
-			}
 		}
 		if let Some(ref protocol) = self.protocol {
 			if protocol.0 != "http" && protocol.0 != "https" {
 				return Err(Error::bad_request("Bad XML: invalid protocol"));
 			}
 		}
-		// TODO there are probably more invalid cases, but which ones?
+		if let Some(ref http_redirect_code) = self.http_redirect_code {
+			match http_redirect_code.0 {
+				// aws allows all 3xx except 300, but some are non-sensical (not modified,
+				// use proxy...)
+				301 | 302 | 303 | 307 | 308 => {
+					if self.hostname.is_none() && self.protocol.is_some() {
+						return Err(Error::bad_request(
+							"Bad XML: HostName must be set if Protocol is set",
+						));
+					}
+				}
+				// aws doesn't allow these codes, but netlify does, and it seems like a
+				// cool feature (change the page seen without changing the url shown by the
+				// user agent)
+				200 | 404 => {
+					if self.hostname.is_some() || self.protocol.is_some() {
+						// hostname would mean different bucket, protocol doesn't make
+						// sense
+						return Err(Error::bad_request(
+                                        "Bad XML: an HttpRedirectCode of 200 is not acceptable alongside HostName or Protocol",
+                                ));
+					}
+				}
+				_ => {
+					return Err(Error::bad_request("Bad XML: invalid HttpRedirectCode"));
+				}
+			}
+		}
 		Ok(())
 	}
 }
@@ -311,6 +405,15 @@ mod tests {
             <ReplaceKeyWith>fullkey</ReplaceKeyWith>
          </Redirect>
       </RoutingRule>
+      <RoutingRule>
+         <Condition>
+            <KeyPrefixEquals></KeyPrefixEquals>
+         </Condition>
+         <Redirect>
+            <HttpRedirectCode>404</HttpRedirectCode>
+            <ReplaceKeyWith>missing</ReplaceKeyWith>
+         </Redirect>
+      </RoutingRule>
    </RoutingRules>
 </WebsiteConfiguration>"#;
 		let conf: WebsiteConfiguration = from_str(message).unwrap();
@@ -326,21 +429,36 @@ mod tests {
 				hostname: Value("garage.tld".to_owned()),
 				protocol: Some(Value("https".to_owned())),
 			}),
-			routing_rules: Some(vec![RoutingRule {
+			routing_rules: RoutingRules {
-				inner: RoutingRuleInner {
+				rules: vec![
-					condition: Some(Condition {
+					RoutingRule {
-						http_error_code: Some(IntValue(404)),
+						condition: Some(Condition {
-						prefix: Some(Value("prefix1".to_owned())),
+							http_error_code: Some(IntValue(404)),
-					}),
+							prefix: Some(Value("prefix1".to_owned())),
-					redirect: Redirect {
+						}),
-						hostname: Some(Value("gara.ge".to_owned())),
+						redirect: Redirect {
-						protocol: Some(Value("http".to_owned())),
+							hostname: Some(Value("gara.ge".to_owned())),
-						http_redirect_code: Some(IntValue(303)),
+							protocol: Some(Value("http".to_owned())),
-						replace_prefix: Some(Value("prefix2".to_owned())),
+							http_redirect_code: Some(IntValue(303)),
-						replace_full: Some(Value("fullkey".to_owned())),
+							replace_prefix: Some(Value("prefix2".to_owned())),
+							replace_full: Some(Value("fullkey".to_owned())),
+						},
 					},
-				},
+					RoutingRule {
-			}]),
+						condition: Some(Condition {
+							http_error_code: None,
+							prefix: Some(Value("".to_owned())),
+						}),
+						redirect: Redirect {
+							hostname: None,
+							protocol: None,
+							http_redirect_code: Some(IntValue(404)),
+							replace_prefix: None,
+							replace_full: Some(Value("missing".to_owned())),
+						},
+					},
+				],
+			},
 		};
 		assert_eq! {
 			ref_value,

src/api/s3/xml.rs

@@ -13,10 +13,6 @@ pub fn xmlns_tag<S: Serializer>(_v: &(), s: S) -> Result<S::Ok, S::Error> {
 	s.serialize_str("http://s3.amazonaws.com/doc/2006-03-01/")
 }
 
-pub fn xmlns_xsi_tag<S: Serializer>(_v: &(), s: S) -> Result<S::Ok, S::Error> {
-	s.serialize_str("http://www.w3.org/2001/XMLSchema-instance")
-}
-
 #[derive(Debug, Serialize, Deserialize, PartialEq, Eq, PartialOrd, Ord)]
 pub struct Value(#[serde(rename = "$value")] pub String);
 
@@ -323,42 +319,6 @@ pub struct PostObject {
 	pub etag: Value,
 }
 
-#[derive(Debug, Serialize, PartialEq, Eq)]
-pub struct Grantee {
-	#[serde(rename = "xmlns:xsi", serialize_with = "xmlns_xsi_tag")]
-	pub xmlns_xsi: (),
-	#[serde(rename = "xsi:type")]
-	pub typ: String,
-	#[serde(rename = "DisplayName")]
-	pub display_name: Option<Value>,
-	#[serde(rename = "ID")]
-	pub id: Option<Value>,
-}
-
-#[derive(Debug, Serialize, PartialEq, Eq)]
-pub struct Grant {
-	#[serde(rename = "Grantee")]
-	pub grantee: Grantee,
-	#[serde(rename = "Permission")]
-	pub permission: Value,
-}
-
-#[derive(Debug, Serialize, PartialEq, Eq)]
-pub struct AccessControlList {
-	#[serde(rename = "Grant")]
-	pub entries: Vec<Grant>,
-}
-
-#[derive(Debug, Serialize, PartialEq, Eq)]
-pub struct AccessControlPolicy {
-	#[serde(serialize_with = "xmlns_tag")]
-	pub xmlns: (),
-	#[serde(rename = "Owner")]
-	pub owner: Option<Owner>,
-	#[serde(rename = "AccessControlList")]
-	pub acl: AccessControlList,
-}
-
 #[cfg(test)]
 mod tests {
 	use super::*;
@@ -467,43 +427,6 @@ mod tests {
 		Ok(())
 	}
 
-	#[test]
-	fn get_bucket_acl_result() -> Result<(), ApiError> {
-		let grant = Grant {
-			grantee: Grantee {
-				xmlns_xsi: (),
-				typ: "CanonicalUser".to_string(),
-				display_name: Some(Value("owner_name".to_string())),
-				id: Some(Value("qsdfjklm".to_string())),
-			},
-			permission: Value("FULL_CONTROL".to_string()),
-		};
-
-		let get_bucket_acl = AccessControlPolicy {
-			xmlns: (),
-			owner: None,
-			acl: AccessControlList {
-				entries: vec![grant],
-			},
-		};
-		assert_eq!(
-			to_xml_with_header(&get_bucket_acl)?,
-			"<?xml version=\"1.0\" encoding=\"UTF-8\"?>\
-<AccessControlPolicy xmlns=\"http://s3.amazonaws.com/doc/2006-03-01/\">\
-	<AccessControlList>\
-		<Grant>\
-			<Grantee xmlns:xsi=\"http://www.w3.org/2001/XMLSchema-instance\" xsi:type=\"CanonicalUser\">\
-				<DisplayName>owner_name</DisplayName>\
-				<ID>qsdfjklm</ID>\
-			</Grantee>\
-			<Permission>FULL_CONTROL</Permission>\
-		</Grant>\
-	</AccessControlList>\
-</AccessControlPolicy>"
-		);
-		Ok(())
-	}
-
 	#[test]
 	fn delete_result() -> Result<(), ApiError> {
 		let delete_result = DeleteResult {

src/block/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "garage_block"
-version = "1.2.0"
+version = "1.1.0"
 authors = ["Alex Auvolat <alex@adnab.me>"]
 edition = "2018"
 license = "AGPL-3.0"

src/block/manager.rs

@@ -408,8 +408,8 @@ impl BlockManager {
 	}
 
 	/// Get number of items in the refcount table
-	pub fn rc_approximate_len(&self) -> Result<usize, Error> {
+	pub fn rc_len(&self) -> Result<usize, Error> {
-		Ok(self.rc.rc_table.approximate_len()?)
+		Ok(self.rc.rc_table.len()?)
 	}
 
 	/// Send command to start/stop/manager scrub worker
@@ -427,7 +427,7 @@ impl BlockManager {
 
 	/// List all resync errors
 	pub fn list_resync_errors(&self) -> Result<Vec<BlockResyncErrorInfo>, Error> {
-		let mut blocks = Vec::with_capacity(self.resync.errors.approximate_len()?);
+		let mut blocks = Vec::with_capacity(self.resync.errors.len()?);
 		for ent in self.resync.errors.iter()? {
 			let (hash, cnt) = ent?;
 			let cnt = ErrorCounter::decode(&cnt);

src/block/metrics.rs

@@ -50,7 +50,7 @@ impl BlockManagerMetrics {
 				.init(),
 			_rc_size: meter
 				.u64_value_observer("block.rc_size", move |observer| {
-					if let Ok(value) = rc_tree.approximate_len() {
+					if let Ok(value) = rc_tree.len() {
 						observer.observe(value as u64, &[])
 					}
 				})
@@ -58,7 +58,7 @@ impl BlockManagerMetrics {
 				.init(),
 			_resync_queue_len: meter
 				.u64_value_observer("block.resync_queue_length", move |observer| {
-					if let Ok(value) = resync_queue.approximate_len() {
+					if let Ok(value) = resync_queue.len() {
 						observer.observe(value as u64, &[]);
 					}
 				})
@@ -68,7 +68,7 @@ impl BlockManagerMetrics {
 				.init(),
 			_resync_errored_blocks: meter
 				.u64_value_observer("block.resync_errored_blocks", move |observer| {
-					if let Ok(value) = resync_errors.approximate_len() {
+					if let Ok(value) = resync_errors.len() {
 						observer.observe(value as u64, &[]);
 					}
 				})

src/block/resync.rs

@@ -106,13 +106,13 @@ impl BlockResyncManager {
 	}
 
 	/// Get length of resync queue
-	pub fn queue_approximate_len(&self) -> Result<usize, Error> {
+	pub fn queue_len(&self) -> Result<usize, Error> {
-		Ok(self.queue.approximate_len()?)
+		Ok(self.queue.len()?)
 	}
 
 	/// Get number of blocks that have an error
-	pub fn errors_approximate_len(&self) -> Result<usize, Error> {
+	pub fn errors_len(&self) -> Result<usize, Error> {
-		Ok(self.errors.approximate_len()?)
+		Ok(self.errors.len()?)
 	}
 
 	/// Clear the error counter for a block and put it in queue immediately
@@ -548,11 +548,9 @@ impl Worker for ResyncWorker {
 		}
 
 		WorkerStatus {
-			queue_length: Some(self.manager.resync.queue_approximate_len().unwrap_or(0) as u64),
+			queue_length: Some(self.manager.resync.queue_len().unwrap_or(0) as u64),
 			tranquility: Some(tranquility),
-			persistent_errors: Some(
+			persistent_errors: Some(self.manager.resync.errors_len().unwrap_or(0) as u64),
-				self.manager.resync.errors_approximate_len().unwrap_or(0) as u64
-			),
 			..Default::default()
 		}
 	}

src/db/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "garage_db"
-version = "1.2.0"
+version = "1.1.0"
 authors = ["Alex Auvolat <alex@adnab.me>"]
 edition = "2018"
 license = "AGPL-3.0"
@@ -16,14 +16,10 @@ err-derive.workspace = true
 tracing.workspace = true
 
 heed = { workspace = true, optional = true }
-
 rusqlite = { workspace = true, optional = true, features = ["backup"] }
 r2d2 = { workspace = true, optional = true }
 r2d2_sqlite = { workspace = true, optional = true }
 
-fjall = { workspace = true, optional = true }
-parking_lot = { workspace = true, optional = true }
-
 [dev-dependencies]
 mktemp.workspace = true
 
@@ -31,5 +27,4 @@ mktemp.workspace = true
 default = [ "lmdb", "sqlite" ]
 bundled-libs = [ "rusqlite?/bundled" ]
 lmdb = [ "heed" ]
-fjall = [ "dep:fjall", "dep:parking_lot" ]
 sqlite = [ "rusqlite", "r2d2", "r2d2_sqlite" ]

src/db/fjall_adapter.rs

@@ -1,453 +0,0 @@
-use core::ops::Bound;
-
-use std::path::PathBuf;
-use std::sync::Arc;
-
-use parking_lot::{MappedRwLockReadGuard, RwLock, RwLockReadGuard};
-
-use fjall::{
-	PartitionCreateOptions, PersistMode, TransactionalKeyspace, TransactionalPartitionHandle,
-	WriteTransaction,
-};
-
-use crate::{
-	open::{Engine, OpenOpt},
-	Db, Error, IDb, ITx, ITxFn, OnCommit, Result, TxError, TxFnResult, TxOpError, TxOpResult,
-	TxResult, TxValueIter, Value, ValueIter,
-};
-
-pub use fjall;
-
-// --
-
-pub(crate) fn open_db(path: &PathBuf, opt: &OpenOpt) -> Result<Db> {
-	info!("Opening Fjall database at: {}", path.display());
-	if opt.fsync {
-		return Err(Error(
-			"metadata_fsync is not supported with the Fjall database engine".into(),
-		));
-	}
-	let mut config = fjall::Config::new(path);
-	if let Some(block_cache_size) = opt.fjall_block_cache_size {
-		config = config.cache_size(block_cache_size as u64);
-	}
-	let keyspace = config.open_transactional()?;
-	Ok(FjallDb::init(keyspace))
-}
-
-// -- err
-
-impl From<fjall::Error> for Error {
-	fn from(e: fjall::Error) -> Error {
-		Error(format!("fjall: {}", e).into())
-	}
-}
-
-impl From<fjall::LsmError> for Error {
-	fn from(e: fjall::LsmError) -> Error {
-		Error(format!("fjall lsm_tree: {}", e).into())
-	}
-}
-
-impl From<fjall::Error> for TxOpError {
-	fn from(e: fjall::Error) -> TxOpError {
-		TxOpError(e.into())
-	}
-}
-
-// -- db
-
-pub struct FjallDb {
-	keyspace: TransactionalKeyspace,
-	trees: RwLock<Vec<(String, TransactionalPartitionHandle)>>,
-}
-
-type ByteRefRangeBound<'r> = (Bound<&'r [u8]>, Bound<&'r [u8]>);
-
-impl FjallDb {
-	pub fn init(keyspace: TransactionalKeyspace) -> Db {
-		let s = Self {
-			keyspace,
-			trees: RwLock::new(Vec::new()),
-		};
-		Db(Arc::new(s))
-	}
-
-	fn get_tree(
-		&self,
-		i: usize,
-	) -> Result<MappedRwLockReadGuard<'_, TransactionalPartitionHandle>> {
-		RwLockReadGuard::try_map(self.trees.read(), |trees: &Vec<_>| {
-			trees.get(i).map(|tup| &tup.1)
-		})
-		.map_err(|_| Error("invalid tree id".into()))
-	}
-}
-
-impl IDb for FjallDb {
-	fn engine(&self) -> String {
-		"Fjall (EXPERIMENTAL!)".into()
-	}
-
-	fn open_tree(&self, name: &str) -> Result<usize> {
-		let mut trees = self.trees.write();
-		let safe_name = encode_name(name)?;
-		if let Some(i) = trees.iter().position(|(name, _)| *name == safe_name) {
-			Ok(i)
-		} else {
-			let tree = self
-				.keyspace
-				.open_partition(&safe_name, PartitionCreateOptions::default())?;
-			let i = trees.len();
-			trees.push((safe_name, tree));
-			Ok(i)
-		}
-	}
-
-	fn list_trees(&self) -> Result<Vec<String>> {
-		Ok(self
-			.keyspace
-			.list_partitions()
-			.iter()
-			.map(|n| decode_name(&n))
-			.collect::<Result<Vec<_>>>()?)
-	}
-
-	fn snapshot(&self, base_path: &PathBuf) -> Result<()> {
-		std::fs::create_dir_all(base_path)?;
-		let path = Engine::Fjall.db_path(base_path);
-
-		let source_state = self.keyspace.read_tx();
-		let copy_keyspace = fjall::Config::new(path).open()?;
-
-		for partition_name in self.keyspace.list_partitions() {
-			let source_partition = self
-				.keyspace
-				.open_partition(&partition_name, PartitionCreateOptions::default())?;
-			let copy_partition =
-				copy_keyspace.open_partition(&partition_name, PartitionCreateOptions::default())?;
-
-			for entry in source_state.iter(&source_partition) {
-				let (key, value) = entry?;
-				copy_partition.insert(key, value)?;
-			}
-		}
-
-		copy_keyspace.persist(PersistMode::SyncAll)?;
-		Ok(())
-	}
-
-	// ----
-
-	fn get(&self, tree_idx: usize, key: &[u8]) -> Result<Option<Value>> {
-		let tree = self.get_tree(tree_idx)?;
-		let tx = self.keyspace.read_tx();
-		let val = tx.get(&tree, key)?;
-		match val {
-			None => Ok(None),
-			Some(v) => Ok(Some(v.to_vec())),
-		}
-	}
-
-	fn approximate_len(&self, tree_idx: usize) -> Result<usize> {
-		let tree = self.get_tree(tree_idx)?;
-		Ok(tree.approximate_len())
-	}
-	fn is_empty(&self, tree_idx: usize) -> Result<bool> {
-		let tree = self.get_tree(tree_idx)?;
-		let tx = self.keyspace.read_tx();
-		Ok(tx.is_empty(&tree)?)
-	}
-
-	fn insert(&self, tree_idx: usize, key: &[u8], value: &[u8]) -> Result<()> {
-		let tree = self.get_tree(tree_idx)?;
-		let mut tx = self.keyspace.write_tx();
-		tx.insert(&tree, key, value);
-		tx.commit()?;
-		Ok(())
-	}
-
-	fn remove(&self, tree_idx: usize, key: &[u8]) -> Result<()> {
-		let tree = self.get_tree(tree_idx)?;
-		let mut tx = self.keyspace.write_tx();
-		tx.remove(&tree, key);
-		tx.commit()?;
-		Ok(())
-	}
-
-	fn clear(&self, tree_idx: usize) -> Result<()> {
-		let mut trees = self.trees.write();
-
-		if tree_idx >= trees.len() {
-			return Err(Error("invalid tree id".into()));
-		}
-		let (name, tree) = trees.remove(tree_idx);
-
-		self.keyspace.delete_partition(tree)?;
-		let tree = self
-			.keyspace
-			.open_partition(&name, PartitionCreateOptions::default())?;
-		trees.insert(tree_idx, (name, tree));
-
-		Ok(())
-	}
-
-	fn iter(&self, tree_idx: usize) -> Result<ValueIter<'_>> {
-		let tree = self.get_tree(tree_idx)?;
-		let tx = self.keyspace.read_tx();
-		Ok(Box::new(tx.iter(&tree).map(iterator_remap)))
-	}
-
-	fn iter_rev(&self, tree_idx: usize) -> Result<ValueIter<'_>> {
-		let tree = self.get_tree(tree_idx)?;
-		let tx = self.keyspace.read_tx();
-		Ok(Box::new(tx.iter(&tree).rev().map(iterator_remap)))
-	}
-
-	fn range<'r>(
-		&self,
-		tree_idx: usize,
-		low: Bound<&'r [u8]>,
-		high: Bound<&'r [u8]>,
-	) -> Result<ValueIter<'_>> {
-		let tree = self.get_tree(tree_idx)?;
-		let tx = self.keyspace.read_tx();
-		Ok(Box::new(
-			tx.range::<&'r [u8], ByteRefRangeBound>(&tree, (low, high))
-				.map(iterator_remap),
-		))
-	}
-	fn range_rev<'r>(
-		&self,
-		tree_idx: usize,
-		low: Bound<&'r [u8]>,
-		high: Bound<&'r [u8]>,
-	) -> Result<ValueIter<'_>> {
-		let tree = self.get_tree(tree_idx)?;
-		let tx = self.keyspace.read_tx();
-		Ok(Box::new(
-			tx.range::<&'r [u8], ByteRefRangeBound>(&tree, (low, high))
-				.rev()
-				.map(iterator_remap),
-		))
-	}
-
-	// ----
-
-	fn transaction(&self, f: &dyn ITxFn) -> TxResult<OnCommit, ()> {
-		let trees = self.trees.read();
-		let mut tx = FjallTx {
-			trees: &trees[..],
-			tx: self.keyspace.write_tx(),
-		};
-
-		let res = f.try_on(&mut tx);
-		match res {
-			TxFnResult::Ok(on_commit) => {
-				tx.tx.commit().map_err(Error::from).map_err(TxError::Db)?;
-				Ok(on_commit)
-			}
-			TxFnResult::Abort => {
-				tx.tx.rollback();
-				Err(TxError::Abort(()))
-			}
-			TxFnResult::DbErr => {
-				tx.tx.rollback();
-				Err(TxError::Db(Error(
-					"(this message will be discarded)".into(),
-				)))
-			}
-		}
-	}
-}
-
-// ----
-
-struct FjallTx<'a> {
-	trees: &'a [(String, TransactionalPartitionHandle)],
-	tx: WriteTransaction<'a>,
-}
-
-impl<'a> FjallTx<'a> {
-	fn get_tree(&self, i: usize) -> TxOpResult<&TransactionalPartitionHandle> {
-		self.trees.get(i).map(|tup| &tup.1).ok_or_else(|| {
-			TxOpError(Error(
-				"invalid tree id (it might have been openned after the transaction started)".into(),
-			))
-		})
-	}
-}
-
-impl<'a> ITx for FjallTx<'a> {
-	fn get(&self, tree_idx: usize, key: &[u8]) -> TxOpResult<Option<Value>> {
-		let tree = self.get_tree(tree_idx)?;
-		match self.tx.get(tree, key)? {
-			Some(v) => Ok(Some(v.to_vec())),
-			None => Ok(None),
-		}
-	}
-	fn len(&self, tree_idx: usize) -> TxOpResult<usize> {
-		let tree = self.get_tree(tree_idx)?;
-		Ok(self.tx.len(tree)? as usize)
-	}
-
-	fn insert(&mut self, tree_idx: usize, key: &[u8], value: &[u8]) -> TxOpResult<()> {
-		let tree = self.get_tree(tree_idx)?.clone();
-		self.tx.insert(&tree, key, value);
-		Ok(())
-	}
-	fn remove(&mut self, tree_idx: usize, key: &[u8]) -> TxOpResult<()> {
-		let tree = self.get_tree(tree_idx)?.clone();
-		self.tx.remove(&tree, key);
-		Ok(())
-	}
-	fn clear(&mut self, _tree_idx: usize) -> TxOpResult<()> {
-		unimplemented!("LSM tree clearing in cross-partition transaction is not supported")
-	}
-
-	fn iter(&self, tree_idx: usize) -> TxOpResult<TxValueIter<'_>> {
-		let tree = self.get_tree(tree_idx)?.clone();
-		Ok(Box::new(self.tx.iter(&tree).map(iterator_remap_tx)))
-	}
-	fn iter_rev(&self, tree_idx: usize) -> TxOpResult<TxValueIter<'_>> {
-		let tree = self.get_tree(tree_idx)?.clone();
-		Ok(Box::new(self.tx.iter(&tree).rev().map(iterator_remap_tx)))
-	}
-
-	fn range<'r>(
-		&self,
-		tree_idx: usize,
-		low: Bound<&'r [u8]>,
-		high: Bound<&'r [u8]>,
-	) -> TxOpResult<TxValueIter<'_>> {
-		let tree = self.get_tree(tree_idx)?;
-		let low = clone_bound(low);
-		let high = clone_bound(high);
-		Ok(Box::new(
-			self.tx
-				.range::<Vec<u8>, ByteVecRangeBounds>(&tree, (low, high))
-				.map(iterator_remap_tx),
-		))
-	}
-	fn range_rev<'r>(
-		&self,
-		tree_idx: usize,
-		low: Bound<&'r [u8]>,
-		high: Bound<&'r [u8]>,
-	) -> TxOpResult<TxValueIter<'_>> {
-		let tree = self.get_tree(tree_idx)?;
-		let low = clone_bound(low);
-		let high = clone_bound(high);
-		Ok(Box::new(
-			self.tx
-				.range::<Vec<u8>, ByteVecRangeBounds>(&tree, (low, high))
-				.rev()
-				.map(iterator_remap_tx),
-		))
-	}
-}
-
-// -- maps fjall's (k, v) to ours
-
-fn iterator_remap(r: fjall::Result<(fjall::Slice, fjall::Slice)>) -> Result<(Value, Value)> {
-	r.map(|(k, v)| (k.to_vec(), v.to_vec()))
-		.map_err(|e| e.into())
-}
-
-fn iterator_remap_tx(r: fjall::Result<(fjall::Slice, fjall::Slice)>) -> TxOpResult<(Value, Value)> {
-	r.map(|(k, v)| (k.to_vec(), v.to_vec()))
-		.map_err(|e| e.into())
-}
-
-// -- utils to deal with Garage's tightness on Bound lifetimes
-
-type ByteVecBound = Bound<Vec<u8>>;
-type ByteVecRangeBounds = (ByteVecBound, ByteVecBound);
-
-fn clone_bound(bound: Bound<&[u8]>) -> ByteVecBound {
-	let value = match bound {
-		Bound::Excluded(v) | Bound::Included(v) => v.to_vec(),
-		Bound::Unbounded => vec![],
-	};
-
-	match bound {
-		Bound::Included(_) => Bound::Included(value),
-		Bound::Excluded(_) => Bound::Excluded(value),
-		Bound::Unbounded => Bound::Unbounded,
-	}
-}
-
-// -- utils to encode table names --
-
-fn encode_name(s: &str) -> Result<String> {
-	let base = 'A' as u32;
-
-	let mut ret = String::with_capacity(s.len() + 10);
-	for c in s.chars() {
-		if c.is_alphanumeric() || c == '_' || c == '-' || c == '#' {
-			ret.push(c);
-		} else if c <= u8::MAX as char {
-			ret.push('$');
-			let c_hi = c as u32 / 16;
-			let c_lo = c as u32 % 16;
-			ret.push(char::from_u32(base + c_hi).unwrap());
-			ret.push(char::from_u32(base + c_lo).unwrap());
-		} else {
-			return Err(Error(
-				format!("table name {} could not be safely encoded", s).into(),
-			));
-		}
-	}
-	Ok(ret)
-}
-
-fn decode_name(s: &str) -> Result<String> {
-	use std::convert::TryFrom;
-
-	let errfn = || Error(format!("encoded table name {} is invalid", s).into());
-	let c_map = |c: char| {
-		let c = c as u32;
-		let base = 'A' as u32;
-		if (base..base + 16).contains(&c) {
-			Some(c - base)
-		} else {
-			None
-		}
-	};
-
-	let mut ret = String::with_capacity(s.len());
-	let mut it = s.chars();
-	while let Some(c) = it.next() {
-		if c == '$' {
-			let c_hi = it.next().and_then(c_map).ok_or_else(errfn)?;
-			let c_lo = it.next().and_then(c_map).ok_or_else(errfn)?;
-			let c_dec = char::try_from(c_hi * 16 + c_lo).map_err(|_| errfn())?;
-			ret.push(c_dec);
-		} else {
-			ret.push(c);
-		}
-	}
-	Ok(ret)
-}
-
-#[cfg(test)]
-mod tests {
-	use super::*;
-
-	#[test]
-	fn test_encdec_name() {
-		for name in [
-			"testname",
-			"test_name",
-			"test name",
-			"test$name",
-			"test:name@help.me$get/this**right",
-		] {
-			let encname = encode_name(name).unwrap();
-			assert!(!encname.contains(' '));
-			assert!(!encname.contains('.'));
-			assert!(!encname.contains('*'));
-			assert_eq!(*name, decode_name(&encname).unwrap());
-		}
-	}
-}

src/db/lib.rs

@@ -1,8 +1,6 @@
 #[macro_use]
 extern crate tracing;
 
-#[cfg(feature = "fjall")]
-pub mod fjall_adapter;
 #[cfg(feature = "lmdb")]
 pub mod lmdb_adapter;
 #[cfg(feature = "sqlite")]
@@ -154,7 +152,7 @@ impl Db {
 		let tree_names = other.list_trees()?;
 		for name in tree_names {
 			let tree = self.open_tree(&name)?;
-			if !tree.is_empty()? {
+			if tree.len()? > 0 {
 				return Err(Error(format!("tree {} already contains data", name).into()));
 			}
 
@@ -196,12 +194,8 @@ impl Tree {
 		self.0.get(self.1, key.as_ref())
 	}
 	#[inline]
-	pub fn approximate_len(&self) -> Result<usize> {
+	pub fn len(&self) -> Result<usize> {
-		self.0.approximate_len(self.1)
+		self.0.len(self.1)
-	}
-	#[inline]
-	pub fn is_empty(&self) -> Result<bool> {
-		self.0.is_empty(self.1)
 	}
 
 	#[inline]
@@ -339,8 +333,7 @@ pub(crate) trait IDb: Send + Sync {
 	fn snapshot(&self, path: &PathBuf) -> Result<()>;
 
 	fn get(&self, tree: usize, key: &[u8]) -> Result<Option<Value>>;
-	fn approximate_len(&self, tree: usize) -> Result<usize>;
+	fn len(&self, tree: usize) -> Result<usize>;
-	fn is_empty(&self, tree: usize) -> Result<bool>;
 
 	fn insert(&self, tree: usize, key: &[u8], value: &[u8]) -> Result<()>;
 	fn remove(&self, tree: usize, key: &[u8]) -> Result<()>;

src/db/lmdb_adapter.rs

@@ -1,8 +1,8 @@
 use core::ops::Bound;
+use core::ptr::NonNull;
 
 use std::collections::HashMap;
 use std::convert::TryInto;
-use std::marker::PhantomPinned;
 use std::path::PathBuf;
 use std::pin::Pin;
 use std::sync::{Arc, RwLock};
@@ -11,55 +11,12 @@ use heed::types::ByteSlice;
 use heed::{BytesDecode, Env, RoTxn, RwTxn, UntypedDatabase as Database};
 
 use crate::{
-	open::{Engine, OpenOpt},
 	Db, Error, IDb, ITx, ITxFn, OnCommit, Result, TxError, TxFnResult, TxOpError, TxOpResult,
 	TxResult, TxValueIter, Value, ValueIter,
 };
 
 pub use heed;
 
-// ---- top-level open function
-
-pub(crate) fn open_db(path: &PathBuf, opt: &OpenOpt) -> Result<Db> {
-	info!("Opening LMDB database at: {}", path.display());
-	if let Err(e) = std::fs::create_dir_all(&path) {
-		return Err(Error(
-			format!("Unable to create LMDB data directory: {}", e).into(),
-		));
-	}
-
-	let map_size = match opt.lmdb_map_size {
-		None => recommended_map_size(),
-		Some(v) => v - (v % 4096),
-	};
-
-	let mut env_builder = heed::EnvOpenOptions::new();
-	env_builder.max_dbs(100);
-	env_builder.map_size(map_size);
-	env_builder.max_readers(2048);
-	unsafe {
-		env_builder.flag(heed::flags::Flags::MdbNoRdAhead);
-		env_builder.flag(heed::flags::Flags::MdbNoMetaSync);
-		if !opt.fsync {
-			env_builder.flag(heed::flags::Flags::MdbNoSync);
-		}
-	}
-	match env_builder.open(&path) {
-		Err(heed::Error::Io(e)) if e.kind() == std::io::ErrorKind::OutOfMemory => {
-			return Err(Error(
-				"OutOfMemory error while trying to open LMDB database. This can happen \
-                if your operating system is not allowing you to use sufficient virtual \
-                memory address space. Please check that no limit is set (ulimit -v). \
-                You may also try to set a smaller `lmdb_map_size` configuration parameter. \
-                On 32-bit machines, you should probably switch to another database engine."
-					.into(),
-			))
-		}
-		Err(e) => Err(Error(format!("Cannot open LMDB database: {}", e).into())),
-		Ok(db) => Ok(LmdbDb::init(db)),
-	}
-}
-
 // -- err
 
 impl From<heed::Error> for Error {
@@ -147,11 +104,12 @@ impl IDb for LmdbDb {
 		Ok(ret2)
 	}
 
-	fn snapshot(&self, base_path: &PathBuf) -> Result<()> {
+	fn snapshot(&self, to: &PathBuf) -> Result<()> {
-		std::fs::create_dir_all(base_path)?;
+		std::fs::create_dir_all(to)?;
-		let path = Engine::Lmdb.db_path(base_path);
+		let mut path = to.clone();
+		path.push("data.mdb");
 		self.db
-			.copy_to_path(path, heed::CompactionOption::Enabled)?;
+			.copy_to_path(path, heed::CompactionOption::Disabled)?;
 		Ok(())
 	}
 
@@ -168,16 +126,11 @@ impl IDb for LmdbDb {
 		}
 	}
 
-	fn approximate_len(&self, tree: usize) -> Result<usize> {
+	fn len(&self, tree: usize) -> Result<usize> {
 		let tree = self.get_tree(tree)?;
 		let tx = self.db.read_txn()?;
 		Ok(tree.len(&tx)?.try_into().unwrap())
 	}
-	fn is_empty(&self, tree: usize) -> Result<bool> {
-		let tree = self.get_tree(tree)?;
-		let tx = self.db.read_txn()?;
-		Ok(tree.is_empty(&tx)?)
-	}
 
 	fn insert(&self, tree: usize, key: &[u8], value: &[u8]) -> Result<()> {
 		let tree = self.get_tree(tree)?;
@@ -206,15 +159,13 @@ impl IDb for LmdbDb {
 	fn iter(&self, tree: usize) -> Result<ValueIter<'_>> {
 		let tree = self.get_tree(tree)?;
 		let tx = self.db.read_txn()?;
-		// Safety: the cloture does not store its argument anywhere,
+		TxAndIterator::make(tx, |tx| Ok(tree.iter(tx)?))
-		unsafe { TxAndIterator::make(tx, |tx| Ok(tree.iter(tx)?)) }
 	}
 
 	fn iter_rev(&self, tree: usize) -> Result<ValueIter<'_>> {
 		let tree = self.get_tree(tree)?;
 		let tx = self.db.read_txn()?;
-		// Safety: the cloture does not store its argument anywhere,
+		TxAndIterator::make(tx, |tx| Ok(tree.rev_iter(tx)?))
-		unsafe { TxAndIterator::make(tx, |tx| Ok(tree.rev_iter(tx)?)) }
 	}
 
 	fn range<'r>(
@@ -225,8 +176,7 @@ impl IDb for LmdbDb {
 	) -> Result<ValueIter<'_>> {
 		let tree = self.get_tree(tree)?;
 		let tx = self.db.read_txn()?;
-		// Safety: the cloture does not store its argument anywhere,
+		TxAndIterator::make(tx, |tx| Ok(tree.range(tx, &(low, high))?))
-		unsafe { TxAndIterator::make(tx, |tx| Ok(tree.range(tx, &(low, high))?)) }
 	}
 	fn range_rev<'r>(
 		&self,
@@ -236,8 +186,7 @@ impl IDb for LmdbDb {
 	) -> Result<ValueIter<'_>> {
 		let tree = self.get_tree(tree)?;
 		let tx = self.db.read_txn()?;
-		// Safety: the cloture does not store its argument anywhere,
+		TxAndIterator::make(tx, |tx| Ok(tree.rev_range(tx, &(low, high))?))
-		unsafe { TxAndIterator::make(tx, |tx| Ok(tree.rev_range(tx, &(low, high))?)) }
 	}
 
 	// ----
@@ -367,41 +316,28 @@ where
 {
 	tx: RoTxn<'a>,
 	iter: Option<I>,
-	_pin: PhantomPinned,
 }
 
 impl<'a, I> TxAndIterator<'a, I>
 where
 	I: Iterator<Item = IteratorItem<'a>> + 'a,
 {
-	fn iter(self: Pin<&mut Self>) -> &mut Option<I> {
+	fn make<F>(tx: RoTxn<'a>, iterfun: F) -> Result<ValueIter<'a>>
-		// Safety: iter is not structural
-		unsafe { &mut self.get_unchecked_mut().iter }
-	}
-
-	/// Safety: iterfun must not store its argument anywhere but in its result.
-	unsafe fn make<F>(tx: RoTxn<'a>, iterfun: F) -> Result<ValueIter<'a>>
 	where
 		F: FnOnce(&'a RoTxn<'a>) -> Result<I>,
 	{
-		let res = TxAndIterator {
+		let res = TxAndIterator { tx, iter: None };
-			tx,
-			iter: None,
-			_pin: PhantomPinned,
-		};
 		let mut boxed = Box::pin(res);
 
-		let tx_lifetime_overextended: &'a RoTxn<'a> = {
+		// This unsafe allows us to bypass lifetime checks
-			let tx = &boxed.tx;
+		let tx = unsafe { NonNull::from(&boxed.tx).as_ref() };
-			// Safety: Artificially extending the lifetime because
+		let iter = iterfun(tx)?;
-			// this reference will only be stored and accessed from the
-			// returned ValueIter which guarantees that it is destroyed
-			// before the tx it is pointing  to.
-			unsafe { &*&raw const *tx }
-		};
-		let iter = iterfun(&tx_lifetime_overextended)?;
 
-		*boxed.as_mut().iter() = Some(iter);
+		let mut_ref = Pin::as_mut(&mut boxed);
+		// This unsafe allows us to write in a field of the pinned struct
+		unsafe {
+			Pin::get_unchecked_mut(mut_ref).iter = Some(iter);
+		}
 
 		Ok(Box::new(TxAndIteratorPin(boxed)))
 	}
@@ -412,10 +348,8 @@ where
 	I: Iterator<Item = IteratorItem<'a>> + 'a,
 {
 	fn drop(&mut self) {
-		// Safety: `new_unchecked` is okay because we know this value is never
+		// ensure the iterator is dropped before the RoTxn it references
-		// used again after being dropped.
+		drop(self.iter.take());
-		let this = unsafe { Pin::new_unchecked(self) };
-		drop(this.iter().take());
 	}
 }
 
@@ -431,12 +365,13 @@ where
 
 	fn next(&mut self) -> Option<Self::Item> {
 		let mut_ref = Pin::as_mut(&mut self.0);
-		let next = mut_ref.iter().as_mut()?.next()?;
+		// This unsafe allows us to mutably access the iterator field
-		let res = match next {
+		let next = unsafe { Pin::get_unchecked_mut(mut_ref).iter.as_mut()?.next() };
-			Err(e) => Err(e.into()),
+		match next {
-			Ok((k, v)) => Ok((k.to_vec(), v.to_vec())),
+			None => None,
-		};
+			Some(Err(e)) => Some(Err(e.into())),
-		Some(res)
+			Some(Ok((k, v))) => Some(Ok((k.to_vec(), v.to_vec()))),
+		}
 	}
 }
 

src/db/open.rs

@@ -11,7 +11,6 @@ use crate::{Db, Error, Result};
 pub enum Engine {
 	Lmdb,
 	Sqlite,
-	Fjall,
 }
 
 impl Engine {
@@ -20,26 +19,8 @@ impl Engine {
 		match self {
 			Self::Lmdb => "lmdb",
 			Self::Sqlite => "sqlite",
-			Self::Fjall => "fjall",
 		}
 	}
-
-	/// Return engine-specific DB path from base path
-	pub fn db_path(&self, base_path: &PathBuf) -> PathBuf {
-		let mut ret = base_path.clone();
-		match self {
-			Self::Lmdb => {
-				ret.push("db.lmdb");
-			}
-			Self::Sqlite => {
-				ret.push("db.sqlite");
-			}
-			Self::Fjall => {
-				ret.push("db.fjall");
-			}
-		}
-		ret
-	}
 }
 
 impl std::fmt::Display for Engine {
@@ -55,11 +36,10 @@ impl std::str::FromStr for Engine {
 		match text {
 			"lmdb" | "heed" => Ok(Self::Lmdb),
 			"sqlite" | "sqlite3" | "rusqlite" => Ok(Self::Sqlite),
-            "fjall" => Ok(Self::Fjall),
 			"sled" => Err(Error("Sled is no longer supported as a database engine. Converting your old metadata db can be done using an older Garage binary (e.g. v0.9.4).".into())),
 			kind => Err(Error(
 				format!(
-					"Invalid DB engine: {} (options are: lmdb, sqlite, fjall)",
+					"Invalid DB engine: {} (options are: lmdb, sqlite)",
 					kind
 				)
 				.into(),
@@ -71,7 +51,6 @@ impl std::str::FromStr for Engine {
 pub struct OpenOpt {
 	pub fsync: bool,
 	pub lmdb_map_size: Option<usize>,
-	pub fjall_block_cache_size: Option<usize>,
 }
 
 impl Default for OpenOpt {
@@ -79,7 +58,6 @@ impl Default for OpenOpt {
 		Self {
 			fsync: false,
 			lmdb_map_size: None,
-			fjall_block_cache_size: None,
 		}
 	}
 }
@@ -88,15 +66,53 @@ pub fn open_db(path: &PathBuf, engine: Engine, opt: &OpenOpt) -> Result<Db> {
 	match engine {
 		// ---- Sqlite DB ----
 		#[cfg(feature = "sqlite")]
-		Engine::Sqlite => crate::sqlite_adapter::open_db(path, opt),
+		Engine::Sqlite => {
+			info!("Opening Sqlite database at: {}", path.display());
+			let manager = r2d2_sqlite::SqliteConnectionManager::file(path);
+			Ok(crate::sqlite_adapter::SqliteDb::new(manager, opt.fsync)?)
+		}
 
 		// ---- LMDB DB ----
 		#[cfg(feature = "lmdb")]
-		Engine::Lmdb => crate::lmdb_adapter::open_db(path, opt),
+		Engine::Lmdb => {
+			info!("Opening LMDB database at: {}", path.display());
+			if let Err(e) = std::fs::create_dir_all(&path) {
+				return Err(Error(
+					format!("Unable to create LMDB data directory: {}", e).into(),
+				));
+			}
 
-		// ---- Fjall DB ----
+			let map_size = match opt.lmdb_map_size {
-		#[cfg(feature = "fjall")]
+				None => crate::lmdb_adapter::recommended_map_size(),
-		Engine::Fjall => crate::fjall_adapter::open_db(path, opt),
+				Some(v) => v - (v % 4096),
+			};
+
+			let mut env_builder = heed::EnvOpenOptions::new();
+			env_builder.max_dbs(100);
+			env_builder.map_size(map_size);
+			env_builder.max_readers(2048);
+			unsafe {
+				env_builder.flag(crate::lmdb_adapter::heed::flags::Flags::MdbNoRdAhead);
+				env_builder.flag(crate::lmdb_adapter::heed::flags::Flags::MdbNoMetaSync);
+				if !opt.fsync {
+					env_builder.flag(heed::flags::Flags::MdbNoSync);
+				}
+			}
+			match env_builder.open(&path) {
+				Err(heed::Error::Io(e)) if e.kind() == std::io::ErrorKind::OutOfMemory => {
+					return Err(Error(
+						"OutOfMemory error while trying to open LMDB database. This can happen \
+                        if your operating system is not allowing you to use sufficient virtual \
+                        memory address space. Please check that no limit is set (ulimit -v). \
+                        You may also try to set a smaller `lmdb_map_size` configuration parameter. \
+                        On 32-bit machines, you should probably switch to another database engine."
+							.into(),
+					))
+				}
+				Err(e) => Err(Error(format!("Cannot open LMDB database: {}", e).into())),
+				Ok(db) => Ok(crate::lmdb_adapter::LmdbDb::init(db)),
+			}
+		}
 
 		// Pattern is unreachable when all supported DB engines are compiled into binary. The allow
 		// attribute is added so that we won't have to change this match in case stop building

src/db/sqlite_adapter.rs

@@ -11,23 +11,12 @@ use r2d2_sqlite::SqliteConnectionManager;
 use rusqlite::{params, Rows, Statement, Transaction};
 
 use crate::{
-	open::{Engine, OpenOpt},
 	Db, Error, IDb, ITx, ITxFn, OnCommit, Result, TxError, TxFnResult, TxOpError, TxOpResult,
 	TxResult, TxValueIter, Value, ValueIter,
 };
 
 pub use rusqlite;
 
-// ---- top-level open function
-
-pub(crate) fn open_db(path: &PathBuf, opt: &OpenOpt) -> Result<Db> {
-	info!("Opening Sqlite database at: {}", path.display());
-	let manager = r2d2_sqlite::SqliteConnectionManager::file(path);
-	Ok(SqliteDb::new(manager, opt.fsync)?)
-}
-
-// ----
-
 type Connection = r2d2::PooledConnection<SqliteConnectionManager>;
 
 // --- err
@@ -150,32 +139,17 @@ impl IDb for SqliteDb {
 		Ok(trees)
 	}
 
-	fn snapshot(&self, base_path: &PathBuf) -> Result<()> {
+	fn snapshot(&self, to: &PathBuf) -> Result<()> {
 		fn progress(p: rusqlite::backup::Progress) {
-			use std::sync::atomic::{AtomicU64, Ordering};
+			let percent = (p.pagecount - p.remaining) * 100 / p.pagecount;
-			use std::time::{SystemTime, UNIX_EPOCH};
+			info!("Sqlite snapshot progress: {}%", percent);
-
-			static LAST_LOG_TIME: AtomicU64 = AtomicU64::new(0);
-
-			let now = SystemTime::now()
-				.duration_since(UNIX_EPOCH)
-				.expect("Fix your clock :o")
-				.as_millis() as u64;
-			if now >= LAST_LOG_TIME.load(Ordering::Relaxed) + 10 * 1000 {
-				let percent = (p.pagecount - p.remaining) * 100 / p.pagecount;
-				info!("Sqlite snapshot progress: {}%", percent);
-
-				LAST_LOG_TIME.fetch_max(now, Ordering::Relaxed);
-			}
 		}
-
+		std::fs::create_dir_all(to)?;
-		std::fs::create_dir_all(base_path)?;
+		let mut path = to.clone();
-		let path = Engine::Sqlite.db_path(&base_path);
+		path.push("db.sqlite");
-
 		self.db
 			.get()?
 			.backup(rusqlite::DatabaseName::Main, path, Some(progress))?;
-
 		Ok(())
 	}
 
@@ -186,7 +160,7 @@ impl IDb for SqliteDb {
 		self.internal_get(&self.db.get()?, &tree, key)
 	}
 
-	fn approximate_len(&self, tree: usize) -> Result<usize> {
+	fn len(&self, tree: usize) -> Result<usize> {
 		let tree = self.get_tree(tree)?;
 		let db = self.db.get()?;
 
@@ -198,10 +172,6 @@ impl IDb for SqliteDb {
 		}
 	}
 
-	fn is_empty(&self, tree: usize) -> Result<bool> {
-		Ok(self.approximate_len(tree)? == 0)
-	}
-
 	fn insert(&self, tree: usize, key: &[u8], value: &[u8]) -> Result<()> {
 		let tree = self.get_tree(tree)?;
 		let db = self.db.get()?;

src/db/test.rs

@@ -1,7 +1,7 @@
 use crate::*;
 
 fn test_suite(db: Db) {
-	let tree = db.open_tree("tree:this_is_a_tree").unwrap();
+	let tree = db.open_tree("tree").unwrap();
 
 	let ka: &[u8] = &b"test"[..];
 	let kb: &[u8] = &b"zwello"[..];
@@ -14,7 +14,7 @@ fn test_suite(db: Db) {
 
 	assert!(tree.insert(ka, va).is_ok());
 	assert_eq!(tree.get(ka).unwrap().unwrap(), va);
-	assert_eq!(tree.iter().unwrap().count(), 1);
+	assert_eq!(tree.len().unwrap(), 1);
 
 	// ---- test transaction logic ----
 
@@ -148,15 +148,3 @@ fn test_sqlite_db() {
 	let db = SqliteDb::new(manager, false).unwrap();
 	test_suite(db);
 }
-
-#[test]
-#[cfg(feature = "fjall")]
-fn test_fjall_db() {
-	use crate::fjall_adapter::{fjall, FjallDb};
-
-	let path = mktemp::Temp::new_dir().unwrap();
-	let config = fjall::Config::new(path).temporary(true);
-	let keyspace = config.open_transactional().unwrap();
-	let db = FjallDb::init(keyspace);
-	test_suite(db);
-}

src/garage/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "garage"
-version = "1.2.0"
+version = "1.1.0"
 authors = ["Alex Auvolat <alex@adnab.me>"]
 edition = "2018"
 license = "AGPL-3.0"
@@ -49,8 +49,6 @@ structopt.workspace = true
 git-version.workspace = true
 
 serde.workspace = true
-serde_json.workspace = true
-serde_bytes.workspace = true
 
 futures.workspace = true
 tokio.workspace = true
@@ -59,13 +57,11 @@ opentelemetry.workspace = true
 opentelemetry-prometheus = { workspace = true, optional = true }
 opentelemetry-otlp = { workspace = true, optional = true }
 syslog-tracing = { workspace = true, optional = true }
-tracing-journald = { workspace = true, optional = true }
 
 [dev-dependencies]
 garage_api_common.workspace = true
 
 aws-sdk-s3.workspace = true
-aws-smithy-runtime.workspace = true
 chrono.workspace = true
 http.workspace = true
 hmac.workspace = true
@@ -93,7 +89,6 @@ k2v = [ "garage_util/k2v", "garage_api_k2v" ]
 # Database engines
 lmdb = [ "garage_model/lmdb" ]
 sqlite = [ "garage_model/sqlite" ]
-fjall = [ "garage_model/fjall" ]
 
 # Automatic registration and discovery via Consul API
 consul-discovery = [ "garage_rpc/consul-discovery" ]
@@ -105,8 +100,6 @@ metrics = [ "garage_api_admin/metrics", "opentelemetry-prometheus" ]
 telemetry-otlp = [ "opentelemetry-otlp" ]
 # Logging to syslog
 syslog = [ "syslog-tracing" ]
-# Logging to journald
-journald = [ "tracing-journald" ]
 
 # NOTE: bundled-libs and system-libs should be treat as mutually exclusive;
 # exactly one of them should be enabled.

src/garage/admin/block.rs

@@ -101,7 +101,6 @@ impl AdminRpcHandler {
 		let mut obj_dels = 0;
 		let mut mpu_dels = 0;
 		let mut ver_dels = 0;
-		let mut br_dels = 0;
 
 		for hash in blocks {
 			let hash = hex::decode(hash).ok_or_bad_request("invalid hash")?;
@@ -132,19 +131,12 @@ impl AdminRpcHandler {
 						ver_dels += 1;
 					}
 				}
-				if !br.deleted.get() {
-					let mut br = br;
-					br.deleted.set();
-					self.garage.block_ref_table.insert(&br).await?;
-					br_dels += 1;
-				}
 			}
 		}
 
 		Ok(AdminRpc::Ok(format!(
-			"Purged {} blocks: marked {} block refs, {} versions, {} objects and {} multipart uploads as deleted",
+			"Purged {} blocks, {} versions, {} objects, {} multipart uploads",
 			blocks.len(),
-			br_dels,
 			ver_dels,
 			obj_dels,
 			mpu_dels,

src/garage/admin/bucket.rs

@@ -126,7 +126,7 @@ impl AdminRpcHandler {
 
 	#[allow(clippy::ptr_arg)]
 	async fn handle_create_bucket(&self, name: &String) -> Result<AdminRpc, Error> {
-		if !is_valid_bucket_name(name, self.garage.config.allow_punycode) {
+		if !is_valid_bucket_name(name) {
 			return Err(Error::BadRequest(format!(
 				"{}: {}",
 				name, INVALID_BUCKET_NAME_MESSAGE
@@ -390,9 +390,15 @@ impl AdminRpcHandler {
 		}
 
 		let website = if query.allow {
+			let (redirect_all, routing_rules) = match bucket_state.website_config.get() {
+				Some(wc) => (wc.redirect_all.clone(), wc.routing_rules.clone()),
+				None => (None, Vec::new()),
+			};
 			Some(WebsiteConfig {
 				index_document: query.index_document.clone(),
 				error_document: query.error_document.clone(),
+				redirect_all,
+				routing_rules,
 			})
 		} else {
 			None

src/garage/admin/mod.rs

@@ -219,7 +219,7 @@ impl AdminRpcHandler {
 
 		// Gather block manager statistics
 		writeln!(&mut ret, "\nBlock manager stats:").unwrap();
-		let rc_len = self.garage.block_manager.rc_approximate_len()?.to_string();
+		let rc_len = self.garage.block_manager.rc_len()?.to_string();
 
 		writeln!(
 			&mut ret,
@@ -230,13 +230,13 @@ impl AdminRpcHandler {
 		writeln!(
 			&mut ret,
 			"  resync queue length: {}",
-			self.garage.block_manager.resync.queue_approximate_len()?
+			self.garage.block_manager.resync.queue_len()?
 		)
 		.unwrap();
 		writeln!(
 			&mut ret,
 			"  blocks with resync errors: {}",
-			self.garage.block_manager.resync.errors_approximate_len()?
+			self.garage.block_manager.resync.errors_len()?
 		)
 		.unwrap();
 
@@ -346,21 +346,16 @@ impl AdminRpcHandler {
 		F: TableSchema + 'static,
 		R: TableReplication + 'static,
 	{
-		let data_len = t
+		let data_len = t.data.store.len().map_err(GarageError::from)?.to_string();
-			.data
+		let mkl_len = t.merkle_updater.merkle_tree_len()?.to_string();
-			.store
-			.approximate_len()
-			.map_err(GarageError::from)?
-			.to_string();
-		let mkl_len = t.merkle_updater.merkle_tree_approximate_len()?.to_string();
 
 		Ok(format!(
 			"  {}\t{}\t{}\t{}\t{}",
 			F::TABLE_NAME,
 			data_len,
 			mkl_len,
-			t.merkle_updater.todo_approximate_len()?,
+			t.merkle_updater.todo_len()?,
-			t.data.gc_todo_approximate_len()?
+			t.data.gc_todo_len()?
 		))
 	}
 

src/garage/cli/structs.rs

@@ -71,10 +71,6 @@ pub enum NodeOperation {
 	/// Connect to Garage node that is currently isolated from the system
 	#[structopt(name = "connect", version = garage_version())]
 	Connect(ConnectNodeOpt),
-
-	/// Dump the content of a metadata table as JSON lines
-	#[structopt(name = "dump", version = garage_version())]
-	Dump(DumpNodeOpt),
 }
 
 #[derive(StructOpt, Debug)]
@@ -92,12 +88,6 @@ pub struct ConnectNodeOpt {
 	pub(crate) node: String,
 }
 
-#[derive(StructOpt, Debug)]
-pub struct DumpNodeOpt {
-	/// Name of the data table to dump
-	pub(crate) what: String,
-}
-
 #[derive(StructOpt, Debug)]
 pub enum LayoutOperation {
 	/// Assign role to Garage node
@@ -488,9 +478,6 @@ pub enum RepairWhat {
 	/// Recalculate block reference counters
 	#[structopt(name = "block-rc", version = garage_version())]
 	BlockRc,
-	/// Fix inconsistency in bucket aliases (WARNING: EXPERIMENTAL)
-	#[structopt(name = "aliases", version = garage_version())]
-	Aliases,
 	/// Verify integrity of all blocks on disc
 	#[structopt(name = "scrub", version = garage_version())]
 	Scrub {

src/garage/main.rs

@@ -145,14 +145,11 @@ async fn main() {
 	let res = match opt.cmd {
 		Command::Server => server::run_server(opt.config_file, opt.secrets).await,
 		Command::OfflineRepair(repair_opt) => {
-			repair::offline::offline_repair(opt.config_file, opt.secrets, repair_opt)
+			repair::offline::offline_repair(opt.config_file, opt.secrets, repair_opt).await
 		}
 		Command::ConvertDb(conv_opt) => {
 			cli::convert_db::do_conversion(conv_opt).map_err(From::from)
 		}
-		Command::Node(NodeOperation::Dump(dump_opt)) => {
-			repair::offline::dump(opt.config_file, opt.secrets, dump_opt)
-		}
 		Command::Node(NodeOperation::NodeId(node_id_opt)) => {
 			node_id_command(opt.config_file, node_id_opt.quiet)
 		}
@@ -211,43 +208,6 @@ fn init_logging(opt: &Opt) {
 		}
 	}
 
-	if std::env::var("GARAGE_LOG_TO_JOURNALD")
-		.map(|x| x == "1" || x == "true")
-		.unwrap_or(false)
-	{
-		#[cfg(feature = "journald")]
-		{
-			use tracing_journald::{Priority, PriorityMappings};
-			use tracing_subscriber::layer::SubscriberExt;
-			use tracing_subscriber::util::SubscriberInitExt;
-
-			let registry = tracing_subscriber::registry()
-				.with(tracing_subscriber::fmt::layer().with_writer(std::io::sink))
-				.with(env_filter);
-			match tracing_journald::layer() {
-				Ok(layer) => {
-					registry
-						.with(layer.with_priority_mappings(PriorityMappings {
-							info: Priority::Informational,
-							debug: Priority::Debug,
-							..PriorityMappings::new()
-						}))
-						.init();
-				}
-				Err(e) => {
-					eprintln!("Couldn't connect to journald: {}.", e);
-					std::process::exit(1);
-				}
-			}
-			return;
-		}
-		#[cfg(not(feature = "journald"))]
-		{
-			eprintln!("Journald support is not enabled in this build.");
-			std::process::exit(1);
-		}
-	}
-
 	tracing_subscriber::fmt()
 		.with_writer(std::io::stderr)
 		.with_env_filter(env_filter)

src/garage/repair/offline.rs

@@ -1,18 +1,14 @@
-use std::io::Write;
 use std::path::PathBuf;
 
-use serde::Serialize;
-
 use garage_util::config::*;
 use garage_util::error::*;
 
 use garage_model::garage::Garage;
-use garage_table::{replication::TableReplication, *};
 
 use crate::cli::structs::*;
 use crate::secrets::{fill_secrets, Secrets};
 
-pub fn offline_repair(
+pub async fn offline_repair(
 	config_file: PathBuf,
 	secrets: Secrets,
 	opt: OfflineRepairOpt,
@@ -49,100 +45,3 @@ pub fn offline_repair(
 
 	Ok(())
 }
-
-pub fn dump(config_file: PathBuf, secrets: Secrets, opt: DumpNodeOpt) -> Result<(), Error> {
-	let what = opt.what.as_str();
-
-	info!("Loading configuration...");
-	let config = fill_secrets(read_config(config_file)?, secrets)?;
-
-	info!("Initializing Garage main data store...");
-	let garage = Garage::new(config)?;
-
-	match what {
-		"bucket" | "buckets" => dump_table_inner(&garage.bucket_table),
-		"bucket_alias" | "bucket_aliases" => dump_table_inner(&garage.bucket_alias_table),
-		"key" | "keys" => dump_table_inner(&garage.key_table),
-		"object" | "objects" => dump_table_inner(&garage.object_table),
-		"object_counter" | "object_counters" => Err(Error::Message(
-			"object_counters cannot be JSON-serialized".into(),
-		)),
-		"mpu" => dump_table_inner(&garage.mpu_table),
-		"mpu_counter" | "mpu_counters" => Err(Error::Message(
-			"mpu_counters cannot be JSON-serialized".into(),
-		)),
-		"version" | "versions" => dump_table_inner(&garage.version_table),
-		"block_ref" | "block_refs" => dump_table_inner(&garage.block_ref_table),
-		#[cfg(feature = "k2v")]
-		"k2v_item" | "k2v_items" => dump_table_inner(&garage.k2v.item_table),
-		//#[cfg(feature = "k2v")]
-		"k2v_counter" | "k2v_counters" => Err(Error::Message(
-			"k2v_counters cannot be JSON-serialized".into(),
-		)),
-		other => {
-			let mut stdout = std::io::stdout().lock();
-			match other {
-				"cluster_layout" => Err(Error::Message(
-					"cluster_layout cannot be JSON-serialized".into(),
-				)),
-				_ => Err(Error::Message(format!("invalid thing to dump: {}", what))),
-			}
-		}
-	}
-}
-
-#[derive(Serialize)]
-struct DumpEntry<'a, T: Serialize> {
-	#[serde(with = "serde_bytes")]
-	partition_key: &'a [u8],
-	#[serde(with = "serde_bytes")]
-	sort_key: &'a [u8],
-	entry: &'a T,
-}
-
-fn dump_table_inner<F, R>(table: &Table<F, R>) -> Result<(), Error>
-where
-	F: TableSchema,
-	R: TableReplication,
-{
-	eprintln!("Dumping table {}...", F::TABLE_NAME);
-
-	let mut stdout = std::io::stdout().lock();
-
-	for line in table.data.store.iter()? {
-		let (_k, v) = line?;
-		let v_dec = table.data.decode_entry(&v)?;
-		let pkh = v_dec.partition_key().hash();
-		let dump_entry = DumpEntry {
-			partition_key: pkh.as_slice(),
-			sort_key: v_dec.sort_key().sort_key(),
-			entry: &v_dec,
-		};
-		dump_line(&mut stdout, dump_entry)?;
-	}
-	stdout.flush()?;
-
-	Ok(())
-}
-
-fn dump_line<T: Serialize>(
-	mut stdout: &mut std::io::StdoutLock<'static>,
-	dump_entry: T,
-) -> Result<(), Error> {
-	let mut ser = serde_json::ser::Serializer::with_formatter(&mut stdout, DumpFormatter);
-	dump_entry.serialize(&mut ser)?;
-	stdout.write_all(b"\n")?;
-	Ok(())
-}
-
-struct DumpFormatter;
-impl serde_json::ser::Formatter for DumpFormatter {
-	fn write_byte_array<W>(&mut self, writer: &mut W, value: &[u8]) -> std::io::Result<()>
-	where
-		W: ?Sized + std::io::Write,
-	{
-		writer.write_all(b"\"")?;
-		writer.write_all(hex::encode(&value).as_bytes())?;
-		writer.write_all(b"\"")
-	}
-}

src/garage/repair/online.rs

@@ -88,10 +88,6 @@ pub async fn launch_online_repair(
 				garage.block_manager.clone(),
 			));
 		}
-		RepairWhat::Aliases => {
-			info!("Repairing bucket aliases (foreground)");
-			garage.locked_helper().await.repair_aliases().await?;
-		}
 	}
 	Ok(())
 }

src/garage/server.rs

@@ -183,21 +183,10 @@ fn watch_shutdown_signal() -> watch::Receiver<bool> {
 		let mut sigterm =
 			signal(SignalKind::terminate()).expect("Failed to install SIGTERM handler");
 		let mut sighup = signal(SignalKind::hangup()).expect("Failed to install SIGHUP handler");
-		loop {
+		tokio::select! {
-			tokio::select! {
+			_ = sigint.recv() => info!("Received SIGINT, shutting down."),
-					_ = sigint.recv() => {
+			_ = sigterm.recv() => info!("Received SIGTERM, shutting down."),
-						info!("Received SIGINT, shutting down.");
+			_ = sighup.recv() => info!("Received SIGHUP, shutting down."),
-						break
-					}
-					_ = sigterm.recv() => {
-						info!("Received SIGTERM, shutting down.");
-						break
-					}
-					_ = sighup.recv() => {
-						info!("Received SIGHUP, reload not supported.");
-						continue
-					}
-			}
 		}
 		send_cancel.send(true).unwrap();
 	});

src/garage/tests/common/garage.rs

@@ -63,8 +63,6 @@ rpc_bind_addr = "127.0.0.1:{rpc_port}"
 rpc_public_addr = "127.0.0.1:{rpc_port}"
 rpc_secret = "{secret}"
 
-allow_punycode = true
-
 [s3_api]
 s3_region = "{region}"
 api_bind_addr = "127.0.0.1:{s3_port}"

src/garage/tests/s3/website.rs

@@ -5,7 +5,10 @@ use crate::json_body;
 use assert_json_diff::assert_json_eq;
 use aws_sdk_s3::{
 	primitives::ByteStream,
-	types::{CorsConfiguration, CorsRule, ErrorDocument, IndexDocument, WebsiteConfiguration},
+	types::{
+		Condition, CorsConfiguration, CorsRule, ErrorDocument, IndexDocument, Protocol, Redirect,
+		RoutingRule, WebsiteConfiguration,
+	},
 };
 use http::{Request, StatusCode};
 use http_body_util::BodyExt;
@@ -535,116 +538,442 @@ async fn test_website_check_domain() {
 }
 
 #[tokio::test]
-async fn test_website_puny() {
+async fn test_website_redirect_full_bucket() {
-	const BCKT_NAME: &str = "xn--pda.eu";
+	const BCKT_NAME: &str = "my-redirect-full";
 	let ctx = common::context();
 	let bucket = ctx.create_bucket(BCKT_NAME);
 
-	let data = ByteStream::from_static(BODY);
+	let conf = WebsiteConfiguration::builder()
+		.routing_rules(
+			RoutingRule::builder()
+				.condition(Condition::builder().key_prefix_equals("").build())
+				.redirect(
+					Redirect::builder()
+						.protocol(Protocol::Https)
+						.host_name("other.tld")
+						.replace_key_prefix_with("")
+						.build(),
+				)
+				.build(),
+		)
+		.build();
+
+	ctx.client
+		.put_bucket_website()
+		.bucket(&bucket)
+		.website_configuration(conf)
+		.send()
+		.await
+		.unwrap();
+
+	let req = Request::builder()
+		.method("GET")
+		.uri(format!("http://127.0.0.1:{}/my-path", ctx.garage.web_port))
+		.header("Host", format!("{}.web.garage", BCKT_NAME))
+		.body(Body::new(Bytes::new()))
+		.unwrap();
+
+	let client = Client::builder(TokioExecutor::new()).build_http();
+	let resp = client.request(req).await.unwrap();
+	assert_eq!(resp.status(), StatusCode::FOUND);
+	assert_eq!(
+		resp.headers()
+			.get(hyper::header::LOCATION)
+			.unwrap()
+			.to_str()
+			.unwrap(),
+		"https://other.tld/my-path"
+	);
+}
+
+#[tokio::test]
+async fn test_website_redirect() {
+	const BCKT_NAME: &str = "my-redirect";
+	let ctx = common::context();
+	let bucket = ctx.create_bucket(BCKT_NAME);
 
 	ctx.client
 		.put_object()
 		.bucket(&bucket)
 		.key("index.html")
-		.body(data)
+		.body(ByteStream::from_static(b"index"))
+		.send()
+		.await
+		.unwrap();
+	ctx.client
+		.put_object()
+		.bucket(&bucket)
+		.key("404.html")
+		.body(ByteStream::from_static(b"main 404"))
+		.send()
+		.await
+		.unwrap();
+	ctx.client
+		.put_object()
+		.bucket(&bucket)
+		.key("static-file")
+		.body(ByteStream::from_static(b"static file"))
 		.send()
 		.await
 		.unwrap();
 
-	let client = Client::builder(TokioExecutor::new()).build_http();
+	let mut conf = WebsiteConfiguration::builder()
+		.index_document(
+			IndexDocument::builder()
+				.suffix("home.html")
+				.build()
+				.unwrap(),
+		)
+		.error_document(ErrorDocument::builder().key("404.html").build().unwrap());
 
-	let req = |suffix| {
+	for (prefix, condition) in [("unconditional", false), ("conditional", true)] {
+		let code = condition.then(|| "404".to_string());
+		conf = conf
+			// simple redirect
+			.routing_rules(
+				RoutingRule::builder()
+					.condition(
+						Condition::builder()
+							.set_http_error_code_returned_equals(code.clone())
+							.key_prefix_equals(format!("{prefix}/redirect-prefix/"))
+							.build(),
+					)
+					.redirect(
+						Redirect::builder()
+							.http_redirect_code("302")
+							.replace_key_prefix_with("other-prefix/")
+							.build(),
+					)
+					.build(),
+			)
+			.routing_rules(
+				RoutingRule::builder()
+					.condition(
+						Condition::builder()
+							.set_http_error_code_returned_equals(code.clone())
+							.key_prefix_equals(format!("{prefix}/redirect-prefix-307/"))
+							.build(),
+					)
+					.redirect(
+						Redirect::builder()
+							.http_redirect_code("307")
+							.replace_key_prefix_with("other-prefix/")
+							.build(),
+					)
+					.build(),
+			)
+			// simple redirect
+			.routing_rules(
+				RoutingRule::builder()
+					.condition(
+						Condition::builder()
+							.set_http_error_code_returned_equals(code.clone())
+							.key_prefix_equals(format!("{prefix}/redirect-fixed/"))
+							.build(),
+					)
+					.redirect(
+						Redirect::builder()
+							.http_redirect_code("302")
+							.replace_key_with("fixed_key")
+							.build(),
+					)
+					.build(),
+			)
+			// stream other file
+			.routing_rules(
+				RoutingRule::builder()
+					.condition(
+						Condition::builder()
+							.set_http_error_code_returned_equals(code.clone())
+							.key_prefix_equals(format!("{prefix}/stream-fixed/"))
+							.build(),
+					)
+					.redirect(
+						Redirect::builder()
+							.http_redirect_code("200")
+							.replace_key_with("static-file")
+							.build(),
+					)
+					.build(),
+			)
+			// stream other file as error
+			.routing_rules(
+				RoutingRule::builder()
+					.condition(
+						Condition::builder()
+							.set_http_error_code_returned_equals(code.clone())
+							.key_prefix_equals(format!("{prefix}/stream-404/"))
+							.build(),
+					)
+					.redirect(
+						Redirect::builder()
+							.http_redirect_code("404")
+							.replace_key_with("static-file")
+							.build(),
+					)
+					.build(),
+			)
+			// fail to stream other file
+			.routing_rules(
+				RoutingRule::builder()
+					.condition(
+						Condition::builder()
+							.set_http_error_code_returned_equals(code.clone())
+							.key_prefix_equals(format!("{prefix}/stream-missing/"))
+							.build(),
+					)
+					.redirect(
+						Redirect::builder()
+							.http_redirect_code("200")
+							.replace_key_with("missing-file")
+							.build(),
+					)
+					.build(),
+			);
+	}
+	let conf = conf.build();
+
+	ctx.client
+		.put_bucket_website()
+		.bucket(&bucket)
+		.website_configuration(conf.clone())
+		.send()
+		.await
+		.unwrap();
+
+	let stored_cfg = ctx
+		.client
+		.get_bucket_website()
+		.bucket(&bucket)
+		.send()
+		.await
+		.unwrap();
+	assert_eq!(stored_cfg.index_document, conf.index_document);
+	assert_eq!(stored_cfg.error_document, conf.error_document);
+	assert_eq!(stored_cfg.routing_rules, conf.routing_rules);
+
+	let req = |path| {
 		Request::builder()
 			.method("GET")
-			.uri(format!("http://127.0.0.1:{}/", ctx.garage.web_port))
+			.uri(format!(
-			.header("Host", format!("{}{}", BCKT_NAME, suffix))
+				"http://127.0.0.1:{}/{}/path",
+				ctx.garage.web_port, path
+			))
+			.header("Host", format!("{}.web.garage", BCKT_NAME))
 			.body(Body::new(Bytes::new()))
 			.unwrap()
 	};
 
-	ctx.garage
+	test_redirect_helper("unconditional", true, &req).await;
-		.command()
+	test_redirect_helper("conditional", true, &req).await;
-		.args(["bucket", "website", "--allow", BCKT_NAME])
+	for prefix in ["unconditional", "conditional"] {
-		.quiet()
+		for rule_path in [
-		.expect_success_status("Could not allow website on bucket");
+			"redirect-prefix",
+			"redirect-prefix-307",
+			"redirect-fixed",
+			"stream-fixed",
+			"stream-404",
+			"stream-missing",
+		] {
+			ctx.client
+				.put_object()
+				.bucket(&bucket)
+				.key(format!("{prefix}/{rule_path}/path"))
+				.body(ByteStream::from_static(b"i exist"))
+				.send()
+				.await
+				.unwrap();
+		}
+	}
+	test_redirect_helper("unconditional", true, &req).await;
+	test_redirect_helper("conditional", false, &req).await;
+}
 
-	let mut resp = client.request(req("")).await.unwrap();
+async fn test_redirect_helper(
-	assert_eq!(resp.status(), StatusCode::OK);
+	prefix: &str,
-	assert_eq!(
+	should_see_redirect: bool,
-		resp.into_body().collect().await.unwrap().to_bytes(),
+	req: impl Fn(String) -> Request<http_body_util::Full<Bytes>>,
-		BODY.as_ref()
+) {
-	);
+	use http::header;
+	let client = Client::builder(TokioExecutor::new()).build_http();
+	let expected_body = b"i exist".as_ref();
 
-	resp = client.request(req(".web.garage")).await.unwrap();
+	let resp = client
-	assert_eq!(resp.status(), StatusCode::OK);
+		.request(req(format!("{prefix}/redirect-prefix")))
-	assert_eq!(
+		.await
-		resp.into_body().collect().await.unwrap().to_bytes(),
+		.unwrap();
-		BODY.as_ref()
+	if should_see_redirect {
-	);
+		assert_eq!(resp.status(), StatusCode::FOUND);
-
-	for bname in [
-		BCKT_NAME.to_string(),
-		format!("{BCKT_NAME}.web.garage"),
-		format!("{BCKT_NAME}.s3.garage"),
-	] {
-		let admin_req = || {
-			Request::builder()
-				.method("GET")
-				.uri(format!(
-					"http://127.0.0.1:{0}/check?domain={1}",
-					ctx.garage.admin_port, bname
-				))
-				.body(Body::new(Bytes::new()))
-				.unwrap()
-		};
-
-		let admin_resp = client.request(admin_req()).await.unwrap();
-		assert_eq!(admin_resp.status(), StatusCode::OK);
 		assert_eq!(
-			admin_resp.into_body().collect().await.unwrap().to_bytes(),
+			resp.headers()
-			format!("Domain '{bname}' is managed by Garage").as_bytes()
+				.get(header::LOCATION)
+				.unwrap()
+				.to_str()
+				.unwrap(),
+			"/other-prefix/path"
+		);
+		assert!(resp
+			.into_body()
+			.collect()
+			.await
+			.unwrap()
+			.to_bytes()
+			.is_empty());
+	} else {
+		assert_eq!(resp.status(), StatusCode::OK);
+		assert!(resp.headers().get(header::LOCATION).is_none());
+		assert_eq!(
+			resp.into_body().collect().await.unwrap().to_bytes(),
+			expected_body,
+		);
+	}
+
+	let resp = client
+		.request(req(format!("{prefix}/redirect-prefix-307")))
+		.await
+		.unwrap();
+	if should_see_redirect {
+		assert_eq!(resp.status(), StatusCode::TEMPORARY_REDIRECT);
+		assert_eq!(
+			resp.headers()
+				.get(header::LOCATION)
+				.unwrap()
+				.to_str()
+				.unwrap(),
+			"/other-prefix/path"
+		);
+		assert!(resp
+			.into_body()
+			.collect()
+			.await
+			.unwrap()
+			.to_bytes()
+			.is_empty());
+	} else {
+		assert_eq!(resp.status(), StatusCode::OK);
+		assert!(resp.headers().get(header::LOCATION).is_none());
+		assert_eq!(
+			resp.into_body().collect().await.unwrap().to_bytes(),
+			expected_body,
+		);
+	}
+
+	let resp = client
+		.request(req(format!("{prefix}/redirect-fixed")))
+		.await
+		.unwrap();
+	if should_see_redirect {
+		assert_eq!(resp.status(), StatusCode::FOUND);
+		assert_eq!(
+			resp.headers()
+				.get(header::LOCATION)
+				.unwrap()
+				.to_str()
+				.unwrap(),
+			"/fixed_key"
+		);
+		assert!(resp
+			.into_body()
+			.collect()
+			.await
+			.unwrap()
+			.to_bytes()
+			.is_empty());
+	} else {
+		assert_eq!(resp.status(), StatusCode::OK);
+		assert!(resp.headers().get(header::LOCATION).is_none());
+		assert_eq!(
+			resp.into_body().collect().await.unwrap().to_bytes(),
+			expected_body,
+		);
+	}
+	let resp = client
+		.request(req(format!("{prefix}/stream-fixed")))
+		.await
+		.unwrap();
+	if should_see_redirect {
+		assert_eq!(resp.status(), StatusCode::OK);
+		assert!(resp.headers().get(header::LOCATION).is_none());
+		assert_eq!(
+			resp.into_body().collect().await.unwrap().to_bytes(),
+			b"static file".as_ref(),
+		);
+	} else {
+		assert_eq!(resp.status(), StatusCode::OK);
+		assert!(resp.headers().get(header::LOCATION).is_none());
+		assert_eq!(
+			resp.into_body().collect().await.unwrap().to_bytes(),
+			expected_body,
+		);
+	}
+	let resp = client
+		.request(req(format!("{prefix}/stream-404")))
+		.await
+		.unwrap();
+	if should_see_redirect {
+		assert_eq!(resp.status(), StatusCode::NOT_FOUND);
+		assert!(resp.headers().get(header::LOCATION).is_none());
+		assert_eq!(
+			resp.into_body().collect().await.unwrap().to_bytes(),
+			b"static file".as_ref(),
+		);
+	} else {
+		assert_eq!(resp.status(), StatusCode::OK);
+		assert!(resp.headers().get(header::LOCATION).is_none());
+		assert_eq!(
+			resp.into_body().collect().await.unwrap().to_bytes(),
+			expected_body,
+		);
+	}
+	let resp = client
+		.request(req(format!("{prefix}/stream-404")))
+		.await
+		.unwrap();
+	if should_see_redirect {
+		assert_eq!(resp.status(), StatusCode::NOT_FOUND);
+		assert!(resp.headers().get(header::LOCATION).is_none());
+		assert_eq!(
+			resp.into_body().collect().await.unwrap().to_bytes(),
+			b"static file".as_ref(),
+		);
+	} else {
+		assert_eq!(resp.status(), StatusCode::OK);
+		assert!(resp.headers().get(header::LOCATION).is_none());
+		assert_eq!(
+			resp.into_body().collect().await.unwrap().to_bytes(),
+			expected_body,
 		);
 	}
 }
 
 #[tokio::test]
-async fn test_website_object_not_found() {
+async fn test_website_invalid_redirect() {
-	const BCKT_NAME: &str = "not-found";
+	const BCKT_NAME: &str = "my-invalid-redirect";
 	let ctx = common::context();
-	let _bucket = ctx.create_bucket(BCKT_NAME);
+	let bucket = ctx.create_bucket(BCKT_NAME);
 
-	let client = Client::builder(TokioExecutor::new()).build_http();
+	let conf = WebsiteConfiguration::builder()
+		.routing_rules(
+			RoutingRule::builder()
+				.condition(Condition::builder().key_prefix_equals("").build())
+				.redirect(
+					Redirect::builder()
+						.protocol(Protocol::Https)
+						.host_name("other.tld")
+						.replace_key_prefix_with("")
+						// we don't allow 200 with hostname
+						.http_redirect_code("200")
+						.build(),
+				)
+				.build(),
+		)
+		.build();
 
-	let req = |suffix| {
+	ctx.client
-		Request::builder()
+		.put_bucket_website()
-			.method("GET")
+		.bucket(&bucket)
-			.uri(format!("http://127.0.0.1:{}/", ctx.garage.web_port))
+		.website_configuration(conf)
-			.header("Host", format!("{}{}", BCKT_NAME, suffix))
+		.send()
-			.body(Body::new(Bytes::new()))
+		.await
-			.unwrap()
+		.unwrap_err();
-	};
-
-	ctx.garage
-		.command()
-		.args(["bucket", "website", "--allow", BCKT_NAME])
-		.quiet()
-		.expect_success_status("Could not allow website on bucket");
-
-	let resp = client.request(req("")).await.unwrap();
-	assert_eq!(resp.status(), StatusCode::NOT_FOUND);
-	// the error we return by default are *not* xml
-	assert_eq!(
-		resp.headers().get(http::header::CONTENT_TYPE).unwrap(),
-		"text/html; charset=utf-8"
-	);
-	let result = String::from_utf8(
-		resp.into_body()
-			.collect()
-			.await
-			.unwrap()
-			.to_bytes()
-			.to_vec(),
-	)
-	.unwrap();
-	assert!(result.contains("not found"));
 }

src/k2v-client/lib.rs

@@ -72,16 +72,6 @@ impl K2vClient {
 			.enable_http2()
 			.build();
 		let client = HttpClient::builder(TokioExecutor::new()).build(connector);
-		Self::new_with_client(config, client)
-	}
-
-	/// Create a new K2V client with an external client.
-	/// Useful for example if you plan on creating many clients but you want to mutualize the
-	/// underlying thread pools & co.
-	pub fn new_with_client(
-		config: K2vClientConfig,
-		client: HttpClient<HttpsConnector<HttpConnector>, Body>,
-	) -> Result<Self, Error> {
 		let user_agent: std::borrow::Cow<str> = match &config.user_agent {
 			Some(ua) => ua.into(),
 			None => format!("k2v/{}", env!("CARGO_PKG_VERSION")).into(),

src/model/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "garage_model"
-version = "1.2.0"
+version = "1.1.0"
 authors = ["Alex Auvolat <alex@adnab.me>"]
 edition = "2018"
 license = "AGPL-3.0"
@@ -44,4 +44,3 @@ default = [ "lmdb", "sqlite" ]
 k2v = [ "garage_util/k2v" ]
 lmdb = [ "garage_db/lmdb" ]
 sqlite = [ "garage_db/sqlite" ]
-fjall = [ "garage_db/fjall" ]

src/model/bucket_alias_table.rs

@@ -22,10 +22,14 @@ mod v08 {
 pub use v08::*;
 
 impl BucketAlias {
-	pub fn new(name: String, ts: u64, bucket_id: Option<Uuid>) -> Self {
+	pub fn new(name: String, ts: u64, bucket_id: Option<Uuid>) -> Option<Self> {
-		BucketAlias {
+		if !is_valid_bucket_name(&name) {
-			name,
+			None
-			state: crdt::Lww::raw(ts, bucket_id),
+		} else {
+			Some(BucketAlias {
+				name,
+				state: crdt::Lww::raw(ts, bucket_id),
+			})
 		}
 	}
 
@@ -76,7 +80,7 @@ impl TableSchema for BucketAliasTable {
 /// In the case of Garage, bucket names must not be hex-encoded
 /// 32 byte string, which is excluded thanks to the
 /// maximum length of 63 bytes given in the spec.
-pub fn is_valid_bucket_name(n: &str, puny: bool) -> bool {
+pub fn is_valid_bucket_name(n: &str) -> bool {
 	// Bucket names must be between 3 and 63 characters
 	n.len() >= 3 && n.len() <= 63
 	// Bucket names must be composed of lowercase letters, numbers,
@@ -88,9 +92,7 @@ pub fn is_valid_bucket_name(n: &str, puny: bool) -> bool {
 	// Bucket names must not be formatted as an IP address
 	&& n.parse::<std::net::IpAddr>().is_err()
 	// Bucket names must not start with "xn--"
-	&& (!n.starts_with("xn--") || puny)
+	&& !n.starts_with("xn--")
-        // We are a bit stricter, to properly restrict punycode in all labels
-	&& (!n.contains(".xn--") || puny)
 	// Bucket names must not end with "-s3alias"
 	&& !n.ends_with("-s3alias")
 }

src/model/bucket_table.rs

@@ -119,7 +119,122 @@ mod v08 {
 	impl garage_util::migrate::InitialFormat for Bucket {}
 }
 
-pub use v08::*;
+mod v2 {
+	use crate::permission::BucketKeyPerm;
+	use garage_util::crdt;
+	use garage_util::data::Uuid;
+	use serde::{Deserialize, Serialize};
+
+	use super::v08;
+
+	pub use v08::{BucketQuotas, CorsRule, LifecycleExpiration, LifecycleFilter, LifecycleRule};
+
+	#[derive(PartialEq, Eq, Clone, Debug, Serialize, Deserialize)]
+	pub struct Bucket {
+		/// ID of the bucket
+		pub id: Uuid,
+		/// State, and configuration if not deleted, of the bucket
+		pub state: crdt::Deletable<BucketParams>,
+	}
+
+	/// Configuration for a bucket
+	#[derive(PartialEq, Eq, Clone, Debug, Serialize, Deserialize)]
+	pub struct BucketParams {
+		/// Bucket's creation date
+		pub creation_date: u64,
+		/// Map of key with access to the bucket, and what kind of access they give
+		pub authorized_keys: crdt::Map<String, BucketKeyPerm>,
+
+		/// Map of aliases that are or have been given to this bucket
+		/// in the global namespace
+		/// (not authoritative: this is just used as an indication to
+		/// map back to aliases when doing ListBuckets)
+		pub aliases: crdt::LwwMap<String, bool>,
+		/// Map of aliases that are or have been given to this bucket
+		/// in namespaces local to keys
+		/// key = (access key id, alias name)
+		pub local_aliases: crdt::LwwMap<(String, String), bool>,
+
+		/// Whether this bucket is allowed for website access
+		/// (under all of its global alias names),
+		/// and if so, the website configuration XML document
+		pub website_config: crdt::Lww<Option<WebsiteConfig>>,
+		/// CORS rules
+		pub cors_config: crdt::Lww<Option<Vec<CorsRule>>>,
+		/// Lifecycle configuration
+		pub lifecycle_config: crdt::Lww<Option<Vec<LifecycleRule>>>,
+		/// Bucket quotas
+		pub quotas: crdt::Lww<BucketQuotas>,
+	}
+
+	#[derive(PartialEq, Eq, Clone, Debug, Serialize, Deserialize)]
+	pub struct WebsiteConfig {
+		pub index_document: String,
+		pub error_document: Option<String>,
+		// this field is currently unused, but present so adding it in the future doesn't
+		// need a new migration
+		pub redirect_all: Option<RedirectAll>,
+		pub routing_rules: Vec<RoutingRule>,
+	}
+
+	#[derive(PartialEq, Eq, Clone, Debug, Serialize, Deserialize)]
+	pub struct RedirectAll {
+		pub hostname: String,
+		pub protocol: String,
+	}
+
+	#[derive(PartialEq, Eq, Clone, Debug, Serialize, Deserialize)]
+	pub struct RoutingRule {
+		pub condition: Option<RedirectCondition>,
+		pub redirect: Redirect,
+	}
+
+	#[derive(PartialEq, Eq, Clone, Debug, Serialize, Deserialize)]
+	pub struct RedirectCondition {
+		pub http_error_code: Option<u16>,
+		pub prefix: Option<String>,
+	}
+
+	#[derive(PartialEq, Eq, Clone, Debug, Serialize, Deserialize)]
+	pub struct Redirect {
+		pub hostname: Option<String>,
+		pub http_redirect_code: u16,
+		pub protocol: Option<String>,
+		pub replace_key_prefix: Option<String>,
+		pub replace_key: Option<String>,
+	}
+
+	impl garage_util::migrate::Migrate for Bucket {
+		const VERSION_MARKER: &'static [u8] = b"G2bkt";
+
+		type Previous = v08::Bucket;
+
+		fn migrate(old: v08::Bucket) -> Bucket {
+			Bucket {
+				id: old.id,
+				state: old.state.map(|x| BucketParams {
+					creation_date: x.creation_date,
+					authorized_keys: x.authorized_keys,
+					aliases: x.aliases,
+					local_aliases: x.local_aliases,
+					website_config: x.website_config.map(|wc_opt| {
+						wc_opt.map(|wc| WebsiteConfig {
+							index_document: wc.index_document,
+							error_document: wc.error_document,
+							redirect_all: None,
+							routing_rules: vec![],
+						})
+					}),
+					cors_config: x.cors_config,
+					lifecycle_config: x.lifecycle_config,
+					quotas: x.quotas,
+				}),
+			}
+		}
+	}
+}
+
+pub use v2::*;
 
 impl AutoCrdt for BucketQuotas {
 	const WARN_IF_DIFFERENT: bool = true;

src/model/garage.rs

@@ -116,17 +116,21 @@ impl Garage {
 		info!("Opening database...");
 		let db_engine = db::Engine::from_str(&config.db_engine)
 			.ok_or_message("Invalid `db_engine` value in configuration file")?;
-		let db_path = db_engine.db_path(&config.metadata_dir);
+		let mut db_path = config.metadata_dir.clone();
+		match db_engine {
+			db::Engine::Sqlite => {
+				db_path.push("db.sqlite");
+			}
+			db::Engine::Lmdb => {
+				db_path.push("db.lmdb");
+			}
+		}
 		let db_opt = db::OpenOpt {
 			fsync: config.metadata_fsync,
 			lmdb_map_size: match config.lmdb_map_size {
 				v if v == usize::default() => None,
 				v => Some(v),
 			},
-			fjall_block_cache_size: match config.fjall_block_cache_size {
-				v if v == usize::default() => None,
-				v => Some(v),
-			},
 		};
 		let db = db::open_db(&db_path, db_engine, &db_opt)
 			.ok_or_message("Unable to open metadata db")?;

src/model/helper/locked.rs

@@ -1,7 +1,3 @@
-use std::collections::{HashMap, HashSet};
-
-use garage_db as db;
-
 use garage_util::crdt::*;
 use garage_util::data::*;
 use garage_util::error::{Error as GarageError, OkOrMessage};
@@ -51,10 +47,6 @@ impl<'a> LockedHelper<'a> {
 		KeyHelper(self.0)
 	}
 
-	// ================================================
-	//      global bucket aliases
-	// ================================================
-
 	/// Sets a new alias for a bucket in global namespace.
 	/// This function fails if:
 	/// - alias name is not valid according to S3 spec
@@ -65,7 +57,7 @@ impl<'a> LockedHelper<'a> {
 		bucket_id: Uuid,
 		alias_name: &String,
 	) -> Result<(), Error> {
-		if !is_valid_bucket_name(alias_name, self.0.config.allow_punycode) {
+		if !is_valid_bucket_name(alias_name) {
 			return Err(Error::InvalidBucketName(alias_name.to_string()));
 		}
 
@@ -96,7 +88,8 @@ impl<'a> LockedHelper<'a> {
 		// writes are now done and all writes use timestamp alias_ts
 
 		let alias = match alias {
-			None => BucketAlias::new(alias_name.clone(), alias_ts, Some(bucket_id)),
+			None => BucketAlias::new(alias_name.clone(), alias_ts, Some(bucket_id))
+				.ok_or_else(|| Error::InvalidBucketName(alias_name.clone()))?,
 			Some(mut a) => {
 				a.state = Lww::raw(alias_ts, Some(bucket_id));
 				a
@@ -187,14 +180,13 @@ impl<'a> LockedHelper<'a> {
 			.ok_or_else(|| Error::NoSuchBucket(alias_name.to_string()))?;
 
 		// Checks ok, remove alias
-		let alias_ts = increment_logical_clock_2(
+		let alias_ts = match bucket.state.as_option() {
-			alias.state.timestamp(),
+			Some(bucket_state) => increment_logical_clock_2(
-			bucket
+				alias.state.timestamp(),
-				.state
+				bucket_state.aliases.get_timestamp(alias_name),
-				.as_option()
+			),
-				.map(|p| p.aliases.get_timestamp(alias_name))
+			None => increment_logical_clock(alias.state.timestamp()),
-				.unwrap_or(0),
+		};
-		);
 
 		// ---- timestamp-ensured causality barrier ----
 		// writes are now done and all writes use timestamp alias_ts
@@ -212,10 +204,6 @@ impl<'a> LockedHelper<'a> {
 		Ok(())
 	}
 
-	// ================================================
-	//      local bucket aliases
-	// ================================================
-
 	/// Sets a new alias for a bucket in the local namespace of a key.
 	/// This function fails if:
 	/// - alias name is not valid according to S3 spec
@@ -228,12 +216,14 @@ impl<'a> LockedHelper<'a> {
 		key_id: &String,
 		alias_name: &String,
 	) -> Result<(), Error> {
-		if !is_valid_bucket_name(alias_name, self.0.config.allow_punycode) {
+		let key_helper = KeyHelper(self.0);
+
+		if !is_valid_bucket_name(alias_name) {
 			return Err(Error::InvalidBucketName(alias_name.to_string()));
 		}
 
 		let mut bucket = self.bucket().get_existing_bucket(bucket_id).await?;
-		let mut key = self.key().get_existing_key(key_id).await?;
+		let mut key = key_helper.get_existing_key(key_id).await?;
 
 		let key_param = key.state.as_option_mut().unwrap();
 
@@ -282,13 +272,23 @@ impl<'a> LockedHelper<'a> {
 		key_id: &String,
 		alias_name: &String,
 	) -> Result<(), Error> {
-		let mut bucket = self.bucket().get_existing_bucket(bucket_id).await?;
+		let key_helper = KeyHelper(self.0);
-		let mut key = self.key().get_existing_key(key_id).await?;
+
+		let mut bucket = self.bucket().get_existing_bucket(bucket_id).await?;
+		let mut key = key_helper.get_existing_key(key_id).await?;
 
-		let key_p = key.state.as_option().unwrap();
 		let bucket_p = bucket.state.as_option_mut().unwrap();
 
-		if key_p.local_aliases.get(alias_name).cloned().flatten() != Some(bucket_id) {
+		if key
+			.state
+			.as_option()
+			.unwrap()
+			.local_aliases
+			.get(alias_name)
+			.cloned()
+			.flatten()
+			!= Some(bucket_id)
+		{
 			return Err(GarageError::Message(format!(
 				"Bucket {:?} does not have alias {} in namespace of key {}",
 				bucket_id, alias_name, key_id
@@ -305,17 +305,17 @@ impl<'a> LockedHelper<'a> {
 			.local_aliases
 			.items()
 			.iter()
-			.any(|((k, n), _, active)| (*k != key.key_id || n != alias_name) && *active);
+			.any(|((k, n), _, active)| *k == key.key_id && n == alias_name && *active);
-
 		if !has_other_global_aliases && !has_other_local_aliases {
 			return Err(Error::BadRequest(format!("Bucket {} doesn't have other aliases, please delete it instead of just unaliasing.", alias_name)));
 		}
 
 		// Checks ok, remove alias
+		let key_param = key.state.as_option_mut().unwrap();
 		let bucket_p_local_alias_key = (key.key_id.clone(), alias_name.clone());
 
 		let alias_ts = increment_logical_clock_2(
-			key_p.local_aliases.get_timestamp(alias_name),
+			key_param.local_aliases.get_timestamp(alias_name),
 			bucket_p
 				.local_aliases
 				.get_timestamp(&bucket_p_local_alias_key),
@@ -324,8 +324,7 @@ impl<'a> LockedHelper<'a> {
 		// ---- timestamp-ensured causality barrier ----
 		// writes are now done and all writes use timestamp alias_ts
 
-		key.state.as_option_mut().unwrap().local_aliases =
+		key_param.local_aliases = LwwMap::raw_item(alias_name.clone(), alias_ts, None);
-			LwwMap::raw_item(alias_name.clone(), alias_ts, None);
 		self.0.key_table.insert(&key).await?;
 
 		bucket_p.local_aliases = LwwMap::raw_item(bucket_p_local_alias_key, alias_ts, false);
@@ -334,68 +333,21 @@ impl<'a> LockedHelper<'a> {
 		Ok(())
 	}
 
-	/// Ensures a bucket does not have a certain local alias.
-	/// Contrarily to unset_local_bucket_alias, this does not
-	/// fail on any condition other than:
-	/// - bucket cannot be found (its fine if it is in deleted state)
-	/// - key cannot be found (its fine if alias in key points to nothing
-	///   or to another bucket)
-	pub async fn purge_local_bucket_alias(
-		&self,
-		bucket_id: Uuid,
-		key_id: &String,
-		alias_name: &String,
-	) -> Result<(), Error> {
-		let mut bucket = self.bucket().get_internal_bucket(bucket_id).await?;
-		let mut key = self.key().get_internal_key(key_id).await?;
-
-		let bucket_p_local_alias_key = (key.key_id.clone(), alias_name.clone());
-
-		let alias_ts = increment_logical_clock_2(
-			key.state
-				.as_option()
-				.map(|p| p.local_aliases.get_timestamp(alias_name))
-				.unwrap_or(0),
-			bucket
-				.state
-				.as_option()
-				.map(|p| p.local_aliases.get_timestamp(&bucket_p_local_alias_key))
-				.unwrap_or(0),
-		);
-
-		// ---- timestamp-ensured causality barrier ----
-		// writes are now done and all writes use timestamp alias_ts
-
-		if let Some(kp) = key.state.as_option_mut() {
-			kp.local_aliases = LwwMap::raw_item(alias_name.clone(), alias_ts, None);
-			self.0.key_table.insert(&key).await?;
-		}
-
-		if let Some(bp) = bucket.state.as_option_mut() {
-			bp.local_aliases = LwwMap::raw_item(bucket_p_local_alias_key, alias_ts, false);
-			self.0.bucket_table.insert(&bucket).await?;
-		}
-
-		Ok(())
-	}
-
-	// ================================================
-	//      permissions
-	// ================================================
-
 	/// Sets permissions for a key on a bucket.
 	/// This function fails if:
 	/// - bucket or key cannot be found at all (its ok if they are in deleted state)
-	/// - bucket or key is in deleted state and we are trying to set
+	/// - bucket or key is in deleted state and we are trying to set permissions other than "deny
-	///   permissions other than "deny all"
+	/// all"
 	pub async fn set_bucket_key_permissions(
 		&self,
 		bucket_id: Uuid,
 		key_id: &String,
 		mut perm: BucketKeyPerm,
 	) -> Result<(), Error> {
+		let key_helper = KeyHelper(self.0);
+
 		let mut bucket = self.bucket().get_internal_bucket(bucket_id).await?;
-		let mut key = self.key().get_internal_key(key_id).await?;
+		let mut key = key_helper.get_internal_key(key_id).await?;
 
 		if let Some(bstate) = bucket.state.as_option() {
 			if let Some(kp) = bstate.authorized_keys.get(key_id) {
@@ -432,20 +384,21 @@ impl<'a> LockedHelper<'a> {
 		Ok(())
 	}
 
-	// ================================================
+	// ----
-	//      keys
-	// ================================================
 
 	/// Deletes an API access key
 	pub async fn delete_key(&self, key: &mut Key) -> Result<(), Error> {
 		let state = key.state.as_option_mut().unwrap();
 
 		// --- done checking, now commit ---
+		// (the step at unset_local_bucket_alias will fail if a bucket
+		// does not have another alias, the deletion will be
+		// interrupted in the middle if that happens)
 
 		// 1. Delete local aliases
 		for (alias, _, to) in state.local_aliases.items().iter() {
 			if let Some(bucket_id) = to {
-				self.purge_local_bucket_alias(*bucket_id, &key.key_id, alias)
+				self.unset_local_bucket_alias(*bucket_id, &key.key_id, alias)
 					.await?;
 			}
 		}
@@ -462,193 +415,4 @@ impl<'a> LockedHelper<'a> {
 
 		Ok(())
 	}
-
-	// ================================================
-	//      repair procedure
-	// ================================================
-
-	pub async fn repair_aliases(&self) -> Result<(), GarageError> {
-		self.0.db.transaction(|tx| {
-			info!("--- begin repair_aliases transaction ----");
-
-			// 1. List all non-deleted buckets, so that we can fix bad aliases
-			let mut all_buckets: HashSet<Uuid> = HashSet::new();
-
-			for item in tx.range::<&[u8], _>(&self.0.bucket_table.data.store, ..)? {
-				let bucket = self
-					.0
-					.bucket_table
-					.data
-					.decode_entry(&(item?.1))
-					.map_err(db::TxError::Abort)?;
-				if !bucket.is_deleted() {
-					all_buckets.insert(bucket.id);
-				}
-			}
-
-			info!("number of buckets: {}", all_buckets.len());
-
-			// 2. List all aliases declared in bucket_alias_table and key_table
-			//    Take note of aliases that point to non-existing buckets
-			let mut global_aliases: HashMap<String, Uuid> = HashMap::new();
-
-			{
-				let mut delete_global = vec![];
-				for item in tx.range::<&[u8], _>(&self.0.bucket_alias_table.data.store, ..)? {
-					let mut alias = self
-						.0
-						.bucket_alias_table
-						.data
-						.decode_entry(&(item?.1))
-						.map_err(db::TxError::Abort)?;
-					if let Some(id) = alias.state.get() {
-						if all_buckets.contains(id) {
-							// keep aliases
-							global_aliases.insert(alias.name().to_string(), *id);
-						} else {
-							// delete alias
-							warn!(
-								"global alias: remove {} -> {:?} (bucket is deleted)",
-								alias.name(),
-								id
-							);
-							alias.state.update(None);
-							delete_global.push(alias);
-						}
-					}
-				}
-
-				info!("number of global aliases: {}", global_aliases.len());
-
-				info!("global alias table: {} entries fixed", delete_global.len());
-				for ga in delete_global {
-					debug!("Enqueue update to global alias table: {:?}", ga);
-					self.0.bucket_alias_table.queue_insert(tx, &ga)?;
-				}
-			}
-
-			let mut local_aliases: HashMap<(String, String), Uuid> = HashMap::new();
-
-			{
-				let mut delete_local = vec![];
-
-				for item in tx.range::<&[u8], _>(&self.0.key_table.data.store, ..)? {
-					let mut key = self
-						.0
-						.key_table
-						.data
-						.decode_entry(&(item?.1))
-						.map_err(db::TxError::Abort)?;
-					let Some(p) = key.state.as_option_mut() else {
-						continue;
-					};
-					let mut has_changes = false;
-					for (name, _, to) in p.local_aliases.items().to_vec() {
-						if let Some(id) = to {
-							if all_buckets.contains(&id) {
-								local_aliases.insert((key.key_id.clone(), name), id);
-							} else {
-								warn!(
-									"local alias: remove ({}, {}) -> {:?} (bucket is deleted)",
-									key.key_id, name, id
-								);
-								p.local_aliases.update_in_place(name, None);
-								has_changes = true;
-							}
-						}
-					}
-					if has_changes {
-						delete_local.push(key);
-					}
-				}
-
-				info!("number of local aliases: {}", local_aliases.len());
-
-				info!("key table: {} entries fixed", delete_local.len());
-				for la in delete_local {
-					debug!("Enqueue update to key table: {:?}", la);
-					self.0.key_table.queue_insert(tx, &la)?;
-				}
-			}
-
-			// 4. Reverse the alias maps to determine the aliases per-bucket
-			let mut bucket_global: HashMap<Uuid, Vec<String>> = HashMap::new();
-			let mut bucket_local: HashMap<Uuid, Vec<(String, String)>> = HashMap::new();
-
-			for (name, bucket) in global_aliases {
-				bucket_global.entry(bucket).or_default().push(name);
-			}
-			for ((key, name), bucket) in local_aliases {
-				bucket_local.entry(bucket).or_default().push((key, name));
-			}
-
-			// 5. Fix the bucket table to ensure consistency
-			let mut bucket_updates = vec![];
-
-			for item in tx.range::<&[u8], _>(&self.0.bucket_table.data.store, ..)? {
-				let bucket = self
-					.0
-					.bucket_table
-					.data
-					.decode_entry(&(item?.1))
-					.map_err(db::TxError::Abort)?;
-				let mut bucket2 = bucket.clone();
-				let Some(param) = bucket2.state.as_option_mut() else {
-					continue;
-				};
-
-				// fix global aliases
-				{
-					let ga = bucket_global.remove(&bucket.id).unwrap_or_default();
-					for (name, _, active) in param.aliases.items().to_vec() {
-						if active && !ga.contains(&name) {
-							warn!("bucket {:?}: remove global alias {}", bucket.id, name);
-							param.aliases.update_in_place(name, false);
-						}
-					}
-					for name in ga {
-						if param.aliases.get(&name).copied() != Some(true) {
-							warn!("bucket {:?}: add global alias {}", bucket.id, name);
-							param.aliases.update_in_place(name, true);
-						}
-					}
-				}
-
-				// fix local aliases
-				{
-					let la = bucket_local.remove(&bucket.id).unwrap_or_default();
-					for (pair, _, active) in param.local_aliases.items().to_vec() {
-						if active && !la.contains(&pair) {
-							warn!("bucket {:?}: remove local alias {:?}", bucket.id, pair);
-							param.local_aliases.update_in_place(pair, false);
-						}
-					}
-					for pair in la {
-						if param.local_aliases.get(&pair).copied() != Some(true) {
-							warn!("bucket {:?}: add local alias {:?}", bucket.id, pair);
-							param.local_aliases.update_in_place(pair, true);
-						}
-					}
-				}
-
-				if bucket2 != bucket {
-					bucket_updates.push(bucket2);
-				}
-			}
-
-			info!("bucket table: {} entries fixed", bucket_updates.len());
-			for b in bucket_updates {
-				debug!("Enqueue update to bucket table: {:?}", b);
-				self.0.bucket_table.queue_insert(tx, &b)?;
-			}
-
-			info!("--- end repair_aliases transaction ----");
-
-			Ok(())
-		})?;
-
-		info!("repair_aliases is done");
-
-		Ok(())
-	}
 }

src/model/s3/lifecycle_worker.rs

@@ -121,13 +121,13 @@ impl Worker for LifecycleWorker {
 				mpu_aborted,
 				..
 			} => {
-				let n_objects = self.garage.object_table.data.store.approximate_len().ok();
+				let n_objects = self.garage.object_table.data.store.len().ok();
 				let progress = match n_objects {
-					Some(total) if total > 0 => format!(
+					None => "...".to_string(),
+					Some(total) => format!(
 						"~{:.2}%",
 						100. * std::cmp::min(*counter, total) as f32 / total as f32
 					),
-					_ => "...".to_string(),
 				};
 				WorkerStatus {
 					progress: Some(progress),

src/net/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "garage_net"
-version = "1.2.0"
+version = "1.1.0"
 authors = ["Alex Auvolat <alex@adnab.me>"]
 edition = "2018"
 license = "AGPL-3.0"

src/rpc/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "garage_rpc"
-version = "1.2.0"
+version = "1.1.0"
 authors = ["Alex Auvolat <alex@adnab.me>"]
 edition = "2018"
 license = "AGPL-3.0"

src/table/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "garage_table"
-version = "1.2.0"
+version = "1.1.0"
 authors = ["Alex Auvolat <alex@adnab.me>"]
 edition = "2018"
 license = "AGPL-3.0"

src/table/data.rs

@@ -367,7 +367,7 @@ impl<F: TableSchema, R: TableReplication> TableData<F, R> {
 		}
 	}
 
-	pub fn gc_todo_approximate_len(&self) -> Result<usize, Error> {
+	pub fn gc_todo_len(&self) -> Result<usize, Error> {
-		Ok(self.gc_todo.approximate_len()?)
+		Ok(self.gc_todo.len()?)
 	}
 }

src/table/gc.rs

@@ -313,7 +313,7 @@ impl<F: TableSchema, R: TableReplication> Worker for GcWorker<F, R> {
 
 	fn status(&self) -> WorkerStatus {
 		WorkerStatus {
-			queue_length: Some(self.gc.data.gc_todo_approximate_len().unwrap_or(0) as u64),
+			queue_length: Some(self.gc.data.gc_todo_len().unwrap_or(0) as u64),
 			..Default::default()
 		}
 	}

src/table/merkle.rs

@@ -287,12 +287,12 @@ impl<F: TableSchema, R: TableReplication> MerkleUpdater<F, R> {
 		MerkleNode::decode_opt(&ent)
 	}
 
-	pub fn merkle_tree_approximate_len(&self) -> Result<usize, Error> {
+	pub fn merkle_tree_len(&self) -> Result<usize, Error> {
-		Ok(self.data.merkle_tree.approximate_len()?)
+		Ok(self.data.merkle_tree.len()?)
 	}
 
-	pub fn todo_approximate_len(&self) -> Result<usize, Error> {
+	pub fn todo_len(&self) -> Result<usize, Error> {
-		Ok(self.data.merkle_todo.approximate_len()?)
+		Ok(self.data.merkle_todo.len()?)
 	}
 }
 
@@ -306,7 +306,7 @@ impl<F: TableSchema, R: TableReplication> Worker for MerkleWorker<F, R> {
 
 	fn status(&self) -> WorkerStatus {
 		WorkerStatus {
-			queue_length: Some(self.0.todo_approximate_len().unwrap_or(0) as u64),
+			queue_length: Some(self.0.todo_len().unwrap_or(0) as u64),
 			..Default::default()
 		}
 	}

src/table/metrics.rs

@@ -34,7 +34,7 @@ impl TableMetrics {
 				.u64_value_observer(
 					"table.size",
 					move |observer| {
-						if let Ok(value) = store.approximate_len() {
+						if let Ok(value) = store.len() {
 							observer.observe(
 								value as u64,
 								&[KeyValue::new("table_name", table_name)],
@@ -48,7 +48,7 @@ impl TableMetrics {
 				.u64_value_observer(
 					"table.merkle_tree_size",
 					move |observer| {
-						if let Ok(value) = merkle_tree.approximate_len() {
+						if let Ok(value) = merkle_tree.len() {
 							observer.observe(
 								value as u64,
 								&[KeyValue::new("table_name", table_name)],
@@ -62,7 +62,7 @@ impl TableMetrics {
 				.u64_value_observer(
 					"table.merkle_updater_todo_queue_length",
 					move |observer| {
-						if let Ok(v) = merkle_todo.approximate_len() {
+						if let Ok(v) = merkle_todo.len() {
 							observer.observe(
 								v as u64,
 								&[KeyValue::new("table_name", table_name)],
@@ -76,7 +76,7 @@ impl TableMetrics {
 				.u64_value_observer(
 					"table.gc_todo_queue_length",
 					move |observer| {
-                        if let Ok(value) = gc_todo.approximate_len() {
+                        if let Ok(value) = gc_todo.len() {
                             observer.observe(
                                 value as u64,
                                 &[KeyValue::new("table_name", table_name)],

src/table/queue.rs

@@ -27,7 +27,7 @@ impl<F: TableSchema, R: TableReplication> Worker for InsertQueueWorker<F, R> {
 
 	fn status(&self) -> WorkerStatus {
 		WorkerStatus {
-			queue_length: Some(self.0.data.insert_queue.approximate_len().unwrap_or(0) as u64),
+			queue_length: Some(self.0.data.insert_queue.len().unwrap_or(0) as u64),
 			..Default::default()
 		}
 	}

src/table/replication/fullcopy.rs

@@ -43,13 +43,10 @@ impl TableReplication for TableFullReplication {
 	}
 	fn write_quorum(&self) -> usize {
 		let nmembers = self.system.cluster_layout().current().all_nodes().len();
-
+		if nmembers < 3 {
-		let max_faults = if nmembers > 1 { 1 } else { 0 };
-
-		if nmembers > max_faults {
-			nmembers - max_faults
-		} else {
 			1
+		} else {
+			nmembers.div_euclid(2) + 1
 		}
 	}
 

src/util/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "garage_util"
-version = "1.2.0"
+version = "1.1.0"
 authors = ["Alex Auvolat <alex@adnab.me>"]
 edition = "2018"
 license = "AGPL-3.0"

src/util/config.rs

@@ -122,10 +122,6 @@ pub struct Config {
 	#[serde(deserialize_with = "deserialize_capacity", default)]
 	pub lmdb_map_size: usize,
 
-	/// Fjall block cache size
-	#[serde(deserialize_with = "deserialize_capacity", default)]
-	pub fjall_block_cache_size: usize,
-
 	// -- APIs
 	/// Configuration for S3 api
 	pub s3_api: S3ApiConfig,
@@ -139,10 +135,6 @@ pub struct Config {
 	/// Configuration for the admin API endpoint
 	#[serde(default = "Default::default")]
 	pub admin: AdminConfig,
-
-	/// Allow punycode in bucket names
-	#[serde(default)]
-	pub allow_punycode: bool,
 }
 
 /// Value for data_dir: either a single directory or a list of dirs with attributes

src/util/crdt/deletable.rs

@@ -9,6 +9,16 @@ pub enum Deletable<T> {
 	Deleted,
 }
 
+impl<T> Deletable<T> {
+	/// Map value, used for migrations
+	pub fn map<U, F: FnOnce(T) -> U>(self, f: F) -> Deletable<U> {
+		match self {
+			Self::Present(x) => Deletable::<U>::Present(f(x)),
+			Self::Deleted => Deletable::<U>::Deleted,
+		}
+	}
+}
+
 impl<T: Crdt> Deletable<T> {
 	/// Create a new deletable object that isn't deleted
 	pub fn present(v: T) -> Self {

src/util/crdt/lww.rs

@@ -43,6 +43,16 @@ pub struct Lww<T> {
 	v: T,
 }
 
+impl<T> Lww<T> {
+	/// Map value, used for migrations
+	pub fn map<U, F: FnOnce(T) -> U>(self, f: F) -> Lww<U> {
+		Lww::<U> {
+			ts: self.ts,
+			v: f(self.v),
+		}
+	}
+}
+
 impl<T> Lww<T>
 where
 	T: Crdt,

src/web/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "garage_web"
-version = "1.2.0"
+version = "1.1.0"
 authors = ["Alex Auvolat <alex@adnab.me>", "Quentin Dufour <quentin@dufour.io>"]
 edition = "2018"
 license = "AGPL-3.0"

src/web/web_server.rs

@@ -25,12 +25,14 @@ use garage_api_common::cors::{
 };
 use garage_api_common::generic_server::{server_loop, UnixListenerOn};
 use garage_api_common::helpers::*;
+use garage_api_s3::api_server::ResBody;
 use garage_api_s3::error::{
 	CommonErrorDerivative, Error as ApiError, OkOrBadRequest, OkOrInternalError,
 };
 use garage_api_s3::get::{handle_get_without_ctx, handle_head_without_ctx};
 use garage_api_s3::website::X_AMZ_WEBSITE_REDIRECT_LOCATION;
 
+use garage_model::bucket_table::{self, RoutingRule};
 use garage_model::garage::Garage;
 
 use garage_table::*;
@@ -260,45 +262,71 @@ impl WebServer {
 		// Get path
 		let path = req.uri().path().to_string();
 		let index = &website_config.index_document;
-		let (key, may_redirect) = path_to_keys(&path, index)?;
+		let routing_result = path_to_keys(&path, index, &website_config.routing_rules)?;
 
 		debug!(
-			"Selected bucket: \"{}\" {:?}, target key: \"{}\", may redirect to: {:?}",
+			"Selected bucket: \"{}\" {:?}, routing to {:?}",
-			bucket_name, bucket_id, key, may_redirect
+			bucket_name, bucket_id, routing_result,
 		);
 
-		let ret_doc = match *req.method() {
+		let ret_doc = match (req.method(), routing_result.main_target()) {
-			Method::OPTIONS => handle_options_for_bucket(req, &bucket_params)
+			(&Method::OPTIONS, _) => handle_options_for_bucket(req, &bucket_params)
 				.map_err(ApiError::from)
 				.map(|res| res.map(|_empty_body: EmptyBody| empty_body())),
-			Method::HEAD => {
+			(_, Err((url, code))) => Ok(Response::builder()
-				handle_head_without_ctx(self.garage.clone(), req, bucket_id, &key, None).await
+				.status(code)
+				.header("Location", url)
+				.body(empty_body())
+				.unwrap()),
+			(_, Ok((key, code))) => {
+				handle_inner(self.garage.clone(), req, bucket_id, key, code).await
 			}
-			Method::GET => {
+		};
-				handle_get_without_ctx(
+
+		// Try handling errors if bucket configuration provided fallbacks
+		let ret_doc_with_redir = match (&ret_doc, &routing_result) {
+			(
+				Err(ApiError::NoSuchKey),
+				RoutingResult::LoadOrRedirect {
+					redirect_if_exists,
+					redirect_url,
+					redirect_code,
+					..
+				},
+			) => {
+				let redirect = if let Some(redirect_key) = redirect_if_exists {
+					self.check_key_exists(bucket_id, redirect_key.as_str())
+						.await?
+				} else {
+					true
+				};
+				if redirect {
+					Ok(Response::builder()
+						.status(redirect_code)
+						.header("Location", redirect_url)
+						.body(empty_body())
+						.unwrap())
+				} else {
+					ret_doc
+				}
+			}
+			(
+				Err(ApiError::NoSuchKey),
+				RoutingResult::LoadOrAlternativeError {
+					redirect_key,
+					redirect_code,
+					..
+				},
+			) => {
+				handle_inner(
 					self.garage.clone(),
 					req,
 					bucket_id,
-					&key,
+					redirect_key,
-					None,
+					*redirect_code,
-					Default::default(),
 				)
 				.await
 			}
-			_ => Err(ApiError::bad_request("HTTP method not supported")),
-		};
-
-		// Try implicit redirect on error
-		let ret_doc_with_redir = match (&ret_doc, may_redirect) {
-			(Err(ApiError::NoSuchKey), ImplicitRedirect::To { key, url })
-				if self.check_key_exists(bucket_id, key.as_str()).await? =>
-			{
-				Ok(Response::builder()
-					.status(StatusCode::FOUND)
-					.header(LOCATION, url)
-					.body(empty_body())
-					.unwrap())
-			}
 			(Ok(ret), _) if ret.headers().contains_key(X_AMZ_WEBSITE_REDIRECT_LOCATION) => {
 				let redirect_location = ret.headers().get(X_AMZ_WEBSITE_REDIRECT_LOCATION).unwrap();
 				Ok(Response::builder()
@@ -332,17 +360,17 @@ impl WebServer {
 				// We want to return the error document
 				// Create a fake HTTP request with path = the error document
 				let req2 = Request::builder()
+					.method("GET")
 					.uri(format!("http://{}/{}", host, &error_document))
 					.body(())
 					.unwrap();
 
-				match handle_get_without_ctx(
+				match handle_inner(
 					self.garage.clone(),
 					&req2,
 					bucket_id,
 					&error_document,
-					None,
+					error.http_status_code(),
-					Default::default(),
 				)
 				.await
 				{
@@ -357,8 +385,6 @@ impl WebServer {
 							error
 						);
 
-						*error_doc.status_mut() = error.http_status_code();
-
 						// Preserve error message in a special header
 						for error_line in error.to_string().split('\n') {
 							if let Ok(v) = HeaderValue::from_bytes(error_line.as_bytes()) {
@@ -389,6 +415,52 @@ impl WebServer {
 	}
 }
 
+async fn handle_inner(
+	garage: Arc<Garage>,
+	req: &Request<()>,
+	bucket_id: Uuid,
+	key: &str,
+	status_code: StatusCode,
+) -> Result<Response<ResBody>, ApiError> {
+	if status_code != StatusCode::OK {
+		// If we are returning an error document, discard all headers from
+		// the original request that would have influenced the result:
+		// - Range header, we don't want to return a subrange of the error document
+		// - Caching directives such as If-None-Match, etc, which are not relevant
+		let cleaned_req = Request::builder().uri(req.uri()).body(()).unwrap();
+
+		let mut ret = match req.method() {
+			&Method::HEAD => {
+				handle_head_without_ctx(garage, &cleaned_req, bucket_id, key, None).await?
+			}
+			&Method::GET => {
+				handle_get_without_ctx(
+					garage,
+					&cleaned_req,
+					bucket_id,
+					key,
+					None,
+					Default::default(),
+				)
+				.await?
+			}
+			_ => return Err(ApiError::bad_request("HTTP method not supported")),
+		};
+
+		*ret.status_mut() = status_code;
+
+		Ok(ret)
+	} else {
+		match req.method() {
+			&Method::HEAD => handle_head_without_ctx(garage, req, bucket_id, key, None).await,
+			&Method::GET => {
+				handle_get_without_ctx(garage, req, bucket_id, key, None, Default::default()).await
+			}
+			_ => Err(ApiError::bad_request("HTTP method not supported")),
+		}
+	}
+}
+
 fn error_to_res(e: Error) -> Response<BoxBody<Error>> {
 	// If we are here, it is either that:
 	// - there was an error before trying to get the requested URL
@@ -397,37 +469,52 @@ fn error_to_res(e: Error) -> Response<BoxBody<Error>> {
 	//   was a HEAD request or we couldn't get the error document)
 	// We do NOT enter this code path when returning the bucket's
 	// error document (this is handled in serve_file)
-	let mut body_str = format!(
+	let body = string_body(format!("{}\n", e));
-		r"<title>{http_code} {code_text}</title>
+	let mut http_error = Response::new(body);
-<h1>{http_code} {code_text}</h1>",
-		http_code = e.http_status_code().as_u16(),
-		code_text = e.http_status_code().canonical_reason().unwrap_or("Unknown"),
-	);
-	if let Error::ApiError(ref err) = e {
-		body_str.push_str(&format!(
-			r"
-<ul>
-<li>Code: {s3_code}</li>
-<li>Message: {s3_message}.</li>
-</ul>",
-			s3_code = err.aws_code(),
-			s3_message = err,
-		));
-	}
-	let mut http_error = Response::new(string_body(body_str));
 	*http_error.status_mut() = e.http_status_code();
 	e.add_headers(http_error.headers_mut());
-	http_error.headers_mut().insert(
-		http::header::CONTENT_TYPE,
-		"text/html; charset=utf-8".parse().unwrap(),
-	);
 	http_error
 }
 
 #[derive(Debug, PartialEq)]
-enum ImplicitRedirect {
+enum RoutingResult {
-	No,
+	// Load a key and use `code` as status, or fallback to normal 404 handler if not found
-	To { key: String, url: String },
+	LoadKey {
+		key: String,
+		code: StatusCode,
+	},
+	// Load a key and use `200` as status, or fallback with a redirection using `redirect_code`
+	// as status
+	LoadOrRedirect {
+		key: String,
+		redirect_if_exists: Option<String>,
+		redirect_url: String,
+		redirect_code: StatusCode,
+	},
+	// Load a key and use `200` as status, or fallback by loading a different key and use
+	// `redirect_code` as status
+	LoadOrAlternativeError {
+		key: String,
+		redirect_key: String,
+		redirect_code: StatusCode,
+	},
+	// Send an http redirect with `code` as status
+	Redirect {
+		url: String,
+		code: StatusCode,
+	},
+}
+
+impl RoutingResult {
+	// return Ok((key_to_deref, status_code)) or Err((redirect_target, status_code))
+	fn main_target(&self) -> Result<(&str, StatusCode), (&str, StatusCode)> {
+		match self {
+			RoutingResult::LoadKey { key, code } => Ok((key, *code)),
+			RoutingResult::LoadOrRedirect { key, .. } => Ok((key, StatusCode::OK)),
+			RoutingResult::LoadOrAlternativeError { key, .. } => Ok((key, StatusCode::OK)),
+			RoutingResult::Redirect { url, code } => Err((url, *code)),
+		}
+	}
 }
 
 /// Path to key
@@ -437,35 +524,154 @@ enum ImplicitRedirect {
 /// which is also AWS S3 behavior.
 ///
 /// Check: https://docs.aws.amazon.com/AmazonS3/latest/userguide/IndexDocumentSupport.html
-fn path_to_keys<'a>(path: &'a str, index: &str) -> Result<(String, ImplicitRedirect), Error> {
+fn path_to_keys(
+	path: &str,
+	index: &str,
+	routing_rules: &[RoutingRule],
+) -> Result<RoutingResult, Error> {
 	let path_utf8 = percent_encoding::percent_decode_str(path).decode_utf8()?;
 
 	let base_key = match path_utf8.strip_prefix("/") {
 		Some(bk) => bk,
 		None => return Err(Error::BadRequest("Path must start with a / (slash)".into())),
 	};
-	let is_bucket_root = base_key.len() == 0;
+
+	let is_bucket_root = base_key.is_empty();
 	let is_trailing_slash = path_utf8.ends_with("/");
 
-	match (is_bucket_root, is_trailing_slash) {
+	let key = if is_bucket_root || is_trailing_slash {
-		// It is not possible to store something at the root of the bucket (ie. empty key),
+		// we can't store anything at the root, so we need to query the index
-		// the only option is to fetch the index
+		// if the key end with a slash, we always query the index
-		(true, _) => Ok((index.to_string(), ImplicitRedirect::No)),
+		format!("{base_key}{index}")
+	} else {
+		// if the key doesn't end with `/`, leave it unmodified
+		base_key.to_string()
+	};
 
-		// "If you create a folder structure in your bucket, you must have an index document at each level. In each folder, the index document must have the same name, for example, index.html. When a user specifies a URL that resembles a folder lookup, the presence or absence of a trailing slash determines the behavior of the website. For example, the following URL, with a trailing slash, returns the photos/index.html index document."
+	let mut routing_rules_iter = routing_rules.iter();
-		(false, true) => Ok((format!("{base_key}{index}"), ImplicitRedirect::No)),
+	let key = loop {
+		let Some(routing_rule) = routing_rules_iter.next() else {
+			break key;
+		};
 
-		// "However, if you exclude the trailing slash from the preceding URL, Amazon S3 first looks for an object photos in the bucket. If the photos object is not found, it searches for an index document, photos/index.html. If that document is found, Amazon S3 returns a 302 Found message and points to the photos/ key. For subsequent requests to photos/, Amazon S3 returns photos/index.html. If the index document is not found, Amazon S3 returns an error."
+		let Ok(status_code) = StatusCode::from_u16(routing_rule.redirect.http_redirect_code) else {
-		(false, false) => Ok((
+			continue;
-			base_key.to_string(),
+		};
-			ImplicitRedirect::To {
+		if let Some(condition) = &routing_rule.condition {
-				key: format!("{base_key}/{index}"),
+			let suffix = if let Some(prefix) = &condition.prefix {
-				url: format!("{path}/"),
+				let Some(suffix) = key.strip_prefix(prefix) else {
-			},
+					continue;
-		)),
+				};
+				Some(suffix)
+			} else {
+				None
+			};
+			let mut target = compute_redirect_target(&routing_rule.redirect, suffix);
+			let query_alternative_key =
+				status_code == StatusCode::OK || status_code == StatusCode::NOT_FOUND;
+			let redirect_on_error =
+				condition.http_error_code == Some(StatusCode::NOT_FOUND.as_u16());
+			match (query_alternative_key, redirect_on_error) {
+				(false, false) => {
+					return Ok(RoutingResult::Redirect {
+						url: target,
+						code: status_code,
+					})
+				}
+				(true, false) => {
+					// we need to remove the leading /
+					target.remove(0);
+					if status_code == StatusCode::OK {
+						break target;
+					} else {
+						return Ok(RoutingResult::LoadKey {
+							key: target,
+							code: status_code,
+						});
+					}
+				}
+				(false, true) => {
+					return Ok(RoutingResult::LoadOrRedirect {
+						key,
+						redirect_if_exists: None,
+						redirect_url: target,
+						redirect_code: status_code,
+					});
+				}
+				(true, true) => {
+					target.remove(0);
+					return Ok(RoutingResult::LoadOrAlternativeError {
+						key,
+						redirect_key: target,
+						redirect_code: status_code,
+					});
+				}
+			}
+		} else {
+			let target = compute_redirect_target(&routing_rule.redirect, None);
+			return Ok(RoutingResult::Redirect {
+				url: target,
+				code: status_code,
+			});
+		}
+	};
+
+	if is_bucket_root || is_trailing_slash {
+		Ok(RoutingResult::LoadKey {
+			key,
+			code: StatusCode::OK,
+		})
+	} else {
+		Ok(RoutingResult::LoadOrRedirect {
+			redirect_if_exists: Some(format!("{key}/{index}")),
+			// we can't use `path` because key might have changed substentially in case of
+			// routing rules
+			redirect_url: percent_encoding::percent_encode(
+				format!("/{key}/").as_bytes(),
+				PATH_ENCODING_SET,
+			)
+			.to_string(),
+			key,
+			redirect_code: StatusCode::FOUND,
+		})
 	}
 }
 
+// per https://url.spec.whatwg.org/#path-percent-encode-set
+const PATH_ENCODING_SET: &percent_encoding::AsciiSet = &percent_encoding::CONTROLS
+	.add(b' ')
+	.add(b'"')
+	.add(b'#')
+	.add(b'<')
+	.add(b'>')
+	.add(b'?')
+	.add(b'`')
+	.add(b'{')
+	.add(b'}');
+
+fn compute_redirect_target(redirect: &bucket_table::Redirect, suffix: Option<&str>) -> String {
+	let mut res = String::new();
+	if let Some(hostname) = &redirect.hostname {
+		if let Some(protocol) = &redirect.protocol {
+			res.push_str(protocol);
+			res.push_str("://");
+		} else {
+			res.push_str("//");
+		}
+		res.push_str(hostname);
+	}
+	res.push('/');
+	if let Some(replace_key_prefix) = &redirect.replace_key_prefix {
+		res.push_str(replace_key_prefix);
+		if let Some(suffix) = suffix {
+			res.push_str(suffix)
+		}
+	} else if let Some(replace_key) = &redirect.replace_key {
+		res.push_str(replace_key)
+	}
+	res
+}
+
 #[cfg(test)]
 mod tests {
 	use super::*;
@@ -473,35 +679,39 @@ mod tests {
 	#[test]
 	fn path_to_keys_test() -> Result<(), Error> {
 		assert_eq!(
-			path_to_keys("/file%20.jpg", "index.html")?,
+			path_to_keys("/file%20.jpg", "index.html", &[])?,
-			(
+			RoutingResult::LoadOrRedirect {
-				"file .jpg".to_string(),
+				key: "file .jpg".to_string(),
-				ImplicitRedirect::To {
+				redirect_url: "/file%20.jpg/".to_string(),
-					key: "file .jpg/index.html".to_string(),
+				redirect_if_exists: Some("file .jpg/index.html".to_string()),
-					url: "/file%20.jpg/".to_string()
+				redirect_code: StatusCode::FOUND,
-				}
+			}
-			)
 		);
 		assert_eq!(
-			path_to_keys("/%20t/", "index.html")?,
+			path_to_keys("/%20t/", "index.html", &[])?,
-			(" t/index.html".to_string(), ImplicitRedirect::No)
+			RoutingResult::LoadKey {
+				key: " t/index.html".to_string(),
+				code: StatusCode::OK
+			}
 		);
 		assert_eq!(
-			path_to_keys("/", "index.html")?,
+			path_to_keys("/", "index.html", &[])?,
-			("index.html".to_string(), ImplicitRedirect::No)
+			RoutingResult::LoadKey {
+				key: "index.html".to_string(),
+				code: StatusCode::OK
+			}
 		);
 		assert_eq!(
-			path_to_keys("/hello", "index.html")?,
+			path_to_keys("/hello", "index.html", &[])?,
-			(
+			RoutingResult::LoadOrRedirect {
-				"hello".to_string(),
+				key: "hello".to_string(),
-				ImplicitRedirect::To {
+				redirect_url: "/hello/".to_string(),
-					key: "hello/index.html".to_string(),
+				redirect_if_exists: Some("hello/index.html".to_string()),
-					url: "/hello/".to_string()
+				redirect_code: StatusCode::FOUND,
-				}
+			}
-			)
 		);
-		assert!(path_to_keys("", "index.html").is_err());
+		assert!(path_to_keys("", "index.html", &[]).is_err());
-		assert!(path_to_keys("i/am/relative", "index.html").is_err());
+		assert!(path_to_keys("i/am/relative", "index.html", &[]).is_err());
 		Ok(())
 	}
 }