From d2f033641ed072d261dfb316567b020b79373413 Mon Sep 17 00:00:00 2001 From: Ira Iva Date: Tue, 3 Mar 2026 15:52:53 +0000 Subject: [PATCH] Suppress log noise from /metrics and /health endpoints [#1292]. Change log level for 'netapp: incomming connection ...' message [#1310] (#1361) Reviewed-on: https://git.deuxfleurs.fr/Deuxfleurs/garage/pulls/1361 Co-authored-by: Ira Iva Co-committed-by: Ira Iva --- src/api/common/generic_server.rs | 8 +++++++- src/net/netapp.rs | 2 +- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/src/api/common/generic_server.rs b/src/api/common/generic_server.rs index 0e97334a..20903938 100644 --- a/src/api/common/generic_server.rs +++ b/src/api/common/generic_server.rs @@ -162,7 +162,13 @@ impl ApiServer { .key_id_from_request(&req) .map(|k| format!("(key {k}) ")) .unwrap_or_default(); - info!("{source} {key}{} {uri}", req.method()); + + if A::API_NAME == "admin" && (uri.path() == "/health" || uri.path() == "/metrics") { + debug!("{source} {key}{} {uri}", req.method()); + } else { + info!("{source} {key}{} {uri}", req.method()); + } + debug!("{:?}", req); let tracer = opentelemetry::global::tracer("garage"); diff --git a/src/net/netapp.rs b/src/net/netapp.rs index f712a30c..da6eb057 100644 --- a/src/net/netapp.rs +++ b/src/net/netapp.rs @@ -273,7 +273,7 @@ impl NetApp { ); } - info!( + debug!( "Incoming connection from {}, negotiating handshake...", peer_addr );