From b7a853b01f9dd60f0636872ca30c265af1b31dde Mon Sep 17 00:00:00 2001
From: Charles Hall <charles@computer.surgery>
Date: Wed, 30 Jul 2025 18:27:22 -0700
Subject: [PATCH] ignore checksums with empty/whitespace-only bodies

aws-sdk-cpp was observed to send request bodies like this via Lix:

```xml
<?xml version="1.0"?>
<CompleteMultipartUpload xmlns="http://s3.amazonaws.com/doc/2006-03-01/">
    <Part>
        <ETag>"8a5031bda169553d6a232e6c11068774"</ETag>
        <ChecksumCRC32></ChecksumCRC32>
        <PartNumber>1</PartNumber>
    </Part>
    <Part>
        <ETag>"da977cc58b75bd17749c1ff460ba301a"</ETag>
        <ChecksumCRC32></ChecksumCRC32>
        <PartNumber>2</PartNumber>
    </Part>
</CompleteMultipartUpload>
```
---
 src/api/s3/multipart.rs | 18 +++++++++++++++---
 1 file changed, 15 insertions(+), 3 deletions(-)

diff --git a/src/api/s3/multipart.rs b/src/api/s3/multipart.rs
index 4777c95b..57ed22e9 100644
--- a/src/api/s3/multipart.rs
+++ b/src/api/s3/multipart.rs
@@ -611,9 +611,21 @@ macro_rules! extract_checksum_from {
 		if false { None }
 		$(
 			else if let Some(node) = $node.children().find(|e| e.has_tag_name($name)) {
-				Some(ChecksumValue::$variant(
-					BASE64_STANDARD.decode(node.text()?).ok()?[..].try_into().ok()?
-				))
+				match node.last_child().map(|x| x.text()) {
+					// Child is text but empty post-trim, ignore it.
+					Some(Some(text)) if text.trim().is_empty() => None,
+
+					// Child is non-empty text, parse it.
+					Some(Some(text)) => Some(ChecksumValue::$variant(
+						BASE64_STANDARD.decode(text).ok()?[..].try_into().ok()?
+					)),
+
+					// Child is not text, reject it.
+					Some(None) => return None,
+
+					// No child, ignore it.
+					None => None,
+				}
 			}
 		)*
 		else { None }