gsadmin/garage
1
0
Fork 0
mirror of https://github.com/deuxfleurs-org/garage.git synced 2026-08-31 09:18:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

admin api: add fixme comments for cleanup for v3 release

Browse Source
This commit is contained in:
Alex Auvolat
2026-03-06 12:50:11 +01:00
committed by Alex
parent af5f68a34d
commit 8abd0fee86
1 changed files with 8 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/api/admin/api.rs
+8
View File
@@ -284,9 +284,11 @@ pub struct GetClusterStatisticsRequest;
#[derive(Debug, Clone, Serialize, Deserialize, ToSchema)] #[derive(Debug, Clone, Serialize, Deserialize, ToSchema)]
#[serde(rename_all = "camelCase")] #[serde(rename_all = "camelCase")]
pub struct GetClusterStatisticsResponse { pub struct GetClusterStatisticsResponse {
// FIXME for v3: remove freeform field and move display logic to garage crate
/// cluster statistics as a free-form string, kept for compatibility with nodes /// cluster statistics as a free-form string, kept for compatibility with nodes
/// running older v2.x versions of garage /// running older v2.x versions of garage
pub freeform: String, pub freeform: String,
// FIXME for v3: remove serde(default) for all three fields below
/// available storage space for object data in the entire cluster, in bytes /// available storage space for object data in the entire cluster, in bytes
#[serde(default)] #[serde(default)]
pub data_avail: u64, pub data_avail: u64,
@@ -889,6 +891,7 @@ pub struct GetBucketInfoResponse {
pub struct GetBucketInfoWebsiteResponse { pub struct GetBucketInfoWebsiteResponse {
pub index_document: String, pub index_document: String,
pub error_document: Option<String>, pub error_document: Option<String>,
// FIXME for v3: remove serde(default) for field below
#[serde(default)] #[serde(default)]
pub routing_rules: Vec<xml::website::RoutingRule>, pub routing_rules: Vec<xml::website::RoutingRule>,
} }
@@ -949,6 +952,7 @@ pub struct UpdateBucketResponse(pub GetBucketInfoResponse);
pub struct UpdateBucketRequestBody { pub struct UpdateBucketRequestBody {
pub website_access: Option<UpdateBucketWebsiteAccess>, pub website_access: Option<UpdateBucketWebsiteAccess>,
pub quotas: Option<ApiBucketQuotas>, pub quotas: Option<ApiBucketQuotas>,
// FIXME for v3: remove serde(default) for the two fields below
#[serde(default)] #[serde(default)]
pub cors_rules: Option<Vec<xml::cors::CorsRule>>, pub cors_rules: Option<Vec<xml::cors::CorsRule>>,
#[serde(default)] #[serde(default)]
@@ -961,6 +965,7 @@ pub struct UpdateBucketWebsiteAccess {
pub enabled: bool, pub enabled: bool,
pub index_document: Option<String>, pub index_document: Option<String>,
pub error_document: Option<String>, pub error_document: Option<String>,
// FIXME for v3: remove serde(default) for field below
#[serde(default)] #[serde(default)]
pub routing_rules: Option<Vec<xml::website::RoutingRule>>, pub routing_rules: Option<Vec<xml::website::RoutingRule>>,
} }
@@ -1137,6 +1142,7 @@ pub struct LocalGetNodeInfoRequest;
#[serde(rename_all = "camelCase")] #[serde(rename_all = "camelCase")]
pub struct LocalGetNodeInfoResponse { pub struct LocalGetNodeInfoResponse {
pub node_id: String, pub node_id: String,
// FIXME for v3: remove serde(default) for field below
/// hostname of this node /// hostname of this node
#[serde(default)] #[serde(default)]
pub hostname: String, pub hostname: String,
@@ -1158,9 +1164,11 @@ pub struct LocalGetNodeStatisticsRequest;
#[derive(Debug, Clone, Serialize, Deserialize, ToSchema)] #[derive(Debug, Clone, Serialize, Deserialize, ToSchema)]
#[serde(rename_all = "camelCase")] #[serde(rename_all = "camelCase")]
pub struct LocalGetNodeStatisticsResponse { pub struct LocalGetNodeStatisticsResponse {
// FIXME for v3: remove freeform field and move display logic to garage crate
/// node statistics as a free-form string, kept for compatibility with nodes /// node statistics as a free-form string, kept for compatibility with nodes
/// running older v2.x versions of garage /// running older v2.x versions of garage
pub freeform: String, pub freeform: String,
// FIXME for v3: remove serde(default) for fields below
/// metadata table statistics /// metadata table statistics
#[serde(default)] #[serde(default)]
pub table_stats: Vec<NodeTableStats>, pub table_stats: Vec<NodeTableStats>,