gsadmin/garage
1
0
Fork 0
mirror of https://github.com/deuxfleurs-org/garage.git synced 2026-08-12 15:26:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

perf(kv): dont retrieve values for write ops

Browse Source 
see https://git.deuxfleurs.fr/Deuxfleurs/garage/issues/851
This commit is contained in:
marvin-j97
2024-09-04 18:45:17 +02:00
parent 615698df7d
commit 74363c9060
3 changed files with 14 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/db/sqlite_adapter.rs
+6 -10
View File
@@ -169,7 +169,7 @@ impl IDb for SqliteDb {
}
}
fn insert(&self, tree: usize, key: &[u8], value: &[u8]) -> Result<Option<Value>> {
fn insert(&self, tree: usize, key: &[u8], value: &[u8]) -> Result<()> {
let tree = self.get_tree(tree)?;
let db = self.db.get()?;
let lock = self.write_lock.lock();
@@ -184,23 +184,19 @@ impl IDb for SqliteDb {
assert_eq!(n, 1);
drop(lock);
Ok(old_val)
Ok(())
}
fn remove(&self, tree: usize, key: &[u8]) -> Result<Option<Value>> {
fn remove(&self, tree: usize, key: &[u8]) -> Result<()> {
let tree = self.get_tree(tree)?;
let db = self.db.get()?;
let lock = self.write_lock.lock();
let old_val = self.internal_get(&db, &tree, key)?;
if old_val.is_some() {
let n = db.execute(&format!("DELETE FROM {} WHERE k = ?1", tree), params![key])?;
assert_eq!(n, 1);
}
let n = db.execute(&format!("DELETE FROM {} WHERE k = ?1", tree), params![key])?;
assert_eq!(n, 1);
drop(lock);
Ok(old_val)
Ok(())
}
fn clear(&self, tree: usize) -> Result<()> {