chore: clean relative to references and borrows

- lint message: the borrowed expression implements the required traits
help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#needless_borrows_for_generic_args
- lint message: this expression creates a reference which is immediately dereferenced by the compiler
help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#needless_borrow
- lint message: you don't need to add `&` to all patterns
help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#match_ref_pat
- remove useless taken reference
lint message: needlessly taken reference of left operand
help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#op_ref
- use &Path instead of &PathBuf as fn parameters
lint message: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do
help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#ptr_arg

src/rpc/consul.rs

@@ -113,7 +113,7 @@ impl ConsulDiscovery {
 					let mut headers = reqwest::header::HeaderMap::new();
 					headers.insert(
 						"x-consul-token",
-						reqwest::header::HeaderValue::from_str(&token)?,
+						reqwest::header::HeaderValue::from_str(token)?,
 					);
 					builder = builder.default_headers(headers);
 				}

src/rpc/layout/test.rs

@@ -35,8 +35,8 @@ fn check_against_naive(cl: &LayoutVersion) -> Result<bool, Error> {
 		zone_token.insert(z.clone(), 0);
 	}
 	for uuid in cl.nongateway_nodes() {
-		let z = cl.expect_get_node_zone(&uuid);
-		let c = cl.expect_get_node_capacity(&uuid);
+		let z = cl.expect_get_node_zone(uuid);
+		let c = cl.expect_get_node_capacity(uuid);
 		zone_token.insert(
 			z.to_string(),
 			zone_token[z] + min(NB_PARTITIONS, (c / over_size) as usize),

src/rpc/rpc_helper.rs

@@ -592,7 +592,7 @@ impl RpcHelper {
 			for i in 0..current_layout.replication_factor {
 				for vn in vernodes.iter() {
 					if let Some(n) = vn.get(i) {
-						if !nodes.contains(&n) {
+						if !nodes.contains(n) {
 							if *n == self.0.our_node_id {
 								// it's always fast (almost free) to ask locally,
 								// so always put that as first choice