From af7af32d4e502c9050d8cd968a411112c3a4b11c Mon Sep 17 00:00:00 2001 From: Noooste <83548733+Noooste@users.noreply.github.com> Date: Sun, 19 Apr 2026 23:20:32 +0200 Subject: [PATCH] feat: add denyBucketKeyFn and enhance allowBucketKeyFn with detailed error logging in buckets_test.go Signed-off-by: Noooste <83548733+Noooste@users.noreply.github.com> --- backend/internal/handlers/buckets_test.go | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/backend/internal/handlers/buckets_test.go b/backend/internal/handlers/buckets_test.go index 7ff3c37..754a3f9 100644 --- a/backend/internal/handlers/buckets_test.go +++ b/backend/internal/handlers/buckets_test.go @@ -294,10 +294,19 @@ func TestGrantBucketPermission_Success(t *testing.T) { } admin.AllowBucketKeyFn = func(_ context.Context, req models.BucketKeyPermRequest) (*models.GarageBucketInfo, error) { if req.BucketID != "id-1" || req.AccessKeyID != "AKIA" { - t.Errorf("req = %+v", req) + t.Errorf("allow req = %+v", req) } if !req.Permissions.Read || !req.Permissions.Write || req.Permissions.Owner { - t.Errorf("perms = %+v", req.Permissions) + t.Errorf("allow perms = %+v", req.Permissions) + } + return &models.GarageBucketInfo{ID: "id-1"}, nil + } + admin.DenyBucketKeyFn = func(_ context.Context, req models.BucketKeyPermRequest) (*models.GarageBucketInfo, error) { + if req.BucketID != "id-1" || req.AccessKeyID != "AKIA" { + t.Errorf("deny req = %+v", req) + } + if req.Permissions.Read || req.Permissions.Write || !req.Permissions.Owner { + t.Errorf("deny perms = %+v", req.Permissions) } return &models.GarageBucketInfo{ID: "id-1"}, nil }