From 709b9f2ad33fb3852bc23be1d647bb1d9388169b Mon Sep 17 00:00:00 2001 From: Noste <83548733+Noooste@users.noreply.github.com> Date: Fri, 15 May 2026 23:11:51 +0200 Subject: [PATCH] fix(helm): update appVersion format and improve image tag handling Signed-off-by: Noste <83548733+Noooste@users.noreply.github.com> --- .github/workflows/release-please.yml | 8 +++++++- helm/garage-ui/Chart.yaml | 2 +- helm/garage-ui/templates/deployment.yaml | 2 +- release-please-config.json | 7 +------ 4 files changed, 10 insertions(+), 9 deletions(-) diff --git a/.github/workflows/release-please.yml b/.github/workflows/release-please.yml index 4dedb8f..e1cd86c 100644 --- a/.github/workflows/release-please.yml +++ b/.github/workflows/release-please.yml @@ -13,8 +13,14 @@ jobs: release-please: runs-on: ubuntu-latest steps: + - uses: actions/create-github-app-token@v2 + id: app-token + with: + app-id: ${{ secrets.RELEASE_PLEASE_APP_ID }} + private-key: ${{ secrets.RELEASE_PLEASE_APP_KEY }} + - uses: googleapis/release-please-action@v4 with: config-file: release-please-config.json manifest-file: .release-please-manifest.json - token: ${{ secrets.GITHUB_TOKEN }} + token: ${{ steps.app-token.outputs.token }} diff --git a/helm/garage-ui/Chart.yaml b/helm/garage-ui/Chart.yaml index 4cd6805..b5f3318 100644 --- a/helm/garage-ui/Chart.yaml +++ b/helm/garage-ui/Chart.yaml @@ -4,7 +4,7 @@ description: A Helm chart for Garage UI - Web interface for Garage S3 object sto icon: https://helm.noste.dev/garage.png type: application version: 0.4.1 -appVersion: 0.6.1 +appVersion: v0.6.1 # x-release-please-version keywords: - garage - s3 diff --git a/helm/garage-ui/templates/deployment.yaml b/helm/garage-ui/templates/deployment.yaml index 68929d8..47c24a5 100644 --- a/helm/garage-ui/templates/deployment.yaml +++ b/helm/garage-ui/templates/deployment.yaml @@ -30,7 +30,7 @@ spec: - name: {{ .Chart.Name }} securityContext: {{- toYaml .Values.securityContext | nindent 12 }} - image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default (ternary .Chart.AppVersion (printf "v%s" .Chart.AppVersion) (hasPrefix "v" .Chart.AppVersion)) }}" + image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}" imagePullPolicy: {{ .Values.image.pullPolicy }} ports: - name: http diff --git a/release-please-config.json b/release-please-config.json index f461283..a7d5ff5 100644 --- a/release-please-config.json +++ b/release-please-config.json @@ -11,12 +11,7 @@ "changelog-path": "CHANGELOG.md", "exclude-paths": ["helm/garage-ui"], "extra-files": [ - { - "type": "yaml", - "path": "helm/garage-ui/Chart.yaml", - "jsonpath": "$.appVersion", - "glob": false - } + "helm/garage-ui/Chart.yaml" ] }, "helm/garage-ui": {