From 8cac2d849dcc0aed4a0327de6f934b4ed755cc6e Mon Sep 17 00:00:00 2001 From: Yash Kumar Date: Thu, 22 Oct 2026 21:27:11 +0530 Subject: [PATCH] chore(monitoring): address review comments --- apps/dokploy/components/layouts/side.tsx | 2 +- apps/dokploy/pages/dashboard/monitoring.tsx | 3 --- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/apps/dokploy/components/layouts/side.tsx b/apps/dokploy/components/layouts/side.tsx index c1037d6db..430349867 100644 --- a/apps/dokploy/components/layouts/side.tsx +++ b/apps/dokploy/components/layouts/side.tsx @@ -192,7 +192,7 @@ const MENU: Menu = { title: "Monitoring", url: "/dashboard/monitoring", icon: BarChartHorizontalBigIcon, - // Host stats also need docker.read, which the stats socket requires + // Only enabled in non-cloud environments (product decision) and if user has monitoring.read and docker.read isEnabled: ({ isCloud, permissions }) => !isCloud && !!permissions?.monitoring.read && diff --git a/apps/dokploy/pages/dashboard/monitoring.tsx b/apps/dokploy/pages/dashboard/monitoring.tsx index ba0bf1956..17d55b080 100644 --- a/apps/dokploy/pages/dashboard/monitoring.tsx +++ b/apps/dokploy/pages/dashboard/monitoring.tsx @@ -113,9 +113,6 @@ export async function getServerSideProps( user: { id: user.id }, session: { activeOrganizationId: session?.activeOrganizationId || "" }, }; - // Host stats come from the docker stats socket, which requires docker.read. - // Checked separately because a member's "Access to Docker" is a legacy - // override that only applies when every requested resource has one. const canView = (await hasPermission(permissionCtx, { monitoring: ["read"] })) && (await hasPermission(permissionCtx, { docker: ["read"] }));