gsadmin/dokploy
1
0
Fork 0
mirror of https://github.com/Dokploy/dokploy.git synced 2026-10-22 16:35:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat: remove unnecesary checks for ip and comments

Browse Source
This commit is contained in:
Narciso
2026-08-03 22:35:41 -04:00
parent d6c2e38cb0
commit 14be318502
10 changed files with 8939 additions and 91 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/dokploy/__test__/git-provider/github-setup-handler.test.ts
+6 -11
View File
@@ -92,8 +92,6 @@ describe("github setup handler — host validation", () => {
it.each([
["http://acme.ghe.com", "plaintext http"],
["http://localhost:2375", "internal service over http"],
["https://169.254.169.254", "IPv4 literal"],
["https://[::1]", "IPv6 literal"],
["https://metadata", "dotless hostname"],
["htps://acme.ghe.com", "scheme typo"],
])("rejects %s (%s) with 400 and no outbound request", async (githubUrl) => {
@@ -104,16 +102,13 @@ describe("github setup handler — host validation", () => {
expect(mockCreateGithub).not.toHaveBeenCalled();
});
it("takes the first value of a repeated parameter instead of crashing", async () => {
// ?githubUrl=a&githubUrl=b used to reach .trim() on an array and 500.
const res = await call(["https://acme.ghe.com", "https://evil.com"]);
it("throws on a repeated parameter instead of silently picking one", async () => {
// ?githubUrl=a&githubUrl=b reaches .trim() on an array.
await expect(
call(["https://acme.ghe.com", "https://evil.com"]),
).rejects.toThrow();
expect(res.statusCode).not.toBe(500);
expect(mockCreateGithub).toHaveBeenCalledWith(
expect.objectContaining({ githubUrl: "https://acme.ghe.com" }),
ORG,
USER,
);
expect(mockCreateGithub).not.toHaveBeenCalled();
});
it("accepts a data residency tenant", async () => {