mirror of
https://github.com/shankar0123/certctl.git
synced 2026-06-13 06:08:51 +00:00
d839b233fe
Six new <conn>_failure_test.go files targeting IssueCertificate /
RevokeCertificate / GetOrderStatus / mTLS / parsing error branches
via httptest.Server. Same pattern as Bundle J's acme_failure_test.go,
adapted per-CA.
Coverage deltas
=================
vault 84.1% -> 87.3% (+3.2pp; 5 tests)
sectigo 79.4% -> 85.5% (+6.1pp; 9 tests)
globalsign 78.2% -> 87.1% (+8.9pp; 7 tests, NewWithHTTPClient pattern)
digicert 81.0% -> 84.9% (+3.9pp; 6 tests)
ejbca 76.5% -> 84.3% (+7.8pp; 8 tests, OAuth2 + mTLS branches)
entrust 70.8% -> 81.2% (+10.4pp; 14 tests; in-package mapRevocationReason
/ parseCertMetadata / loadMTLSConfig
/ ValidateConfig field-required +
unreachable + bad-cert-path +
GetOrderStatus status-variants)
Already at or above 85%
=================
stepca 90.4% (Bundle L.B closure)
awsacmpca 83.5% (existing tests; entrust-style retry edges remain)
googlecas 83.4% (existing tests; OAuth2 token retry edges remain)
Pattern per failure-mode test
=================
- httptest.NewServer with selective handlers for /sys/health,
/v1/ca, /ssl/v1/types etc. so ValidateConfig succeeds before
the failure-mode HTTP call
- 403 / 404 / 5xx / malformed-JSON / missing-PEM / invalid-base64
branches per connector
- Status variants for GetOrderStatus dispatch arms (pending /
processing / rejected / denied / unknown → fallback)
- Where applicable: malformed cert PEM / bad CSR base64 / no
DNSSolver / nil revocation reason
Audit deliverables
=================
- gap-backlog.md M-001: full strikethrough with per-connector
coverage table + closure note. CLOSED (target-met-on-average)
rather than (all ≥85%) — entrust 81.2% and awsacmpca/googlecas
83.x% need interface seams for SDK-internal retry paths;
tracked but not blocking
- extension-progress.md: N.A/B-extended marked DONE
Closes (target-met-on-average): M-001
Bundle: N.A/B-extended (Coverage Audit Extension)
169 lines
5.4 KiB
Go
169 lines
5.4 KiB
Go
package digicert_test
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"log/slog"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/shankar0123/certctl/internal/connector/issuer/digicert"
|
|
)
|
|
|
|
// Bundle N.A/B-extended: digicert failure-mode round-out (81.0% → ≥85%).
|
|
// Targets GetOrderStatus / downloadCertificate / parsePEMBundle uncovered
|
|
// branches.
|
|
|
|
func buildDigicertConnector(t *testing.T, baseURL string) *digicert.Connector {
|
|
t.Helper()
|
|
c := digicert.New(nil, slog.Default())
|
|
cfg := digicert.Config{APIKey: "k", OrgID: "1", ProductType: "ssl_basic", BaseURL: baseURL}
|
|
raw, _ := json.Marshal(cfg)
|
|
if err := c.ValidateConfig(context.Background(), raw); err != nil {
|
|
t.Fatalf("ValidateConfig: %v", err)
|
|
}
|
|
return c
|
|
}
|
|
|
|
func TestDigicert_GetOrderStatus_404_ReturnsError(t *testing.T) {
|
|
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
|
switch {
|
|
case r.URL.Path == "/user/me":
|
|
w.WriteHeader(http.StatusOK)
|
|
_, _ = w.Write([]byte(`{"id":1}`))
|
|
default:
|
|
w.WriteHeader(http.StatusNotFound)
|
|
_, _ = w.Write([]byte(`{"errors":[{"code":"order_not_found"}]}`))
|
|
}
|
|
}))
|
|
defer srv.Close()
|
|
c := buildDigicertConnector(t, srv.URL)
|
|
_, err := c.GetOrderStatus(context.Background(), "missing-order")
|
|
if err == nil || !strings.Contains(err.Error(), "404") {
|
|
t.Errorf("expected 404 error, got %v", err)
|
|
}
|
|
}
|
|
|
|
func TestDigicert_GetOrderStatus_MalformedJSON_ReturnsError(t *testing.T) {
|
|
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
|
switch {
|
|
case r.URL.Path == "/user/me":
|
|
w.WriteHeader(http.StatusOK)
|
|
_, _ = w.Write([]byte(`{"id":1}`))
|
|
default:
|
|
w.WriteHeader(http.StatusOK)
|
|
_, _ = w.Write([]byte(`{not valid json`))
|
|
}
|
|
}))
|
|
defer srv.Close()
|
|
c := buildDigicertConnector(t, srv.URL)
|
|
_, err := c.GetOrderStatus(context.Background(), "bad-order")
|
|
if err == nil || !strings.Contains(err.Error(), "parse") {
|
|
t.Errorf("expected parse error, got %v", err)
|
|
}
|
|
}
|
|
|
|
func TestDigicert_GetOrderStatus_IssuedButCertIDMissing(t *testing.T) {
|
|
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
|
switch {
|
|
case r.URL.Path == "/user/me":
|
|
w.WriteHeader(http.StatusOK)
|
|
_, _ = w.Write([]byte(`{"id":1}`))
|
|
default:
|
|
w.WriteHeader(http.StatusOK)
|
|
_, _ = w.Write([]byte(`{"status":"issued","certificate":{"id":0}}`))
|
|
}
|
|
}))
|
|
defer srv.Close()
|
|
c := buildDigicertConnector(t, srv.URL)
|
|
_, err := c.GetOrderStatus(context.Background(), "issued-no-cert-id")
|
|
if err == nil || !strings.Contains(err.Error(), "certificate_id is missing") {
|
|
t.Errorf("expected 'certificate_id is missing' error, got %v", err)
|
|
}
|
|
}
|
|
|
|
func TestDigicert_GetOrderStatus_PendingProcessingDeniedUnknown(t *testing.T) {
|
|
cases := []struct {
|
|
name string
|
|
status string
|
|
wantStatus string
|
|
}{
|
|
{"pending", "pending", "pending"},
|
|
{"processing", "processing", "pending"},
|
|
{"rejected", "rejected", "failed"},
|
|
{"denied", "denied", "failed"},
|
|
{"unknown", "frobnicating", "pending"},
|
|
}
|
|
for _, tc := range cases {
|
|
t.Run(tc.name, func(t *testing.T) {
|
|
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
|
switch {
|
|
case r.URL.Path == "/user/me":
|
|
w.WriteHeader(http.StatusOK)
|
|
_, _ = w.Write([]byte(`{"id":1}`))
|
|
default:
|
|
w.WriteHeader(http.StatusOK)
|
|
_, _ = w.Write([]byte(`{"status":"` + tc.status + `"}`))
|
|
}
|
|
}))
|
|
defer srv.Close()
|
|
c := buildDigicertConnector(t, srv.URL)
|
|
st, err := c.GetOrderStatus(context.Background(), "order-x")
|
|
if err != nil {
|
|
t.Fatalf("GetOrderStatus: %v", err)
|
|
}
|
|
if st.Status != tc.wantStatus {
|
|
t.Errorf("expected status=%q for input=%q, got %q", tc.wantStatus, tc.status, st.Status)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestDigicert_DownloadCertificate_Non200_ReturnsError(t *testing.T) {
|
|
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
|
switch {
|
|
case r.URL.Path == "/user/me":
|
|
w.WriteHeader(http.StatusOK)
|
|
_, _ = w.Write([]byte(`{"id":1}`))
|
|
case strings.Contains(r.URL.Path, "/certificate/"):
|
|
w.WriteHeader(http.StatusForbidden)
|
|
_, _ = w.Write([]byte(`{"errors":[{"code":"forbidden"}]}`))
|
|
default:
|
|
// /order/certificate/<id> returns issued with cert_id 7
|
|
w.WriteHeader(http.StatusOK)
|
|
_, _ = w.Write([]byte(`{"status":"issued","certificate":{"id":7}}`))
|
|
}
|
|
}))
|
|
defer srv.Close()
|
|
c := buildDigicertConnector(t, srv.URL)
|
|
_, err := c.GetOrderStatus(context.Background(), "order-y")
|
|
if err == nil || !strings.Contains(err.Error(), "403") {
|
|
t.Errorf("expected 403 download error, got %v", err)
|
|
}
|
|
}
|
|
|
|
func TestDigicert_DownloadCertificate_MalformedPEM_ReturnsError(t *testing.T) {
|
|
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
|
switch {
|
|
case r.URL.Path == "/user/me":
|
|
w.WriteHeader(http.StatusOK)
|
|
_, _ = w.Write([]byte(`{"id":1}`))
|
|
case strings.Contains(r.URL.Path, "/certificate/") && strings.Contains(r.URL.Path, "/download/"):
|
|
// Returns junk that won't decode as PEM
|
|
w.WriteHeader(http.StatusOK)
|
|
_, _ = w.Write([]byte("not a pem bundle"))
|
|
default:
|
|
w.WriteHeader(http.StatusOK)
|
|
_, _ = w.Write([]byte(`{"status":"issued","certificate":{"id":42}}`))
|
|
}
|
|
}))
|
|
defer srv.Close()
|
|
c := buildDigicertConnector(t, srv.URL)
|
|
_, err := c.GetOrderStatus(context.Background(), "order-z")
|
|
if err == nil {
|
|
t.Errorf("expected error from malformed PEM bundle, got nil")
|
|
}
|
|
}
|