mirror of
https://github.com/shankar0123/certctl.git
synced 2026-06-07 22:51:30 +00:00
shankar0123
5b7a022767
Bundle: ci-pipeline-cleanup, Phase 1. Pure relocation — no behavior change. Each guard's bash logic is byte-identical to the prior inline version; the only changes are: (a) the guard becomes a sibling script under scripts/ci-guards/<id>.sh, (b) ci.yml's per-guard step is replaced by a single loop step that iterates all scripts. 20 scripts extracted (alphabetized): B-1-orphan-crud.sh, D-1-D-2-statusbadge-phantom.sh, G-1-jwt-auth-literal.sh, G-2-api-key-hash-json.sh, G-3-env-docs-drift.sh, H-001-bare-from.sh, H-009-readme-jwt.sh, L-001-insecure-skip-verify.sh, L-1-bulk-action-loop.sh, M-012-no-root-user.sh, P-1-documented-orphan-fns.sh, S-1-hardcoded-source-counts.sh, S-2-strings-contains-err.sh, T-1-frontend-page-coverage.sh, U-2-plaintext-healthcheck.sh, U-3-migration-mount.sh, bundle-8-L-015-target-blank-rel-noopener.sh, bundle-8-L-019-dangerously-set-inner-html.sh, bundle-8-M-009-bare-usemutation.sh, test-naming-convention.sh Plus scripts/ci-guards/README.md documenting the contract: - Each script must exit 0 on clean repo, non-zero with ::error:: prefix on regression - Runnable from repo root via 'bash scripts/ci-guards/<id>.sh' - Adding a new guard: drop a new <id>.sh; CI auto-picks it up ci.yml dropped 1488 → 557 lines (-931, -63%). Single CI loop step now collects ALL guard failures before failing the build instead of fail-fast — UX win for regressions that hit two guards at once. Two guards (QA-doc Part-count + seed-count, ci.yml lines 868-917) deliberately NOT extracted — they move to 'make verify-docs' in Phase 11 because they protect docs-the-operator-reads, not the product itself. Verification (sandbox): - All 20 scripts pass against HEAD (chmod +x; for g in scripts/ci-guards/*.sh; do bash $g; done) - New ci.yml YAML-parses cleanly - Job boundaries preserved: go-build-and-test, frontend-build, helm-lint, deploy-vendor-e2e, deploy-vendor-e2e-windows - Loop step appears twice (once at end of go-build-and-test, once at end of frontend-build) so both jobs continue running their set of guards
47 lines
2.1 KiB
Bash
Executable File
47 lines
2.1 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
# scripts/ci-guards/S-1-hardcoded-source-counts.sh
|
|
#
|
|
# S-1 master closed cat-s1-9ce1cbe26876 (README + features.md
|
|
# stale numeric counts; explicit CLAUDE.md violation per
|
|
# "version-stamped numbers rot") and
|
|
# cat-s1-features_md_issuer_count_contradiction (features.md
|
|
# self-disagreed on issuer count: 9 vs 12 in the same doc).
|
|
# The fix replaced source-derived numbers in prose with
|
|
# "rebuild via <command>" patterns documented in CLAUDE.md::
|
|
# "Current-state commands". This script grep-fails the build if
|
|
# any of the previously-stale sites reintroduces a hardcoded
|
|
# count.
|
|
#
|
|
# Allowed surfaces: demo-fixture prose in README ("32
|
|
# certificates" — those are seed_demo.sql facts, not live
|
|
# source counts), historical-milestone counts in
|
|
# WORKSPACE-CHANGELOG.md, the testing-guide example phrasing
|
|
# ("README claims 8 issuer connectors but only 6 exist"),
|
|
# and any number that quotes the source command immediately
|
|
# adjacent.
|
|
#
|
|
# See coverage-gap-audit-2026-04-24-v5/unified-audit.md
|
|
# cat-s1-9ce1cbe26876 + cat-s1-features_md_issuer_count_contradiction
|
|
# for closure rationale.
|
|
|
|
set -e
|
|
BAD=$(grep -rnE '\b[0-9]+\s+(issuer connectors?|target connectors?|notifier connectors?|discovery connectors?|MCP tools|OpenAPI operations|migrations|database tables|frontend pages|HTTP routes)\b' \
|
|
README.md docs/ 2>/dev/null \
|
|
| grep -vE 'WORKSPACE-CHANGELOG|seed_demo|demo override' \
|
|
| grep -vE 'DRIFT HAZARD|Source: |Rebuild|rebuild via|grep -|wc -l|ls -d|find ' \
|
|
| grep -vE 'README claims [0-9]+ issuer connectors but only [0-9]+ exist' \
|
|
|| true)
|
|
if [ -n "$BAD" ]; then
|
|
echo "::error::S-1 regression: hardcoded source-count prose reappeared:"
|
|
echo "$BAD"
|
|
echo ""
|
|
echo "CLAUDE.md rule: 'Numeric claims about current state rot.'"
|
|
echo "Replace the count with the grep command from CLAUDE.md::"
|
|
echo "'Current-state commands' (e.g. 'ls -d internal/connector/issuer/*/ | wc -l')"
|
|
echo "or rephrase to reference the rebuild command on the same line."
|
|
echo "See coverage-gap-audit-2026-04-24-v5/unified-audit.md"
|
|
echo "cat-s1-9ce1cbe26876 for closure rationale."
|
|
exit 1
|
|
fi
|
|
echo "S-1 hardcoded-source-counts: clean."
|