mirror of
https://github.com/shankar0123/certctl.git
synced 2026-06-08 20:28:52 +00:00
shankar0123
1caedd5fd3
Bundle: ci-pipeline-cleanup, Phase 1. Pure relocation — no behavior change. Each guard's bash logic is byte-identical to the prior inline version; the only changes are: (a) the guard becomes a sibling script under scripts/ci-guards/<id>.sh, (b) ci.yml's per-guard step is replaced by a single loop step that iterates all scripts. 20 scripts extracted (alphabetized): B-1-orphan-crud.sh, D-1-D-2-statusbadge-phantom.sh, G-1-jwt-auth-literal.sh, G-2-api-key-hash-json.sh, G-3-env-docs-drift.sh, H-001-bare-from.sh, H-009-readme-jwt.sh, L-001-insecure-skip-verify.sh, L-1-bulk-action-loop.sh, M-012-no-root-user.sh, P-1-documented-orphan-fns.sh, S-1-hardcoded-source-counts.sh, S-2-strings-contains-err.sh, T-1-frontend-page-coverage.sh, U-2-plaintext-healthcheck.sh, U-3-migration-mount.sh, bundle-8-L-015-target-blank-rel-noopener.sh, bundle-8-L-019-dangerously-set-inner-html.sh, bundle-8-M-009-bare-usemutation.sh, test-naming-convention.sh Plus scripts/ci-guards/README.md documenting the contract: - Each script must exit 0 on clean repo, non-zero with ::error:: prefix on regression - Runnable from repo root via 'bash scripts/ci-guards/<id>.sh' - Adding a new guard: drop a new <id>.sh; CI auto-picks it up ci.yml dropped 1488 → 557 lines (-931, -63%). Single CI loop step now collects ALL guard failures before failing the build instead of fail-fast — UX win for regressions that hit two guards at once. Two guards (QA-doc Part-count + seed-count, ci.yml lines 868-917) deliberately NOT extracted — they move to 'make verify-docs' in Phase 11 because they protect docs-the-operator-reads, not the product itself. Verification (sandbox): - All 20 scripts pass against HEAD (chmod +x; for g in scripts/ci-guards/*.sh; do bash $g; done) - New ci.yml YAML-parses cleanly - Job boundaries preserved: go-build-and-test, frontend-build, helm-lint, deploy-vendor-e2e, deploy-vendor-e2e-windows - Loop step appears twice (once at end of go-build-and-test, once at end of frontend-build) so both jobs continue running their set of guards
39 lines
1.5 KiB
Bash
Executable File
39 lines
1.5 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
# scripts/ci-guards/L-001-insecure-skip-verify.sh
|
|
#
|
|
# L-001 audited every production InsecureSkipVerify=true call site
|
|
# and documented the justification per site in docs/tls.md. This
|
|
# script grep-fails the build if any new `InsecureSkipVerify: true`
|
|
# lands in a non-test Go file without a `//nolint:gosec` comment
|
|
# carrying the justification. Test files (_test.go) are exempt.
|
|
# Updating the documented surface goes through the docs/tls.md
|
|
# table — net-new sites must be reasoned about before merge.
|
|
|
|
set -e
|
|
# Find every "InsecureSkipVerify: true" or "InsecureSkipVerify = true"
|
|
# in a non-test .go file. Then for each, check the same line OR the
|
|
# immediately preceding line for `//nolint:gosec`.
|
|
BAD=""
|
|
while IFS= read -r match; do
|
|
file=$(echo "$match" | cut -d: -f1)
|
|
line=$(echo "$match" | cut -d: -f2)
|
|
same=$(sed -n "${line}p" "$file" 2>/dev/null)
|
|
prev=$(sed -n "$((line - 1))p" "$file" 2>/dev/null)
|
|
if echo "$same $prev" | grep -q 'nolint:gosec'; then
|
|
continue
|
|
fi
|
|
BAD="$BAD\n$match"
|
|
done < <(grep -rnE 'InsecureSkipVerify:\s*true|InsecureSkipVerify\s*=\s*true' \
|
|
--include='*.go' \
|
|
--exclude='*_test.go' \
|
|
. || true)
|
|
if [ -n "$BAD" ]; then
|
|
echo "::error::L-001 regression: new InsecureSkipVerify=true site without //nolint:gosec justification:"
|
|
echo -e "$BAD"
|
|
echo ""
|
|
echo "Add a //nolint:gosec comment with justification on the same"
|
|
echo "or preceding line, AND add a row to the docs/tls.md table."
|
|
exit 1
|
|
fi
|
|
echo "L-001 insecure-skip-verify: clean."
|