mirror of
https://github.com/shankar0123/certctl.git
synced 2026-06-07 23:11:32 +00:00
fb4362e534
Two audit findings, both category cat-l, both rooted in
web/src/pages/CertificatesPage.tsx. Pre-L-1 the GUI looped per-cert
HTTP calls — 100 selected certs = 100 sequential round-trips × ~50–200
ms each = a 5–20-second wedge during which the operator stared at a
progress bar. Post-L-1 each workflow is a single POST.
cat-l-fa0c1ac07ab5 [P1, primary] — bulk renew loop
handleBulkRenewal: for/await triggerRenewal(id)
cat-l-8a1fb258a38a [P2] — bulk reassign loop
handleReassign: for/await updateCertificate(id, {owner_id})
The bulk-revoke endpoint (POST /api/v1/certificates/bulk-revoke +
BulkRevocationCriteria/Result) already existed as the canonical shape
in v2.0.x — L-1 ports that pattern to renew + reassign with per-action
twists.
Backend (Go)
- internal/domain/bulk_renewal.go: BulkRenewalCriteria mirrors
BulkRevocationCriteria (criteria + IDs modes); BulkRenewalResult
envelope adds EnqueuedJobs[] for per-cert {certificate_id, job_id};
shared BulkOperationError type for all bulk paths.
- internal/domain/bulk_reassignment.go: narrower shape — IDs-only,
owner_id required, team_id optional.
- internal/service/bulk_renewal.go::BulkRenewalService.BulkRenew:
resolves criteria → status filter (Archived/Revoked/Expired/
RenewalInProgress all silent-skip) → per-cert status flip + job
create. Keygen-mode-aware so jobs land in the same initial status
as single-cert TriggerRenewal. Single bulk audit event per call,
not N.
- internal/service/bulk_reassignment.go::BulkReassignmentService.
BulkReassign: validates owner_id upfront via the
ErrBulkReassignOwnerNotFound typed sentinel — non-existent owner
returns 400 before any cert is touched. Already-owned-by-target
is silent-skip. Single bulk audit event.
- internal/api/handler/{bulk_renewal,bulk_reassignment}.go: HTTP
shape mirrors bulk_revocation.go. NOT admin-gated (renew is non-
destructive; reassign is a common-case workflow). Sentinel-error
→ 400 mapping for OwnerNotFound.
- internal/api/router/router.go: three bulk-* routes registered as a
block before the {id} routes. HandlerRegistry gains BulkRenewal +
BulkReassignment fields.
- cmd/server/main.go: NewBulkRenewalService threads cfg.Keygen.Mode
so bulk-renew jobs land in same initial state as single-cert path.
Frontend
- web/src/api/client.ts: bulkRenewCertificates(criteria) +
bulkReassignCertificates(request) functions with full TS types.
- web/src/pages/CertificatesPage.tsx: handleBulkRenewal + handleReassign
rewritten from N-call loops to single calls. Result envelope drives
progress UI; first-error message surfaced when total_failed > 0.
Stale triggerRenewal + updateCertificate imports removed.
MCP
- internal/mcp/types.go: BulkRenewCertificatesInput +
BulkReassignCertificatesInput.
- internal/mcp/tools.go: certctl_bulk_renew_certificates +
certctl_bulk_reassign_certificates tools mirroring the existing
certctl_bulk_revoke_certificates pattern.
OpenAPI
- api/openapi.yaml: two new operations (bulkRenewCertificates,
bulkReassignCertificates) under Certificates tag. Four new schemas
(BulkRenewRequest, BulkRenewResult, BulkEnqueuedJob,
BulkReassignRequest, BulkReassignResult).
Tests
- Domain: BulkRenewalCriteria.IsEmpty + BulkReassignmentRequest.IsEmpty
IsEmpty contracts; JSON round-trip shape pinning.
- Service: 7 BulkRenew tests (happy/criteria-mode/skips-RenewalInProgress/
skips-revoked-archived/empty-criteria-error/partial-failure/
audit-event-emitted) + 8 BulkReassign tests (happy/skips-already-
owned/owner-required/empty-IDs/owner-not-found-sentinel/team-id-
optional/team-id-provided/partial-failure/audit-event-emitted).
- Handler: 5 BulkRenew handler tests (happy/empty-body-400/wrong-
method-405/actor-attribution/service-error-500) + 6 BulkReassign
handler tests (happy/empty-IDs-400/missing-owner-400/owner-not-
found-400-via-sentinel/wrong-method-405/generic-error-500).
CI guardrail
- .github/workflows/ci.yml: 'Forbidden client-side bulk-action loop
regression guard (L-1)'. Greps web/src/pages/CertificatesPage.tsx
for 'for(...) await triggerRenewal(...)' and 'for(...) await
updateCertificate(...)' patterns; comment lines exempt; test files
exempt. Verified locally (passes against post-fix tree, fires
against synthetic regression).
Counts (deltas)
- Routes: 119 → 121 (+2)
- OpenAPI operations: 123 → 125 (+2)
- MCP tools: 83 → 85 (+2)
Performance
- 100-cert bulk-renew: ~10s of sequential HTTP → ~100ms (99% latency
reduction on the canonical operator workflow).
- Audit event volume: 1 + N per operation → 1.
Out of scope (deferred follow-ups)
- cat-b-31ceb6aaa9f1: updateOwner/updateTeam/updateAgentGroup orphan
(different shape — wire existing PUT to GUI, not new bulk endpoint).
- cat-k-e85d1099b2d7: CertificatesPage no pagination UI.
- cat-i-b0924b6675f8: MCP missing claim/dismiss/acknowledge (L-1 added
2 new tools but does not close that finding).
Verification
- go build / vet / test -short / test -short -race all clean.
- web tsc --noEmit + vitest run all clean (296 tests passing).
- OpenAPI YAML parses (89 paths, 125 ops).
- L-1 CI guardrail passes against post-fix tree, fires against
synthetic regression.
No push.
105 lines
3.5 KiB
Go
105 lines
3.5 KiB
Go
package handler
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"errors"
|
|
"net/http"
|
|
|
|
"github.com/shankar0123/certctl/internal/api/middleware"
|
|
"github.com/shankar0123/certctl/internal/domain"
|
|
"github.com/shankar0123/certctl/internal/service"
|
|
)
|
|
|
|
// BulkReassignmentService defines the service interface for bulk
|
|
// owner-reassignment operations.
|
|
type BulkReassignmentService interface {
|
|
BulkReassign(ctx context.Context, request domain.BulkReassignmentRequest, actor string) (*domain.BulkReassignmentResult, error)
|
|
}
|
|
|
|
// BulkReassignmentHandler handles HTTP requests for bulk reassignment
|
|
// operations.
|
|
type BulkReassignmentHandler struct {
|
|
svc BulkReassignmentService
|
|
}
|
|
|
|
// NewBulkReassignmentHandler creates a new BulkReassignmentHandler.
|
|
func NewBulkReassignmentHandler(svc BulkReassignmentService) BulkReassignmentHandler {
|
|
return BulkReassignmentHandler{svc: svc}
|
|
}
|
|
|
|
// bulkReassignRequest is the JSON shape decoded from the request body.
|
|
type bulkReassignRequest struct {
|
|
CertificateIDs []string `json:"certificate_ids"`
|
|
OwnerID string `json:"owner_id"`
|
|
TeamID string `json:"team_id,omitempty"`
|
|
}
|
|
|
|
// BulkReassign handles POST /api/v1/certificates/bulk-reassign
|
|
//
|
|
// L-2 closure (cat-l-8a1fb258a38a): pre-L-2 the GUI looped
|
|
// `await updateCertificate(id, { owner_id })`. Post-L-2 the GUI POSTs
|
|
// once and the server mutates owner_id (and optionally team_id) on N
|
|
// certs, returning per-cert success/skip/error counts.
|
|
//
|
|
// Narrower contract than bulk-renew: explicit IDs only, no criteria-mode.
|
|
// OwnerID is required; TeamID is optional and updates the team only when
|
|
// non-empty (matches the existing per-cert PUT contract).
|
|
//
|
|
// Auth: any authenticated caller can reassign certs they own/have
|
|
// access to. NOT admin-gated — operators reassign ownership during
|
|
// team transitions all the time and gating that on admin would block
|
|
// the common-case workflow.
|
|
//
|
|
// Validation order: empty body → 400; empty IDs → 400; missing
|
|
// owner_id → 400; non-existent owner_id → 400 via the
|
|
// ErrBulkReassignOwnerNotFound sentinel mapped here.
|
|
func (h BulkReassignmentHandler) BulkReassign(w http.ResponseWriter, r *http.Request) {
|
|
if r.Method != http.MethodPost {
|
|
Error(w, http.StatusMethodNotAllowed, "Method not allowed")
|
|
return
|
|
}
|
|
requestID := middleware.GetRequestID(r.Context())
|
|
|
|
var req bulkReassignRequest
|
|
if err := json.NewDecoder(r.Body).Decode(&req); err != nil {
|
|
ErrorWithRequestID(w, http.StatusBadRequest, "Invalid request body", requestID)
|
|
return
|
|
}
|
|
|
|
request := domain.BulkReassignmentRequest{
|
|
CertificateIDs: req.CertificateIDs,
|
|
OwnerID: req.OwnerID,
|
|
TeamID: req.TeamID,
|
|
}
|
|
if request.IsEmpty() {
|
|
ErrorWithRequestID(w, http.StatusBadRequest,
|
|
"At least one certificate_id is required",
|
|
requestID)
|
|
return
|
|
}
|
|
if request.OwnerID == "" {
|
|
ErrorWithRequestID(w, http.StatusBadRequest, "owner_id is required", requestID)
|
|
return
|
|
}
|
|
|
|
actor := resolveActor(r.Context())
|
|
|
|
result, err := h.svc.BulkReassign(r.Context(), request, actor)
|
|
if err != nil {
|
|
// Sentinel-error → 400 mapping. ErrBulkReassignOwnerNotFound
|
|
// means the operator picked an owner that doesn't exist; this
|
|
// is bad input (400), not a server error (500). Mirrors the
|
|
// post-M-1 errToStatus convention rather than substring-matching
|
|
// err.Error().
|
|
if errors.Is(err, service.ErrBulkReassignOwnerNotFound) {
|
|
ErrorWithRequestID(w, http.StatusBadRequest, err.Error(), requestID)
|
|
return
|
|
}
|
|
ErrorWithRequestID(w, http.StatusInternalServerError, "Bulk reassignment failed: "+err.Error(), requestID)
|
|
return
|
|
}
|
|
|
|
JSON(w, http.StatusOK, result)
|
|
}
|