Files
certctl/web/src/pages/ShortLivedPage.test.tsx
T
shankar0123 12adc97381 Bundle H follow-up #2: end-to-end fix for Pass 3 CI multi-match failures
Second CI run surfaced 8 real failures across 7 detail/list pages and 1

mock-shape error. Root causes:

  1. Multi-match disambiguation. screen.getByText(...) matched both the

     PageHeader <h2> AND duplicated text in InfoRow / detail-row spans

     within the same page (e.g., issuer name appears as page title AND

     in the Issuer Details panel; cert.common_name appears as page title

     AND in the Common Name InfoRow). The regex variants (getByText(/X/i))

     were even worse — matched any element containing the substring.

  2. NetworkScanPage mock-shape. xssScanTarget.ports was '443,8443'

     (string), but NetworkScanPage.tsx:180 calls t.ports?.join() which

     requires a number[] per src/api/types.ts:506. Page errored before

     rendering the DataTable, so the XSS test's body.textContent

     assertion saw an empty string.

Fixes:

  - Every page-title assertion in the 14 Pass 3 test files now uses

    screen.getByRole('heading', { level: 2, name: ... }), which matches

    ONLY the PageHeader <h2> (PageHeader.tsx:11 renders an actual <h2>).

    Detail-row spans / InfoRow text / column-header text in lower-level

    headings (h3) is excluded by the level filter.

  - NetworkScanPage xssScanTarget.ports changed from '443,8443' (string)

    to [443, 8443] (number[]) per the NetworkScanTarget TS type.

Pages with assertion fixes (8 tests across 7 files):

  - AgentFleetPage         /Agent/i        -> 'Agent Fleet Overview' (h2)

  - AuditPage              /Audit/         -> 'Audit Trail' (h2)

  - CertificateDetailPage  'plain.example.com' (text)  -> heading h2

  - HealthMonitorPage      /Health/i       -> 'Health Monitor' (h2)

  - IssuerDetailPage       'Plain Name' (text)         -> heading h2

  - JobDetailPage          /j-xss-001/ (text)          -> heading h2

  - JobsPage               /Jobs/i         -> 'Jobs' (h2)

  - ProfilesPage           /Profile/i      -> 'Certificate Profiles' (h2)

  - TargetDetailPage       'Plain Name' (text)         -> heading h2

Plus 4 already-correct pages updated for consistency:

  - DigestPage             text 'Certificate Digest'   -> heading h2

  - ObservabilityPage      text 'Observability'        -> heading h2

  - NetworkScanPage        /Network/i      -> 'Network Scanning' (h2)

  - ShortLivedPage         text 'Short-Lived...'       -> heading h2

Mock-shape fix:

  - NetworkScanPage.test.tsx  ports: '443,8443' -> [443, 8443]

End-to-end audit:

  Every Pass 3 test now anchors on the unambiguous PageHeader <h2>;

  no remaining getByText() with regex or substring that could spuriously

  multi-match. Mock data shapes verified against src/api/types.ts

  interfaces (NetworkScanTarget, MetricsResponse, ManagedCertificate).
2026-04-27 03:24:31 +00:00

120 lines
4.2 KiB
TypeScript

import { describe, it, expect, vi, beforeEach } from 'vitest';
import { render, screen, waitFor, cleanup } from '@testing-library/react';
import { QueryClient, QueryClientProvider } from '@tanstack/react-query';
import { MemoryRouter } from 'react-router-dom';
import type { ReactNode } from 'react';
// -----------------------------------------------------------------------------
// M-029 Pass 3 (Audit M-026): ShortLivedPage XSS-hardening + render coverage.
//
// ShortLivedPage renders a filtered subset of certificates (those tied to a
// short-lived profile or with <1h remaining). Cert subject DN / SAN / id /
// environment / issuer_id all flow into JSX text — these are operator-
// controlled or CSR-controlled fields and a careless refactor that switched
// to dangerouslySetInnerHTML would let an attacker-controlled CSR deliver
// an XSS payload via subject DN.
//
// Pins:
// 1. Page renders.
// 2. Cert fields containing literal <script> payloads do NOT execute.
// 3. The literal payload text appears as escaped content.
// -----------------------------------------------------------------------------
vi.mock('../api/client', () => ({
getCertificates: vi.fn(),
getProfiles: vi.fn(),
}));
import ShortLivedPage from './ShortLivedPage';
import * as client from '../api/client';
function renderWithQuery(ui: ReactNode) {
const qc = new QueryClient({
defaultOptions: { queries: { retry: false, gcTime: 0, staleTime: 0 } },
});
return render(
<QueryClientProvider client={qc}>
<MemoryRouter>{ui}</MemoryRouter>
</QueryClientProvider>,
);
}
const inOneHour = new Date(Date.now() + 30 * 60 * 1000).toISOString();
const xssPayload = '<script data-xss="shortlived">window.__xss_pwned__=1;</script>';
const xssCert = {
id: 'mc-xss-001',
name: xssPayload,
common_name: xssPayload,
status: 'Active',
environment: xssPayload,
issuer_id: xssPayload,
certificate_profile_id: 'cp-shortlived',
expires_at: inOneHour,
created_at: new Date().toISOString(),
};
describe('ShortLivedPage — render + XSS hardening (M-026 / M-029 Pass 3)', () => {
beforeEach(() => {
vi.clearAllMocks();
cleanup();
delete (window as unknown as { __xss_pwned__?: number }).__xss_pwned__;
});
it('renders the page header when certs resolve', async () => {
vi.mocked(client.getCertificates).mockResolvedValue({ data: [], total: 0, page: 1, per_page: 50 } as never);
vi.mocked(client.getProfiles).mockResolvedValue({ data: [], total: 0, page: 1, per_page: 50 } as never);
renderWithQuery(<ShortLivedPage />);
await waitFor(() => {
expect(screen.getByRole('heading', { level: 2, name: 'Short-Lived Credentials' })).toBeInTheDocument();
});
});
it('does NOT execute <script> payloads embedded in cert fields', async () => {
vi.mocked(client.getCertificates).mockResolvedValue({
data: [xssCert],
total: 1,
page: 1,
per_page: 50,
} as never);
vi.mocked(client.getProfiles).mockResolvedValue({
data: [{ id: 'cp-shortlived', name: 'Short-lived', allow_short_lived: true, max_ttl_seconds: 60 }],
total: 1,
page: 1,
per_page: 50,
} as never);
renderWithQuery(<ShortLivedPage />);
await waitFor(() => {
expect(screen.getByRole('heading', { level: 2, name: 'Short-Lived Credentials' })).toBeInTheDocument();
});
const liveScripts = document.querySelectorAll('script[data-xss="shortlived"]');
expect(liveScripts.length, 'cert subject must not inject a live <script>').toBe(0);
expect(
(window as unknown as { __xss_pwned__?: number }).__xss_pwned__,
'cert <script> body must not have executed',
).toBeUndefined();
});
it('renders the literal payload as escaped text', async () => {
vi.mocked(client.getCertificates).mockResolvedValue({
data: [xssCert],
total: 1,
page: 1,
per_page: 50,
} as never);
vi.mocked(client.getProfiles).mockResolvedValue({
data: [{ id: 'cp-shortlived', name: 'Short-lived', allow_short_lived: true, max_ttl_seconds: 60 }],
total: 1,
page: 1,
per_page: 50,
} as never);
renderWithQuery(<ShortLivedPage />);
await waitFor(() => {
expect(document.body.textContent ?? '').toContain('<script data-xss="shortlived">');
});
});
});