Files
certctl/internal/service/issuer_adapter_test.go
T
shankar0123 690765b53e test: comprehensive test expansion — 330+ to 525+ tests, close M11b coverage gaps
Add 195+ new tests across service, handler, connector, and integration layers:
- Service tests: team (23), owner (21), agent_group (25), issuer (18), issuer_adapter (6)
- Handler tests: teams (26), owners (21)
- NGINX target connector tests (13): config validation, deployment, reload
- Integration tests: 19 M11b endpoint subtests (teams, owners, agent groups CRUD)
- CI pipeline: add ./internal/connector/target/... to test coverage path
- Docs: update test counts to 525+ across README, architecture, CLAUDE.md

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-21 23:43:32 -04:00

330 lines
9.1 KiB
Go

package service
import (
"context"
"errors"
"testing"
"time"
"github.com/shankar0123/certctl/internal/connector/issuer"
)
// mockConnectorLayerIssuer is a test implementation of issuer.Connector
type mockConnectorLayerIssuer struct {
issueResult *issuer.IssuanceResult
issueErr error
renewResult *issuer.IssuanceResult
renewErr error
lastIssueReq *issuer.IssuanceRequest
lastRenewReq *issuer.RenewalRequest
validateErr error
revokeErr error
orderStatusErr error
orderStatus *issuer.OrderStatus
}
func (m *mockConnectorLayerIssuer) ValidateConfig(ctx context.Context, config []byte) error {
return m.validateErr
}
func (m *mockConnectorLayerIssuer) IssueCertificate(ctx context.Context, request issuer.IssuanceRequest) (*issuer.IssuanceResult, error) {
m.lastIssueReq = &request
if m.issueErr != nil {
return nil, m.issueErr
}
if m.issueResult != nil {
return m.issueResult, nil
}
// Return default result
now := time.Now()
return &issuer.IssuanceResult{
CertPEM: "-----BEGIN CERTIFICATE-----\ndefault-cert\n-----END CERTIFICATE-----",
ChainPEM: "-----BEGIN CERTIFICATE-----\ndefault-chain\n-----END CERTIFICATE-----",
Serial: "default-serial-123",
NotBefore: now,
NotAfter: now.AddDate(1, 0, 0),
OrderID: "order-default",
}, nil
}
func (m *mockConnectorLayerIssuer) RenewCertificate(ctx context.Context, request issuer.RenewalRequest) (*issuer.IssuanceResult, error) {
m.lastRenewReq = &request
if m.renewErr != nil {
return nil, m.renewErr
}
if m.renewResult != nil {
return m.renewResult, nil
}
// Return default result
now := time.Now()
return &issuer.IssuanceResult{
CertPEM: "-----BEGIN CERTIFICATE-----\ndefault-renewed-cert\n-----END CERTIFICATE-----",
ChainPEM: "-----BEGIN CERTIFICATE-----\ndefault-renewed-chain\n-----END CERTIFICATE-----",
Serial: "default-renewed-serial-456",
NotBefore: now,
NotAfter: now.AddDate(1, 0, 0),
OrderID: "order-renewed",
}, nil
}
func (m *mockConnectorLayerIssuer) RevokeCertificate(ctx context.Context, request issuer.RevocationRequest) error {
return m.revokeErr
}
func (m *mockConnectorLayerIssuer) GetOrderStatus(ctx context.Context, orderID string) (*issuer.OrderStatus, error) {
if m.orderStatusErr != nil {
return nil, m.orderStatusErr
}
if m.orderStatus != nil {
return m.orderStatus, nil
}
status := "pending"
return &issuer.OrderStatus{
OrderID: orderID,
Status: status,
UpdatedAt: time.Now(),
}, nil
}
// Tests for IssueCertificate
func TestIssuerConnectorAdapter_IssueCertificate_Success(t *testing.T) {
ctx := context.Background()
now := time.Now()
notAfter := now.AddDate(1, 0, 0)
mock := &mockConnectorLayerIssuer{
issueResult: &issuer.IssuanceResult{
CertPEM: "-----BEGIN CERTIFICATE-----\ntest-cert\n-----END CERTIFICATE-----",
ChainPEM: "-----BEGIN CERTIFICATE-----\ntest-chain\n-----END CERTIFICATE-----",
Serial: "test-serial-001",
NotBefore: now,
NotAfter: notAfter,
OrderID: "order-123",
},
}
adapter := NewIssuerConnectorAdapter(mock)
result, err := adapter.IssueCertificate(ctx, "example.com", []string{"www.example.com"}, "-----BEGIN CERTIFICATE REQUEST-----\nCSR\n-----END CERTIFICATE REQUEST-----")
if err != nil {
t.Fatalf("IssueCertificate failed: %v", err)
}
if result.Serial != "test-serial-001" {
t.Errorf("expected serial test-serial-001, got %s", result.Serial)
}
if result.CertPEM != "-----BEGIN CERTIFICATE-----\ntest-cert\n-----END CERTIFICATE-----" {
t.Errorf("expected CertPEM test-cert, got %s", result.CertPEM)
}
if result.ChainPEM != "-----BEGIN CERTIFICATE-----\ntest-chain\n-----END CERTIFICATE-----" {
t.Errorf("expected ChainPEM test-chain, got %s", result.ChainPEM)
}
if !result.NotBefore.Equal(now) {
t.Errorf("expected NotBefore %v, got %v", now, result.NotBefore)
}
if !result.NotAfter.Equal(notAfter) {
t.Errorf("expected NotAfter %v, got %v", notAfter, result.NotAfter)
}
}
func TestIssuerConnectorAdapter_IssueCertificate_Error(t *testing.T) {
ctx := context.Background()
testErr := errors.New("issuer connection failed")
mock := &mockConnectorLayerIssuer{
issueErr: testErr,
}
adapter := NewIssuerConnectorAdapter(mock)
result, err := adapter.IssueCertificate(ctx, "example.com", []string{}, "csr")
if err == nil {
t.Fatal("expected error, got nil")
}
if !errors.Is(err, testErr) {
t.Errorf("expected error %v, got %v", testErr, err)
}
if result != nil {
t.Errorf("expected nil result, got %v", result)
}
}
func TestIssuerConnectorAdapter_IssueCertificate_RequestTranslation(t *testing.T) {
ctx := context.Background()
mock := &mockConnectorLayerIssuer{
issueResult: &issuer.IssuanceResult{
CertPEM: "cert",
ChainPEM: "chain",
Serial: "serial",
NotBefore: time.Now(),
NotAfter: time.Now().AddDate(1, 0, 0),
},
}
adapter := NewIssuerConnectorAdapter(mock)
commonName := "test.example.com"
sans := []string{"www.test.example.com", "api.test.example.com"}
csrPEM := "-----BEGIN CERTIFICATE REQUEST-----\nCSR\n-----END CERTIFICATE REQUEST-----"
_, err := adapter.IssueCertificate(ctx, commonName, sans, csrPEM)
if err != nil {
t.Fatalf("IssueCertificate failed: %v", err)
}
// Verify request was passed through correctly
if mock.lastIssueReq == nil {
t.Fatal("expected request to be recorded")
}
if mock.lastIssueReq.CommonName != commonName {
t.Errorf("expected CommonName %s, got %s", commonName, mock.lastIssueReq.CommonName)
}
if len(mock.lastIssueReq.SANs) != len(sans) {
t.Errorf("expected %d SANs, got %d", len(sans), len(mock.lastIssueReq.SANs))
}
for i, san := range sans {
if mock.lastIssueReq.SANs[i] != san {
t.Errorf("expected SAN[%d] %s, got %s", i, san, mock.lastIssueReq.SANs[i])
}
}
if mock.lastIssueReq.CSRPEM != csrPEM {
t.Errorf("expected CSRPEM %s, got %s", csrPEM, mock.lastIssueReq.CSRPEM)
}
}
// Tests for RenewCertificate
func TestIssuerConnectorAdapter_RenewCertificate_Success(t *testing.T) {
ctx := context.Background()
now := time.Now()
notAfter := now.AddDate(1, 0, 0)
mock := &mockConnectorLayerIssuer{
renewResult: &issuer.IssuanceResult{
CertPEM: "-----BEGIN CERTIFICATE-----\nrenewed-cert\n-----END CERTIFICATE-----",
ChainPEM: "-----BEGIN CERTIFICATE-----\nrenewed-chain\n-----END CERTIFICATE-----",
Serial: "renewed-serial-002",
NotBefore: now,
NotAfter: notAfter,
OrderID: "order-456",
},
}
adapter := NewIssuerConnectorAdapter(mock)
result, err := adapter.RenewCertificate(ctx, "example.com", []string{"www.example.com"}, "-----BEGIN CERTIFICATE REQUEST-----\nCSR\n-----END CERTIFICATE REQUEST-----")
if err != nil {
t.Fatalf("RenewCertificate failed: %v", err)
}
if result.Serial != "renewed-serial-002" {
t.Errorf("expected serial renewed-serial-002, got %s", result.Serial)
}
if result.CertPEM != "-----BEGIN CERTIFICATE-----\nrenewed-cert\n-----END CERTIFICATE-----" {
t.Errorf("expected CertPEM renewed-cert, got %s", result.CertPEM)
}
if result.ChainPEM != "-----BEGIN CERTIFICATE-----\nrenewed-chain\n-----END CERTIFICATE-----" {
t.Errorf("expected ChainPEM renewed-chain, got %s", result.ChainPEM)
}
if !result.NotBefore.Equal(now) {
t.Errorf("expected NotBefore %v, got %v", now, result.NotBefore)
}
if !result.NotAfter.Equal(notAfter) {
t.Errorf("expected NotAfter %v, got %v", notAfter, result.NotAfter)
}
}
func TestIssuerConnectorAdapter_RenewCertificate_Error(t *testing.T) {
ctx := context.Background()
testErr := errors.New("renewal failed")
mock := &mockConnectorLayerIssuer{
renewErr: testErr,
}
adapter := NewIssuerConnectorAdapter(mock)
result, err := adapter.RenewCertificate(ctx, "example.com", []string{}, "csr")
if err == nil {
t.Fatal("expected error, got nil")
}
if !errors.Is(err, testErr) {
t.Errorf("expected error %v, got %v", testErr, err)
}
if result != nil {
t.Errorf("expected nil result, got %v", result)
}
}
func TestIssuerConnectorAdapter_RenewCertificate_RequestTranslation(t *testing.T) {
ctx := context.Background()
mock := &mockConnectorLayerIssuer{
renewResult: &issuer.IssuanceResult{
CertPEM: "cert",
ChainPEM: "chain",
Serial: "serial",
NotBefore: time.Now(),
NotAfter: time.Now().AddDate(1, 0, 0),
},
}
adapter := NewIssuerConnectorAdapter(mock)
commonName := "renew.example.com"
sans := []string{"www.renew.example.com"}
csrPEM := "-----BEGIN CERTIFICATE REQUEST-----\nRENEW-CSR\n-----END CERTIFICATE REQUEST-----"
_, err := adapter.RenewCertificate(ctx, commonName, sans, csrPEM)
if err != nil {
t.Fatalf("RenewCertificate failed: %v", err)
}
// Verify request was passed through correctly
if mock.lastRenewReq == nil {
t.Fatal("expected request to be recorded")
}
if mock.lastRenewReq.CommonName != commonName {
t.Errorf("expected CommonName %s, got %s", commonName, mock.lastRenewReq.CommonName)
}
if len(mock.lastRenewReq.SANs) != len(sans) {
t.Errorf("expected %d SANs, got %d", len(sans), len(mock.lastRenewReq.SANs))
}
for i, san := range sans {
if mock.lastRenewReq.SANs[i] != san {
t.Errorf("expected SAN[%d] %s, got %s", i, san, mock.lastRenewReq.SANs[i])
}
}
if mock.lastRenewReq.CSRPEM != csrPEM {
t.Errorf("expected CSRPEM %s, got %s", csrPEM, mock.lastRenewReq.CSRPEM)
}
}