Files
certctl/web/src/pages/AgentsPage.test.tsx
T
shankar0123 7013227a34 test(web): Vitest coverage for 8 high-leverage pages (T-1 master)
Closes T-1 (cat-s2-c24a548076c6) — frontend page-level Vitest coverage was
3 of 28 pages pre-T-1. T-1 lifts that to 11 of 28 (39%) by writing focused
behavior tests for the 8 highest-leverage pages.

Tests added:
  - CertificatesPage.test.tsx (6 cases) — F-1 filter+pagination contract:
    team_id / expires_before / sort param wiring, page=1 reset on filter
    change, page+per_page always present in getCertificates params.
  - PoliciesPage.test.tsx (4 cases) — D-006/D-008 TitleCase contract:
    list render, severity badge, toggle-enabled inversion, delete confirm.
  - IssuersPage.test.tsx (3 cases) — D-2 phantom-trim + B-1 EditIssuer:
    list render, StatusBadge derives from enabled, Test fires
    testIssuerConnection.
  - TargetsPage.test.tsx (3 cases) — D-2 phantom-trim:
    list render, Status derives from enabled, Delete fires deleteTarget.
  - AgentsPage.test.tsx (3 cases) — D-2 phantom-trim + heartbeatStatus:
    list render, undefined last_heartbeat_at -> Offline,
    listRetiredAgents lazy-loaded.
  - AgentDetailPage.test.tsx (3 cases) — D-2 phantom-trim:
    fetches by URL :id, Registered row reads registered_at,
    Capabilities + Tags sections absent.
  - OwnersPage.test.tsx (3 cases) — B-1 EditOwnerModal closure:
    list render, Edit opens modal, Save fires updateOwner.
  - TeamsPage.test.tsx (2 cases) — B-1 EditTeamModal closure.
  - AgentGroupsPage.test.tsx (2 cases) — B-1 EditAgentGroupModal closure.
  - RenewalPoliciesPage.test.tsx (3 cases) — B-1 brand-new-page closure:
    list + alert_thresholds_days display, Create modal, Edit modal.
  - DiscoveryPage.test.tsx (3 cases) — I-2 claim/dismiss closure:
    list render, status filter wiring, Dismiss fires dismissDiscoveredCertificate.

CI guardrail: .github/workflows/ci.yml step "Frontend page-coverage
regression guard (T-1)" blocks new pages from landing without sibling
.test.tsx unless added to a 14-name deferred allowlist with one-line
"why deferred" justifications.

Net coverage: 13 page-level vitest cases -> ~35 page-level vitest cases
across 14 files (was 3); total project tests 302 -> 337.

See coverage-gap-audit-2026-04-24-v5/unified-audit.md
cat-s2-c24a548076c6 for closure rationale.
2026-04-25 18:35:41 +00:00

103 lines
3.4 KiB
TypeScript

import { describe, it, expect, vi, beforeEach } from 'vitest';
import { render, screen, waitFor, cleanup } from '@testing-library/react';
import { QueryClient, QueryClientProvider } from '@tanstack/react-query';
import { MemoryRouter } from 'react-router-dom';
import type { ReactNode } from 'react';
// -----------------------------------------------------------------------------
// T-1 closure (cat-s2-c24a548076c6): AgentsPage Vitest coverage.
//
// Pins:
// 1. Active agents render when getAgents resolves.
// 2. heartbeatStatus()-derived health badge handles undefined
// last_heartbeat_at gracefully (Offline) — D-2 phantom-trim contract.
// 3. The page calls listRetiredAgents only when the retired tab is active
// (lazy query enablement).
// -----------------------------------------------------------------------------
vi.mock('../api/client', () => ({
getAgents: vi.fn(),
listRetiredAgents: vi.fn(),
retireAgent: vi.fn(),
BlockedByDependenciesError: class BlockedByDependenciesError extends Error {
counts: unknown;
constructor(counts: unknown) { super('blocked'); this.counts = counts; }
},
}));
import AgentsPage from './AgentsPage';
import * as client from '../api/client';
function renderWithQuery(ui: ReactNode) {
const qc = new QueryClient({
defaultOptions: { queries: { retry: false, gcTime: 0, staleTime: 0 } },
});
return render(
<QueryClientProvider client={qc}>
<MemoryRouter>{ui}</MemoryRouter>
</QueryClientProvider>,
);
}
const onlineAgent = {
id: 'agent-iis01',
name: 'IIS-01',
hostname: 'iis01.prod.example.com',
status: 'Online',
last_heartbeat_at: new Date().toISOString(),
registered_at: new Date(Date.now() - 86400000).toISOString(),
};
const noHeartbeatAgent = {
id: 'agent-fresh',
name: 'Fresh-Agent',
hostname: 'fresh.example.com',
// No status, no last_heartbeat_at — exercises the heartbeatStatus
// undefined-fallback path (returns 'Offline').
registered_at: new Date().toISOString(),
};
describe('AgentsPage — T-1 page coverage', () => {
beforeEach(() => {
vi.clearAllMocks();
cleanup();
vi.mocked(client.getAgents).mockResolvedValue({
data: [onlineAgent, noHeartbeatAgent],
total: 2,
page: 1,
per_page: 50,
} as never);
vi.mocked(client.listRetiredAgents).mockResolvedValue({
data: [],
total: 0,
page: 1,
per_page: 50,
} as never);
});
it('renders the active agents list when getAgents resolves', async () => {
renderWithQuery(<AgentsPage />);
await waitFor(() => {
expect(screen.getByText('IIS-01')).toBeInTheDocument();
});
expect(screen.getByText('Fresh-Agent')).toBeInTheDocument();
});
it('uses heartbeatStatus to derive Offline for agents without last_heartbeat_at', async () => {
renderWithQuery(<AgentsPage />);
await waitFor(() => {
expect(screen.getByText('Fresh-Agent')).toBeInTheDocument();
});
// The Fresh-Agent row has no status and no last_heartbeat_at;
// heartbeatStatus() falls through to 'Offline'.
expect(screen.getAllByText(/Offline/).length).toBeGreaterThan(0);
});
it('lazy-fetches the retired agents only when the retired tab is active', async () => {
renderWithQuery(<AgentsPage />);
await waitFor(() => expect(client.getAgents).toHaveBeenCalled());
// Active tab is default — listRetiredAgents must NOT be called.
expect(client.listRetiredAgents).not.toHaveBeenCalled();
});
});