Files
certctl/internal/service/owner.go
T
Shankar 5463fbcc9f Fix Create methods: respect user-provided IDs and set timestamps
All service-layer Create methods (team, owner, target, issuer,
certificate) were unconditionally overwriting user-provided IDs with
auto-generated ones and leaving CreatedAt/UpdatedAt as zero values.

This caused three user-visible bugs:
- POST /api/v1/teams with {"id": "t-demo"} returned a generated ID
  like "team-1773601137949154216" instead of "t-demo"
- POST /api/v1/owners referencing the user-provided team_id failed
  with Internal Server Error (FK constraint on non-existent generated ID)
- created_at/updated_at came back as "0001-01-01T00:00:00Z"

Fix: all 9 affected Create methods (both context-aware and handler
interface variants) now check if ID is empty before generating, and
set timestamps to time.Now() if zero-valued. Follows the existing
correct pattern in policy.go CreateRule/CreatePolicy.

Also removes two stale temp files (audit.go.* and issuer.go.*) that
were accidentally committed to the repo.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-15 14:52:48 -04:00

182 lines
4.5 KiB
Go

package service
import (
"context"
"fmt"
"time"
"github.com/shankar0123/certctl/internal/domain"
"github.com/shankar0123/certctl/internal/repository"
)
// OwnerService provides business logic for certificate owner management.
type OwnerService struct {
ownerRepo repository.OwnerRepository
auditService *AuditService
}
// NewOwnerService creates a new owner service.
func NewOwnerService(
ownerRepo repository.OwnerRepository,
auditService *AuditService,
) *OwnerService {
return &OwnerService{
ownerRepo: ownerRepo,
auditService: auditService,
}
}
// List returns a paginated list of owners.
func (s *OwnerService) List(ctx context.Context, page, perPage int) ([]*domain.Owner, int64, error) {
if page < 1 {
page = 1
}
if perPage < 1 {
perPage = 50
}
owners, err := s.ownerRepo.List(ctx)
if err != nil {
return nil, 0, fmt.Errorf("failed to list owners: %w", err)
}
total := int64(len(owners))
start := (page - 1) * perPage
if start >= int(total) {
return nil, total, nil
}
end := start + perPage
if end > int(total) {
end = int(total)
}
return owners[start:end], total, nil
}
// Get retrieves an owner by ID.
func (s *OwnerService) Get(ctx context.Context, id string) (*domain.Owner, error) {
owner, err := s.ownerRepo.Get(ctx, id)
if err != nil {
return nil, fmt.Errorf("failed to get owner %s: %w", id, err)
}
return owner, nil
}
// Create validates and stores a new owner.
func (s *OwnerService) Create(ctx context.Context, owner *domain.Owner, actor string) error {
if owner.Name == "" {
return fmt.Errorf("owner name is required")
}
if owner.ID == "" {
owner.ID = generateID("owner")
}
now := time.Now()
if owner.CreatedAt.IsZero() {
owner.CreatedAt = now
}
if owner.UpdatedAt.IsZero() {
owner.UpdatedAt = now
}
if err := s.ownerRepo.Create(ctx, owner); err != nil {
return fmt.Errorf("failed to create owner: %w", err)
}
if s.auditService != nil {
_ = s.auditService.RecordEvent(ctx, actor, domain.ActorTypeUser, "create_owner", "owner", owner.ID, nil)
}
return nil
}
// Update modifies an existing owner.
func (s *OwnerService) Update(ctx context.Context, id string, owner *domain.Owner, actor string) error {
if owner.Name == "" {
return fmt.Errorf("owner name is required")
}
owner.ID = id
if err := s.ownerRepo.Update(ctx, owner); err != nil {
return fmt.Errorf("failed to update owner %s: %w", id, err)
}
if s.auditService != nil {
_ = s.auditService.RecordEvent(ctx, actor, domain.ActorTypeUser, "update_owner", "owner", id, nil)
}
return nil
}
// Delete removes an owner.
func (s *OwnerService) Delete(ctx context.Context, id string, actor string) error {
if err := s.ownerRepo.Delete(ctx, id); err != nil {
return fmt.Errorf("failed to delete owner %s: %w", id, err)
}
if s.auditService != nil {
_ = s.auditService.RecordEvent(ctx, actor, domain.ActorTypeUser, "delete_owner", "owner", id, nil)
}
return nil
}
// ListOwners returns paginated owners (handler interface method).
func (s *OwnerService) ListOwners(page, perPage int) ([]domain.Owner, int64, error) {
if page < 1 {
page = 1
}
if perPage < 1 {
perPage = 50
}
owners, err := s.ownerRepo.List(context.Background())
if err != nil {
return nil, 0, fmt.Errorf("failed to list owners: %w", err)
}
total := int64(len(owners))
var result []domain.Owner
for _, o := range owners {
if o != nil {
result = append(result, *o)
}
}
return result, total, nil
}
// GetOwner returns a single owner (handler interface method).
func (s *OwnerService) GetOwner(id string) (*domain.Owner, error) {
return s.ownerRepo.Get(context.Background(), id)
}
// CreateOwner creates a new owner (handler interface method).
func (s *OwnerService) CreateOwner(owner domain.Owner) (*domain.Owner, error) {
if owner.ID == "" {
owner.ID = generateID("owner")
}
now := time.Now()
if owner.CreatedAt.IsZero() {
owner.CreatedAt = now
}
if owner.UpdatedAt.IsZero() {
owner.UpdatedAt = now
}
if err := s.ownerRepo.Create(context.Background(), &owner); err != nil {
return nil, fmt.Errorf("failed to create owner: %w", err)
}
return &owner, nil
}
// UpdateOwner modifies an owner (handler interface method).
func (s *OwnerService) UpdateOwner(id string, owner domain.Owner) (*domain.Owner, error) {
owner.ID = id
if err := s.ownerRepo.Update(context.Background(), &owner); err != nil {
return nil, fmt.Errorf("failed to update owner: %w", err)
}
return &owner, nil
}
// DeleteOwner removes an owner (handler interface method).
func (s *OwnerService) DeleteOwner(id string) error {
return s.ownerRepo.Delete(context.Background(), id)
}